MantisBT - Zandronum |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0002897 | Zandronum | [All Projects] Bug | public | 2016-10-15 14:38 | 2024-04-08 23:42 |
|
| Reporter | unknownna | |
| Assigned To | | |
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | |
| Platform | | OS | | OS Version | |
| Product Version | 2.1 | |
| Target Version | 3.2 | Fixed in Version | 3.2 | |
|
| Summary | 0002897: Player_SetTeam causes client to initially select fist rather than pistol with different switchonpickup settings online |
| Description | When you join a team through Player_SetTeam online it causes you to bring up the fist rather than the pistol. |
| Steps To Reproduce | teamroom.wad
1. zandronum -host -iwad doom2.wad -file teamroom.wad +ctf 1
2. zandronum -iwad doom2.wad -file teamroom.wad -connect localhost +switchonpickup 0
3. Join the game.
4. Move onto one of the teleporters to join a team. It will have you select the fist first rather than the pistol. |
| Additional Information | It's a regression since 1.0. |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2016-10-15 14:38 | unknownna | New Issue | |
| 2016-10-18 20:16 | Ru5tK1ng | Note Added: 0016051 | |
| 2016-10-18 20:16 | Ru5tK1ng | Status | new => feedback |
| 2016-10-19 08:29 | unknownna | Note Added: 0016055 | |
| 2016-10-19 08:29 | unknownna | Status | feedback => new |
| 2016-10-19 08:32 | unknownna | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=9785#r9785 |
| 2016-10-19 08:32 | unknownna | Additional Information Updated | bug_revision_view_page.php?rev_id=9787#r9787 |
| 2016-10-19 08:33 | unknownna | Summary | Player_SetTeam causes client to initially select fist rather than pistol online => Player_SetTeam causes client to initially select fist rather than pistol with different switchonpickup settings online |
| 2024-03-12 20:32 | Ru5tK1ng | Note Added: 0023378 | |
| 2024-03-12 20:32 | Ru5tK1ng | Status | new => confirmed |
| 2024-03-13 04:40 | Ru5tK1ng | Note Edited: 0023378 | bug_revision_view_page.php?bugnote_id=23378#r14126 |
| 2024-03-13 04:41 | Ru5tK1ng | Note Added: 0023379 | |
| 2024-03-13 04:41 | Ru5tK1ng | Assigned To | => Ru5tK1ng |
| 2024-03-13 04:41 | Ru5tK1ng | Status | confirmed => feedback |
| 2024-03-13 14:42 | unknownna | Note Added: 0023383 | |
| 2024-03-13 14:42 | unknownna | Status | feedback => assigned |
| 2024-03-13 20:16 | Ru5tK1ng | Note Added: 0023387 | |
| 2024-03-13 20:49 | Ru5tK1ng | Note Added: 0023388 | |
| 2024-03-14 04:48 | Ru5tK1ng | Status | assigned => feedback |
| 2024-03-14 06:07 | unknownna | Note Added: 0023392 | |
| 2024-03-14 06:07 | unknownna | Status | feedback => assigned |
| 2024-03-14 16:23 | Ru5tK1ng | Note Added: 0023398 | |
| 2024-03-14 16:23 | Ru5tK1ng | Assigned To | Ru5tK1ng => |
| 2024-03-14 16:23 | Ru5tK1ng | Status | assigned => needs review |
| 2024-03-24 21:17 | Ru5tK1ng | Note Added: 0023486 | |
| 2024-03-24 21:17 | Ru5tK1ng | Status | needs review => needs testing |
| 2024-03-24 21:17 | Ru5tK1ng | Target Version | => 3.2 |
| 2024-04-08 23:42 | Ru5tK1ng | Note Added: 0023565 | |
| 2024-04-08 23:42 | Ru5tK1ng | Status | needs testing => resolved |
| 2024-04-08 23:42 | Ru5tK1ng | Resolution | open => fixed |
| 2024-04-08 23:42 | Ru5tK1ng | Fixed in Version | => 3.2 |
|
Notes |
|
|
|
|
I tried this with 2.1.2 and I never selected the fist when moving over the teleports. I double checked that ctf was true. |
|
|
|
|
|
This is caused by switchonpickup 0 (never) and switchonpickup 3 (use PWO) + pwo_switchonsameweight 0. If you have the pistol set higher than the fist with the PWO, the bug won't appear. In any case, the pistol is always brought up first offline regardless of the settings. It turns out that it has actually been broken ever since 1.0, as setting switchonpickup to 0 brings up the fist there as well. It's a regression since it works fine in Skulltag 98d. I think it got broken when we worked on the weapon sync issues way back. |
|
|
|
(0023378)
|
|
Ru5tK1ng
|
2024-03-12 20:32
(edited on: 2024-03-13 04:40) |
|
'https://foss.heptapod.net/zandronum/zandronum-stable/-/blob/branch/default/src/p_interaction.cpp#L2355 [^]'
Here's the difference. In single player this block is executed fully which results in no issue with the weapon pickup regardless of PWO settings.
However for clients it's different. Because bUnarmed is never true on the clients, they have to wait for the server to send out the inventory which causes them to follow the same code trace as SP. When the server sends a command to reset the inventory followed by syncing the ammo, this is where it sort of falls apart if you don't have the 'right' PWO setting.
|
|
|
|
|
|
|
|
|
Hey, it seems that it still selects the fist if switchonpickup is 3 (PWO), and the fist and pistol preference have the same value. Offline, it selects the pistol as expected.
It fixed the issue for switchonpickup 0 though. |
|
|
|
|
It doesn't seem there is a good way to fix this. Offline is no issue because SP isn't a client and isn't subject to the item syncing.
The problem is that the items are given one at a time to the client. To simulate this, do 'take all' then give yourself the fist then pistol and then do the reverse. You'll notice that different PWO settings will switch to the fist. |
|
|
|
|
|
|
|
|
|
yeah, that seems to have fixed it. It now always selects the pistol as expected. Thanks! |
|
|
|
|
|
|
|
|
|
|
|
|
|
Since this was tested by Unknownna previously, marking as resolved. |
|