Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002717Zandronum[All Projects] Bugpublic2016-04-30 20:272018-09-30 21:49
ReporterS_Andrew_S 
Assigned ToEdward-san 
PriorityhighSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0002717: Crash appears to occur from a limit of player classes (21) and weapons
DescriptionI've been trying to get Samsara Extra Heroes to work on Zandronum 3.0 from 2-29, and it works for the most part, except for the fact that I noticed a flaw - there is some player class limit. This mod works in Zandronum 2.1.2 but not on Zandronum 3.0, and I've took apart many things to find the root of the issue. I was eventually able to trace the cause of the crash from player classes to be here:

Player.DisplayName "Leonard"

By commenting this line, it would work, but if it isn't commented it will crash right on start up. I added nomenu to the line in the keyconf that adds the player class but that didn't make any difference at all.
Steps To ReproduceJust load up the file and it will crash in these conditions:
1. It appears Zandronum will crash if there is more than 21 player classes. If you open this decorate file, and simply uncomment all of Leonard's stuff (specifically his weapons, unique, and player definition), and load up the file, you will get the crash.
2. If you now comment all of the Disruptor stuff, and run zandronum with the file, you will not get a crash.
3. Now comment all of leonard's stuff and uncomment the disruptor stuff. Now you will see what I mean if you load it up.

As for weapons:
1. Having one more slot number for a weapon uncommented will result in a crash.
2. Comment Grondovals slot 4, and then uncomment his slot 5, if you load it up, it should not crash. Then comment his slot 5 and uncomment his slot 4.
Additional InformationThe crash message shows something about unable to alloc some large number of bytes. This issue apparently does not happen to someone with a crappy laptop. I have 8gb ddr3 ram, Intel Core 2 Quad Q6600, Nvidia GTX 750 Ti, Windows 7 SP1. Also, not all classes are in this txt file. I shall also not share the actual pk3.

The mod is here:

'http://www.best-ever.org/download?file=samsara_ex-ha1.pk3 [^]'
Attached Filestxt file icon DECORATE.txt [^] (9,149 bytes) 2016-04-30 20:32 [Show Content]

- Relationships

-  Notes
User avatar (0014777)
S_Andrew_S (reporter)
2016-04-30 20:28
edited on: 2016-04-30 22:08

 Forgot to mention: You will need the 0.31 beta of samsara in order to actually test this - you will also have to comment: #include "decorate/Game_Strife/allies2.dec".

EDIT: Hunter's Moon doesn't have this problem. I don't know why its an issue here. Maybe this is a player pawn issue?
User avatar (0014779)
Edward-san (developer)
2016-04-30 23:14
edited on: 2016-04-30 23:15

 If you manage to make the mod runnable on gzdoom r900 ( the code base of zandronum 2.x ) and gzdoom 1.8.6 ( the code base of zandronum 3.0 ), can you check if the crash happens also in gzdoom 1.8.6?
User avatar (0014780)
S_Andrew_S (reporter)
2016-04-30 23:27
edited on: 2016-04-30 23:35

 I just got them to work with GZDoom 1.8.6 - 100% Zandronum crash. Also, here is the stuff that makes it work with GZDoom 1.8.6 (removed the SBARINFO to make it work, loading these up with 3.0 will still make it crash, but not GZDoom).

'https://drive.google.com/file/d/0B2yXvgBSVGEMeTBzbk9xZTdOY1k/view?usp=sharing [^]'
User avatar (0014785)
Edward-san (developer)
2016-05-01 14:03

 The crash is caused by the rewritten PWO code.
User avatar (0014792)
S_Andrew_S (reporter)
2016-05-02 00:46
edited on: 2016-05-02 00:47

 So, can this be fixed easily? I've been porting other stuff to GZDoom that I'm working on so I can take advantage of Zandronum 3.0's new features when the time comes. I could actually report a few more crashes but its rather impossible for me to know if they are fixed in 3.0 until this crash is fixed. Or is there a possible work-around?
User avatar (0014796)
Edward-san (developer)
2016-05-02 09:26

 Please don't bump it, it requires some time to fix it. Also, no workaround is available at the moment.
User avatar (0014972)
Edward-san (developer)
2016-05-23 09:59

 Should be fixed by this changeset:'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/102/fixed-a-crash-caused-by-the-pwo-rewrite/diff [^]' . Can someone check if PWO still works?
User avatar (0015005)
WaTaKiD (updater)
2016-06-03 01:07

 this 3.0 build contains the above commit:'https://www.dropbox.com/s/7u5uknt1m8ignrw/zandronum-3.0-r160523-0955-30a6eaa-windows.zip?dl=0 [^]'
User avatar (0015062)
S_Andrew_S (reporter)
2016-06-10 07:49

 The build with the changes in the post above fixes the issue, thanks!
User avatar (0015071)
Edward-san (developer)
2016-06-11 09:14

 I still need to know if PWO still works.
User avatar (0015074)
Edward-san (developer)
2016-06-12 12:22

 Added the fix to zandronum 3.0 upstream with this changeset:'https://bitbucket.org/Torr_Samaho/zandronum/commits/f3d671b87982 [^]'
User avatar (0015115)
S_Andrew_S (reporter)
2016-06-26 04:51

 This particular (I think just this one) 3.0 build runs slow. Problem is, TSPG is about to use the PWO fix for the 3.0 build. But then again, 4.0 runs really quick and does not have this problem.
User avatar (0015140)
EnsaladaDeTomate (reporter)
2016-06-27 02:35

 I can confirm that im getting; along with more people, performance issues with the fixed 3.0 PWO build.
User avatar (0015195)
WaTaKiD (updater)
2016-07-02 19:31

 can some specifics be provided regarding how to reproduce the performance issues?

ive tried running around doom2 map01, turning pwo on and off, and using the 2 samsara wads linked here:'http://zandronum.com/tracker/view.php?id=2717#c14780 [^]'

so far ive not run into any performance issues, so please give any info u can, for example if it happens offline but not online, software but not opengl, what pwo settings do u have, etc
User avatar (0015350)
S_Andrew_S (reporter)
2016-07-17 00:54

 Well, the easiest example I can provide is simply turning a corner with monsters on the other tends to create a short lag spike for about a split second instead of running smooth. I'm not totally sure if it's just this 3.0 build but I don't recall having the same lag spike with the other builds.
User avatar (0015480)
Edward-san (developer)
2016-08-18 09:35

 Can you check if the slowdown happens with latest 3.0 beta?
User avatar (0015621)
EnsaladaDeTomate (reporter)
2016-09-11 21:30
edited on: 2016-09-11 21:31

 No more slow downs so far, and the crash is gone, so this can be marked as resolved.
User avatar (0015622)
Edward-san (developer)
2016-09-11 22:19
edited on: 2016-09-11 22:20

 So, it was Watakid's build which was slow, uh. Thanks for checking!

I'll keep it open just in case. I still need some feedback from PWO users in general.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: EnsaladaDeTomate
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2016-04-30 20:27 S_Andrew_S New Issue
2016-04-30 20:28 S_Andrew_S Note Added: 0014777
2016-04-30 20:31 S_Andrew_S Note Edited: 0014777 View Revisions
2016-04-30 20:32 S_Andrew_S File Added: DECORATE.txt
2016-04-30 22:06 S_Andrew_S Note Edited: 0014777 View Revisions
2016-04-30 22:08 S_Andrew_S Note Edited: 0014777 View Revisions
2016-04-30 23:14 Edward-san Note Added: 0014779
2016-04-30 23:15 Edward-san Status new => feedback
2016-04-30 23:15 Edward-san Note Edited: 0014779 View Revisions
2016-04-30 23:27 S_Andrew_S Note Added: 0014780
2016-04-30 23:27 S_Andrew_S Status feedback => new
2016-04-30 23:35 S_Andrew_S Note Edited: 0014780 View Revisions
2016-05-01 14:03 Edward-san Note Added: 0014785
2016-05-01 14:03 Edward-san Status new => confirmed
2016-05-02 00:46 S_Andrew_S Note Added: 0014792
2016-05-02 00:47 S_Andrew_S Note Edited: 0014792 View Revisions
2016-05-02 09:26 Edward-san Note Added: 0014796
2016-05-23 09:55 Edward-san Assigned To => Edward-san
2016-05-23 09:55 Edward-san Status confirmed => assigned
2016-05-23 09:59 Edward-san Note Added: 0014972
2016-05-23 09:59 Edward-san Status assigned => feedback
2016-06-03 01:07 WaTaKiD Note Added: 0015005
2016-06-10 07:49 S_Andrew_S Note Added: 0015062
2016-06-10 07:49 S_Andrew_S Status feedback => assigned
2016-06-11 09:14 Edward-san Note Added: 0015071
2016-06-11 09:14 Edward-san Status assigned => feedback
2016-06-12 12:22 Edward-san Note Added: 0015074
2016-06-12 12:22 Edward-san Status feedback => needs testing
2016-06-26 04:51 S_Andrew_S Note Added: 0015115
2016-06-27 02:35 EnsaladaDeTomate Note Added: 0015140
2016-07-02 19:31 WaTaKiD Note Added: 0015195
2016-07-17 00:54 S_Andrew_S Note Added: 0015350
2016-08-18 09:35 Edward-san Note Added: 0015480
2016-09-11 21:30 EnsaladaDeTomate Note Added: 0015621
2016-09-11 21:31 EnsaladaDeTomate Note Edited: 0015621 View Revisions
2016-09-11 22:19 Edward-san Note Added: 0015622
2016-09-11 22:20 Edward-san Note Edited: 0015622 View Revisions
2016-12-24 22:42 Dusk Target Version => 3.0
2017-02-06 19:08 Dusk Status needs testing => resolved
2017-02-06 19:08 Dusk Fixed in Version => 3.0
2017-02-06 19:08 Dusk Resolution open => fixed
2018-09-30 21:49 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker