MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002717Zandronum[All Projects] Bugpublic2016-04-30 20:272018-09-30 21:49
ReporterS_Andrew_S 
Assigned ToEdward-san 
PriorityhighSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0002717: Crash appears to occur from a limit of player classes (21) and weapons
DescriptionI've been trying to get Samsara Extra Heroes to work on Zandronum 3.0 from 2-29, and it works for the most part, except for the fact that I noticed a flaw - there is some player class limit. This mod works in Zandronum 2.1.2 but not on Zandronum 3.0, and I've took apart many things to find the root of the issue. I was eventually able to trace the cause of the crash from player classes to be here:

Player.DisplayName "Leonard"

By commenting this line, it would work, but if it isn't commented it will crash right on start up. I added nomenu to the line in the keyconf that adds the player class but that didn't make any difference at all.
Steps To ReproduceJust load up the file and it will crash in these conditions:
1. It appears Zandronum will crash if there is more than 21 player classes. If you open this decorate file, and simply uncomment all of Leonard's stuff (specifically his weapons, unique, and player definition), and load up the file, you will get the crash.
2. If you now comment all of the Disruptor stuff, and run zandronum with the file, you will not get a crash.
3. Now comment all of leonard's stuff and uncomment the disruptor stuff. Now you will see what I mean if you load it up.

As for weapons:
1. Having one more slot number for a weapon uncommented will result in a crash.
2. Comment Grondovals slot 4, and then uncomment his slot 5, if you load it up, it should not crash. Then comment his slot 5 and uncomment his slot 4.
Additional InformationThe crash message shows something about unable to alloc some large number of bytes. This issue apparently does not happen to someone with a crappy laptop. I have 8gb ddr3 ram, Intel Core 2 Quad Q6600, Nvidia GTX 750 Ti, Windows 7 SP1. Also, not all classes are in this txt file. I shall also not share the actual pk3.

The mod is here:

'http://www.best-ever.org/download?file=samsara_ex-ha1.pk3 [^]'
TagsNo tags attached.
Relationships
Attached Filestxt DECORATE.txt (9,149) 2016-04-30 20:32
/tracker/file_download.php?file_id=1800&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-04-30 20:27S_Andrew_SNew Issue
2016-04-30 20:28S_Andrew_SNote Added: 0014777
2016-04-30 20:31S_Andrew_SNote Edited: 0014777bug_revision_view_page.php?bugnote_id=14777#r8950
2016-04-30 20:32S_Andrew_SFile Added: DECORATE.txt
2016-04-30 22:06S_Andrew_SNote Edited: 0014777bug_revision_view_page.php?bugnote_id=14777#r8951
2016-04-30 22:08S_Andrew_SNote Edited: 0014777bug_revision_view_page.php?bugnote_id=14777#r8952
2016-04-30 23:14Edward-sanNote Added: 0014779
2016-04-30 23:15Edward-sanStatusnew => feedback
2016-04-30 23:15Edward-sanNote Edited: 0014779bug_revision_view_page.php?bugnote_id=14779#r8954
2016-04-30 23:27S_Andrew_SNote Added: 0014780
2016-04-30 23:27S_Andrew_SStatusfeedback => new
2016-04-30 23:35S_Andrew_SNote Edited: 0014780bug_revision_view_page.php?bugnote_id=14780#r8956
2016-05-01 14:03Edward-sanNote Added: 0014785
2016-05-01 14:03Edward-sanStatusnew => confirmed
2016-05-02 00:46S_Andrew_SNote Added: 0014792
2016-05-02 00:47S_Andrew_SNote Edited: 0014792bug_revision_view_page.php?bugnote_id=14792#r8958
2016-05-02 09:26Edward-sanNote Added: 0014796
2016-05-23 09:55Edward-sanAssigned To => Edward-san
2016-05-23 09:55Edward-sanStatusconfirmed => assigned
2016-05-23 09:59Edward-sanNote Added: 0014972
2016-05-23 09:59Edward-sanStatusassigned => feedback
2016-06-03 01:07WaTaKiDNote Added: 0015005
2016-06-10 07:49S_Andrew_SNote Added: 0015062
2016-06-10 07:49S_Andrew_SStatusfeedback => assigned
2016-06-11 09:14Edward-sanNote Added: 0015071
2016-06-11 09:14Edward-sanStatusassigned => feedback
2016-06-12 12:22Edward-sanNote Added: 0015074
2016-06-12 12:22Edward-sanStatusfeedback => needs testing
2016-06-26 04:51S_Andrew_SNote Added: 0015115
2016-06-27 02:35EnsaladaDeTomateNote Added: 0015140
2016-07-02 19:31WaTaKiDNote Added: 0015195
2016-07-17 00:54S_Andrew_SNote Added: 0015350
2016-08-18 09:35Edward-sanNote Added: 0015480
2016-09-11 21:30EnsaladaDeTomateNote Added: 0015621
2016-09-11 21:31EnsaladaDeTomateNote Edited: 0015621bug_revision_view_page.php?bugnote_id=15621#r9491
2016-09-11 22:19Edward-sanNote Added: 0015622
2016-09-11 22:20Edward-sanNote Edited: 0015622bug_revision_view_page.php?bugnote_id=15622#r9493
2016-12-24 22:42DuskTarget Version => 3.0
2017-02-06 19:08DuskStatusneeds testing => resolved
2017-02-06 19:08DuskFixed in Version => 3.0
2017-02-06 19:08DuskResolutionopen => fixed
2018-09-30 21:49Blzut3Statusresolved => closed

Notes
(0014777)
S_Andrew_S   
2016-04-30 20:28   
(edited on: 2016-04-30 22:08)
Forgot to mention: You will need the 0.31 beta of samsara in order to actually test this - you will also have to comment: #include "decorate/Game_Strife/allies2.dec".

EDIT: Hunter's Moon doesn't have this problem. I don't know why its an issue here. Maybe this is a player pawn issue?
(0014779)
Edward-san   
2016-04-30 23:14   
(edited on: 2016-04-30 23:15)
If you manage to make the mod runnable on gzdoom r900 ( the code base of zandronum 2.x ) and gzdoom 1.8.6 ( the code base of zandronum 3.0 ), can you check if the crash happens also in gzdoom 1.8.6?
(0014780)
S_Andrew_S   
2016-04-30 23:27   
(edited on: 2016-04-30 23:35)
I just got them to work with GZDoom 1.8.6 - 100% Zandronum crash. Also, here is the stuff that makes it work with GZDoom 1.8.6 (removed the SBARINFO to make it work, loading these up with 3.0 will still make it crash, but not GZDoom).

'https://drive.google.com/file/d/0B2yXvgBSVGEMeTBzbk9xZTdOY1k/view?usp=sharing [^]'
(0014785)
Edward-san   
2016-05-01 14:03   
The crash is caused by the rewritten PWO code.
(0014792)
S_Andrew_S   
2016-05-02 00:46   
(edited on: 2016-05-02 00:47)
So, can this be fixed easily? I've been porting other stuff to GZDoom that I'm working on so I can take advantage of Zandronum 3.0's new features when the time comes. I could actually report a few more crashes but its rather impossible for me to know if they are fixed in 3.0 until this crash is fixed. Or is there a possible work-around?
(0014796)
Edward-san   
2016-05-02 09:26   
Please don't bump it, it requires some time to fix it. Also, no workaround is available at the moment.
(0014972)
Edward-san   
2016-05-23 09:59   
Should be fixed by this changeset:'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/102/fixed-a-crash-caused-by-the-pwo-rewrite/diff [^]' . Can someone check if PWO still works?
(0015005)
WaTaKiD   
2016-06-03 01:07   
this 3.0 build contains the above commit:'https://www.dropbox.com/s/7u5uknt1m8ignrw/zandronum-3.0-r160523-0955-30a6eaa-windows.zip?dl=0 [^]'
(0015062)
S_Andrew_S   
2016-06-10 07:49   
The build with the changes in the post above fixes the issue, thanks!
(0015071)
Edward-san   
2016-06-11 09:14   
I still need to know if PWO still works.
(0015074)
Edward-san   
2016-06-12 12:22   
Added the fix to zandronum 3.0 upstream with this changeset:'https://bitbucket.org/Torr_Samaho/zandronum/commits/f3d671b87982 [^]'
(0015115)
S_Andrew_S   
2016-06-26 04:51   
This particular (I think just this one) 3.0 build runs slow. Problem is, TSPG is about to use the PWO fix for the 3.0 build. But then again, 4.0 runs really quick and does not have this problem.
(0015140)
EnsaladaDeTomate   
2016-06-27 02:35   
I can confirm that im getting; along with more people, performance issues with the fixed 3.0 PWO build.
(0015195)
WaTaKiD   
2016-07-02 19:31   
can some specifics be provided regarding how to reproduce the performance issues?

ive tried running around doom2 map01, turning pwo on and off, and using the 2 samsara wads linked here:'http://zandronum.com/tracker/view.php?id=2717#c14780 [^]'

so far ive not run into any performance issues, so please give any info u can, for example if it happens offline but not online, software but not opengl, what pwo settings do u have, etc
(0015350)
S_Andrew_S   
2016-07-17 00:54   
Well, the easiest example I can provide is simply turning a corner with monsters on the other tends to create a short lag spike for about a split second instead of running smooth. I'm not totally sure if it's just this 3.0 build but I don't recall having the same lag spike with the other builds.
(0015480)
Edward-san   
2016-08-18 09:35   
Can you check if the slowdown happens with latest 3.0 beta?
(0015621)
EnsaladaDeTomate   
2016-09-11 21:30   
(edited on: 2016-09-11 21:31)
No more slow downs so far, and the crash is gone, so this can be marked as resolved.
(0015622)
Edward-san   
2016-09-11 22:19   
(edited on: 2016-09-11 22:20)
So, it was Watakid's build which was slow, uh. Thanks for checking!

I'll keep it open just in case. I still need some feedback from PWO users in general.