Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002706Zandronum[All Projects] Bugpublic2016-04-23 00:092024-10-26 02:22
ReporterMarcus101RR 
Assigned ToKaminsky 
PriorityhighSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version2.1 
Target Version3.2Fixed in Version3.2 
Summary0002706: [2.1.2] MaxHealth/MaxArmor resets to 150 after Next Map Online
DescriptionWhen attempting to create Custom MaxHealth / MaxArmor Bonus types for Wad Projects, the inherited value of 150 is capsized thus every map change you will have a maximum of 150 Armor and Health rather than more. If you use a custom item that increases max capacity beyond 150 it will work for the current map, but, when moving to next map it will change to 150 and continue from there.
Steps To ReproduceCreate Wad/PK3 with the code below and use it to get more than 150 max armor or health. When changing the map or moving to the next map on coop it resets to 150 unless you are below 150.
Additional InformationACTOR CustomMaxHealth : MaxHealth
{
    Game Doom
    Game Heretic
    Game Hexen
    +COUNTITEM
    +INVENTORY.ALWAYSPICKUP
    Inventory.Amount 1
    Inventory.MaxAmount 100
    Health 200
    Inventory.PickupMessage "Picked up a Max Health Bonus."
    States
    {
    Spawn:
        BON3 ABCDCB 6
        Loop
    }
}

ACTOR CustomMaxArmor : BasicArmorBonus
{
    Game Doom
    Game Heretic
    Game Hexen
    Radius 20
    Height 16
    Inventory.Pickupmessage "Picked up a Max Armor Bonus."
    Inventory.Icon "ARM1A0"
    Armor.SavePercent 33.33333
    Armor.Saveamount 1
    Armor.MaxSaveAmount 200
    Armor.MaxBonus 1
    Armor.MaxBonusMax 100
    +COUNTITEM
    +INVENTORY.ALWAYSPICKUP
    States
    {
    Spawn:
        BON4 ABCDCB 6
        loop
    }
}
Attached Filespng file icon zKSLFrU.png [^] (451,966 bytes) 2016-04-23 00:09
png file icon Screenshot_Doom_20240310_124754.png [^] (125,185 bytes) 2024-03-10 11:59


? file icon armorhealth_max_01.wad [^] (1,716 bytes) 2024-03-10 11:59

- Relationships

-  Notes
User avatar (0023322)
Ru5tK1ng (updater)
2024-03-09 22:41

 Unable to reproduce with with 3.1 either offline or online. Marking this as resolved. Feel free to reopen if you still encounter this bug in some way.
User avatar (0023331)
unknownna (updater)
2024-03-10 11:58

 He means Inventory.MaxAmount and Armor.MaxBonusMax revert to a max of 150 after map changes and for incoming clients. I can confirm this is still the case. See the attached screenshot and try it with the example wad. It's an ancient Skulltag issue.
User avatar (0023389)
Ru5tK1ng (updater)
2024-03-13 22:14

 Edited ticket to clarify that the bug is online only.
User avatar (0023390)
Ru5tK1ng (updater)
2024-03-14 04:48

 Can you try this build and see if it's resolved?

'https://www.mediafire.com/file/guylwqe0jdczhxt/zandronum_3.2_r240311-0546M4.zip/file [^]'
User avatar (0023393)
unknownna (updater)
2024-03-14 06:13

 Yeah, that seems to have taken care of it. Nice to finally have it fixed after all these years, good job!
User avatar (0023394)
Ru5tK1ng (updater)
2024-03-14 07:52

 Thanks for testing. Merge request created:

'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/56 [^]'
User avatar (0023659)
Ru5tK1ng (updater)
2024-05-06 02:30

 This was merged in:'https://foss.heptapod.net/zandronum/zandronum-stable/-/commit/24ef44992e9848ef3e923917fae743ae0a824795 [^]'
User avatar (0023735)
unknownna (updater)
2024-05-30 17:33

 Hey, testing the example wad with the build supplied to me by Kaminsky, the fix breaks after changemap map changes.

The client will assume wrong health and armor values, and other players spying on you through coop info and coop spy will see wrong values and max values as well.

If you pick up the health and armor until you get, which is the max amounts offline:

Armor 300 / 200
Health 400 / 300

and then pick it up again after that before the map change, it will sometimes change it to:

Armor 400 / 300
Health 600 / 300

after the map change. The actual amounts in addition to the max amounts desync.
User avatar (0024083)
Kaminsky (developer)
2024-10-24 15:09

 This should fix the regression:'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/217 [^]'

If you can confirm that it resolves the issue, that would be great.
User avatar (0024094)
unknownna (updater)
2024-10-26 02:22

 It seems to have finally fixed the issue. Thanks to both of you for taking care of this ancient bug, much appreciated. Great work!

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: Marcus101RR Combinebobnt unknownna
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2016-04-23 00:09 Marcus101RR New Issue
2016-04-23 00:09 Marcus101RR File Added: zKSLFrU.png
2024-03-09 22:41 Ru5tK1ng Note Added: 0023322
2024-03-09 22:41 Ru5tK1ng Status new => resolved
2024-03-09 22:41 Ru5tK1ng Resolution open => fixed
2024-03-09 22:41 Ru5tK1ng Fixed in Version => 3.1
2024-03-09 22:41 Ru5tK1ng Target Version => 3.1
2024-03-09 22:41 Ru5tK1ng Additional Information Updated View Revisions
2024-03-10 11:58 unknownna Note Added: 0023331
2024-03-10 11:58 unknownna Status resolved => feedback
2024-03-10 11:58 unknownna Resolution fixed => reopened
2024-03-10 11:59 unknownna File Added: Screenshot_Doom_20240310_124754.png
2024-03-10 11:59 unknownna File Added: armorhealth_max_01.wad
2024-03-10 12:02 unknownna Status feedback => confirmed
2024-03-13 22:14 Ru5tK1ng Note Added: 0023389
2024-03-13 22:14 Ru5tK1ng Summary [2.1.2] MaxHealth/MaxArmor resets to 150 after Next Map => [2.1.2] MaxHealth/MaxArmor resets to 150 after Next Map Online
2024-03-14 04:48 Ru5tK1ng Note Added: 0023390
2024-03-14 04:48 Ru5tK1ng Assigned To => Ru5tK1ng
2024-03-14 04:48 Ru5tK1ng Status confirmed => feedback
2024-03-14 04:48 Ru5tK1ng Fixed in Version 3.1 =>
2024-03-14 04:48 Ru5tK1ng Target Version 3.1 => 3.2
2024-03-14 06:13 unknownna Note Added: 0023393
2024-03-14 07:52 Ru5tK1ng Note Added: 0023394
2024-03-14 07:52 Ru5tK1ng Assigned To Ru5tK1ng =>
2024-03-14 07:52 Ru5tK1ng Status feedback => needs review
2024-05-06 02:30 Ru5tK1ng Note Added: 0023659
2024-05-06 02:30 Ru5tK1ng Status needs review => needs testing
2024-05-30 17:33 unknownna Note Added: 0023735
2024-05-30 17:33 unknownna Status needs testing => feedback
2024-10-24 15:09 Kaminsky Note Added: 0024083
2024-10-24 15:09 Kaminsky Status feedback => needs review
2024-10-26 02:22 unknownna Note Added: 0024094
2024-10-26 02:22 unknownna Status needs review => resolved
2024-10-26 02:22 unknownna Fixed in Version => 3.2
2024-10-26 02:22 unknownna Resolution reopened => fixed
2024-10-26 02:22 unknownna Assigned To => Kaminsky




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker