MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002706Zandronum[All Projects] Bugpublic2016-04-23 00:092024-10-26 02:22
ReporterMarcus101RR 
Assigned ToKaminsky 
PriorityhighSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version2.1 
Target Version3.2Fixed in Version3.2 
Summary0002706: [2.1.2] MaxHealth/MaxArmor resets to 150 after Next Map Online
DescriptionWhen attempting to create Custom MaxHealth / MaxArmor Bonus types for Wad Projects, the inherited value of 150 is capsized thus every map change you will have a maximum of 150 Armor and Health rather than more. If you use a custom item that increases max capacity beyond 150 it will work for the current map, but, when moving to next map it will change to 150 and continue from there.
Steps To ReproduceCreate Wad/PK3 with the code below and use it to get more than 150 max armor or health. When changing the map or moving to the next map on coop it resets to 150 unless you are below 150.
Additional InformationACTOR CustomMaxHealth : MaxHealth
{
    Game Doom
    Game Heretic
    Game Hexen
    +COUNTITEM
    +INVENTORY.ALWAYSPICKUP
    Inventory.Amount 1
    Inventory.MaxAmount 100
    Health 200
    Inventory.PickupMessage "Picked up a Max Health Bonus."
    States
    {
    Spawn:
        BON3 ABCDCB 6
        Loop
    }
}

ACTOR CustomMaxArmor : BasicArmorBonus
{
    Game Doom
    Game Heretic
    Game Hexen
    Radius 20
    Height 16
    Inventory.Pickupmessage "Picked up a Max Armor Bonus."
    Inventory.Icon "ARM1A0"
    Armor.SavePercent 33.33333
    Armor.Saveamount 1
    Armor.MaxSaveAmount 200
    Armor.MaxBonus 1
    Armor.MaxBonusMax 100
    +COUNTITEM
    +INVENTORY.ALWAYSPICKUP
    States
    {
    Spawn:
        BON4 ABCDCB 6
        loop
    }
}
TagsNo tags attached.
Relationships
Attached Filespng zKSLFrU.png (451,966) 2016-04-23 00:09
/tracker/file_download.php?file_id=1790&type=bug
png Screenshot_Doom_20240310_124754.png (125,185) 2024-03-10 11:59
/tracker/file_download.php?file_id=2931&type=bug
png

? armorhealth_max_01.wad (1,716) 2024-03-10 11:59
/tracker/file_download.php?file_id=2932&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-04-23 00:09Marcus101RRNew Issue
2016-04-23 00:09Marcus101RRFile Added: zKSLFrU.png
2024-03-09 22:41Ru5tK1ngNote Added: 0023322
2024-03-09 22:41Ru5tK1ngStatusnew => resolved
2024-03-09 22:41Ru5tK1ngResolutionopen => fixed
2024-03-09 22:41Ru5tK1ngFixed in Version => 3.1
2024-03-09 22:41Ru5tK1ngTarget Version => 3.1
2024-03-09 22:41Ru5tK1ngAdditional Information Updatedbug_revision_view_page.php?rev_id=14116#r14116
2024-03-10 11:58unknownnaNote Added: 0023331
2024-03-10 11:58unknownnaStatusresolved => feedback
2024-03-10 11:58unknownnaResolutionfixed => reopened
2024-03-10 11:59unknownnaFile Added: Screenshot_Doom_20240310_124754.png
2024-03-10 11:59unknownnaFile Added: armorhealth_max_01.wad
2024-03-10 12:02unknownnaStatusfeedback => confirmed
2024-03-13 22:14Ru5tK1ngNote Added: 0023389
2024-03-13 22:14Ru5tK1ngSummary[2.1.2] MaxHealth/MaxArmor resets to 150 after Next Map => [2.1.2] MaxHealth/MaxArmor resets to 150 after Next Map Online
2024-03-14 04:48Ru5tK1ngNote Added: 0023390
2024-03-14 04:48Ru5tK1ngAssigned To => Ru5tK1ng
2024-03-14 04:48Ru5tK1ngStatusconfirmed => feedback
2024-03-14 04:48Ru5tK1ngFixed in Version3.1 =>
2024-03-14 04:48Ru5tK1ngTarget Version3.1 => 3.2
2024-03-14 06:13unknownnaNote Added: 0023393
2024-03-14 07:52Ru5tK1ngNote Added: 0023394
2024-03-14 07:52Ru5tK1ngAssigned ToRu5tK1ng =>
2024-03-14 07:52Ru5tK1ngStatusfeedback => needs review
2024-05-06 02:30Ru5tK1ngNote Added: 0023659
2024-05-06 02:30Ru5tK1ngStatusneeds review => needs testing
2024-05-30 17:33unknownnaNote Added: 0023735
2024-05-30 17:33unknownnaStatusneeds testing => feedback
2024-10-24 15:09KaminskyNote Added: 0024083
2024-10-24 15:09KaminskyStatusfeedback => needs review
2024-10-26 02:22unknownnaNote Added: 0024094
2024-10-26 02:22unknownnaStatusneeds review => resolved
2024-10-26 02:22unknownnaFixed in Version => 3.2
2024-10-26 02:22unknownnaResolutionreopened => fixed
2024-10-26 02:22unknownnaAssigned To => Kaminsky

Notes
(0023322)
Ru5tK1ng   
2024-03-09 22:41   
Unable to reproduce with with 3.1 either offline or online. Marking this as resolved. Feel free to reopen if you still encounter this bug in some way.
(0023331)
unknownna   
2024-03-10 11:58   
He means Inventory.MaxAmount and Armor.MaxBonusMax revert to a max of 150 after map changes and for incoming clients. I can confirm this is still the case. See the attached screenshot and try it with the example wad. It's an ancient Skulltag issue.
(0023389)
Ru5tK1ng   
2024-03-13 22:14   
Edited ticket to clarify that the bug is online only.
(0023390)
Ru5tK1ng   
2024-03-14 04:48   
Can you try this build and see if it's resolved?

'https://www.mediafire.com/file/guylwqe0jdczhxt/zandronum_3.2_r240311-0546M4.zip/file [^]'
(0023393)
unknownna   
2024-03-14 06:13   
Yeah, that seems to have taken care of it. Nice to finally have it fixed after all these years, good job!
(0023394)
Ru5tK1ng   
2024-03-14 07:52   
Thanks for testing. Merge request created:

'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/56 [^]'
(0023659)
Ru5tK1ng   
2024-05-06 02:30   
This was merged in:'https://foss.heptapod.net/zandronum/zandronum-stable/-/commit/24ef44992e9848ef3e923917fae743ae0a824795 [^]'
(0023735)
unknownna   
2024-05-30 17:33   
Hey, testing the example wad with the build supplied to me by Kaminsky, the fix breaks after changemap map changes.

The client will assume wrong health and armor values, and other players spying on you through coop info and coop spy will see wrong values and max values as well.

If you pick up the health and armor until you get, which is the max amounts offline:

Armor 300 / 200
Health 400 / 300

and then pick it up again after that before the map change, it will sometimes change it to:

Armor 400 / 300
Health 600 / 300

after the map change. The actual amounts in addition to the max amounts desync.
(0024083)
Kaminsky   
2024-10-24 15:09   
This should fix the regression:'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/217 [^]'

If you can confirm that it resolves the issue, that would be great.
(0024094)
unknownna   
2024-10-26 02:22   
It seems to have finally fixed the issue. Thanks to both of you for taking care of this ancient bug, much appreciated. Great work!