Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002632Zandronum[All Projects] Bugpublic2016-02-12 01:512018-09-30 22:10
ReporterMarcaek 
Assigned ToDusk 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSWindowsOS Version8.1
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0002632: MAPINFO error in Zan 3.0 but not 2.1.2 or ZDoom
DescriptionSome WADs may become unhostable in 3.0 due to this MAPINFO bug
Steps To ReproduceAttempt to start a server using the linked WAD in 2.1.2, 3.0 and ZDoom. Only 3.0 should crash.
Attached Files? file icon brokenmapinfo.wad [^] (1,730 bytes) 2016-02-12 01:51

- Relationships

-  Notes
User avatar (0014425)
Marcaek (reporter)
2016-02-12 02:04

 'http://painkiller.allfearthesentinel.net/download?file=brokenmapinfo.wad [^]'

'http://painkiller.allfearthesentinel.net/download?file=brokenmapinfofix.wad [^]'

Removed double map01 definiton (which wasn't the cause) and provided a fix WAD. Apparently the brackets after Endgame should not be there, yet this causes no problems in ZDoom 2.7.1
User avatar (0014440)
Torr Samaho (administrator)
2016-02-14 15:53

 Strangely, this only affects the server. The Zandronum client is not affected. Needs to be investigated.

BTW: This is not a crash. The server detects the script error, prints a proper error message and exits gracefully.
User avatar (0014464)
Dusk (developer)
2016-02-20 10:48

 Fixed:'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/69 [^]'

However, this revealed a bigger problem. We don't have any proper handling for the new endgame types. For instance, E3M8 uses "endbunny" as the next map (which I guess is easy enough to loop back to E1M1), but there are generalized intermission definitions out there now. What do we do when the server encounters this? We need to find a way to get the first map and loop back to that.
User avatar (0014465)
cobalt (updater)
2016-02-20 11:39

 Issue addressed by commit d040179df2b8: Fixed: the server did not parse MAPINFO endgame sections correctly, fixes 2632
Committed by Teemu Piippo [Dusk] on Wednesday 31 December 1969 23:59:57

Changes in files:

 src/g_mapinfo.cpp | 25 +++++++++++--------------
 src/intermission/intermission_parse.cpp | 10 +++++++++-
 2 files changed, 20 insertions(+), 15 deletions(-)
User avatar (0014524)
Ru5tK1ng (updater)
2016-03-01 21:27

 I ran the test wad with the latest build and I did not come across any type of crash.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2016-02-12 01:51 Marcaek New Issue
2016-02-12 01:51 Marcaek File Added: brokenmapinfo.wad
2016-02-12 02:04 Marcaek Note Added: 0014425
2016-02-14 15:53 Torr Samaho Note Added: 0014440
2016-02-20 10:08 Dusk Assigned To => Dusk
2016-02-20 10:08 Dusk Status new => assigned
2016-02-20 10:48 Dusk Note Added: 0014464
2016-02-20 10:48 Dusk Status assigned => needs review
2016-02-20 11:39 cobalt Status needs review => needs testing
2016-02-20 11:39 cobalt Target Version => 3.0
2016-02-20 11:39 cobalt Note Added: 0014465
2016-03-01 21:27 Ru5tK1ng Note Added: 0014524
2016-03-01 21:27 Ru5tK1ng Status needs testing => resolved
2016-03-01 21:27 Ru5tK1ng Resolution open => fixed
2016-03-01 21:27 Ru5tK1ng Fixed in Version => 3.0
2018-09-30 22:10 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker