MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002632Zandronum[All Projects] Bugpublic2016-02-12 01:512018-09-30 22:10
ReporterMarcaek 
Assigned ToDusk 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSWindowsOS Version8.1
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0002632: MAPINFO error in Zan 3.0 but not 2.1.2 or ZDoom
DescriptionSome WADs may become unhostable in 3.0 due to this MAPINFO bug
Steps To ReproduceAttempt to start a server using the linked WAD in 2.1.2, 3.0 and ZDoom. Only 3.0 should crash.
Additional Information
TagsNo tags attached.
Relationships
Attached Files? brokenmapinfo.wad (1,730) 2016-02-12 01:51
/tracker/file_download.php?file_id=1736&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-02-12 01:51MarcaekNew Issue
2016-02-12 01:51MarcaekFile Added: brokenmapinfo.wad
2016-02-12 02:04MarcaekNote Added: 0014425
2016-02-14 15:53Torr SamahoNote Added: 0014440
2016-02-20 10:08DuskAssigned To => Dusk
2016-02-20 10:08DuskStatusnew => assigned
2016-02-20 10:48DuskNote Added: 0014464
2016-02-20 10:48DuskStatusassigned => needs review
2016-02-20 11:39cobaltStatusneeds review => needs testing
2016-02-20 11:39cobaltTarget Version => 3.0
2016-02-20 11:39cobaltNote Added: 0014465
2016-03-01 21:27Ru5tK1ngNote Added: 0014524
2016-03-01 21:27Ru5tK1ngStatusneeds testing => resolved
2016-03-01 21:27Ru5tK1ngResolutionopen => fixed
2016-03-01 21:27Ru5tK1ngFixed in Version => 3.0
2018-09-30 22:10Blzut3Statusresolved => closed

Notes
(0014425)
Marcaek   
2016-02-12 02:04   
'http://painkiller.allfearthesentinel.net/download?file=brokenmapinfo.wad [^]'

'http://painkiller.allfearthesentinel.net/download?file=brokenmapinfofix.wad [^]'

Removed double map01 definiton (which wasn't the cause) and provided a fix WAD. Apparently the brackets after Endgame should not be there, yet this causes no problems in ZDoom 2.7.1
(0014440)
Torr Samaho   
2016-02-14 15:53   
Strangely, this only affects the server. The Zandronum client is not affected. Needs to be investigated.

BTW: This is not a crash. The server detects the script error, prints a proper error message and exits gracefully.
(0014464)
Dusk   
2016-02-20 10:48   
Fixed:'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/69 [^]'

However, this revealed a bigger problem. We don't have any proper handling for the new endgame types. For instance, E3M8 uses "endbunny" as the next map (which I guess is easy enough to loop back to E1M1), but there are generalized intermission definitions out there now. What do we do when the server encounters this? We need to find a way to get the first map and loop back to that.
(0014465)
cobalt   
2016-02-20 11:39   
Issue addressed by commit d040179df2b8: Fixed: the server did not parse MAPINFO endgame sections correctly, fixes 2632
Committed by Teemu Piippo [Dusk] on Wednesday 31 December 1969 23:59:57

Changes in files:

 src/g_mapinfo.cpp | 25 +++++++++++--------------
 src/intermission/intermission_parse.cpp | 10 +++++++++-
 2 files changed, 20 insertions(+), 15 deletions(-)
(0014524)
Ru5tK1ng   
2016-03-01 21:27   
I ran the test wad with the latest build and I did not come across any type of crash.