Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002631Zandronum[All Projects] Bugpublic2016-02-11 17:282018-09-30 22:02
ReporterDusk 
Assigned ToDusk 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version3.0Fixed in Version3.0 
Summary0002631: v_IsCharAcceptableInNames rejects ampersands on bad grounds
Description

// [RC] Returns whether this character is allowed in names.
bool v_IsCharAcceptableInNames ( char c )
{
    ...
    // Pound is hard to type on USA boards.
    if ( c == 38 )
        return false;
    ...
}

The hell? ASCII doesn't even have a code for the pound character, that's latin-1.
Attached Files

- Relationships

-  Notes
User avatar (0014426)
Konar6 (reporter)
2016-02-12 14:09

 I think ampersands aren't supported in some ingame fonts, so it's just the comment that's misleading.
User avatar (0014488)
Dusk (developer)
2016-02-23 22:40

 It was decided that since ampersands don't show up very well in Heretic, we should keep filtering them.

'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/72 [^]'
User avatar (0014511)
cobalt (updater)
2016-02-28 10:41

 Issue addressed by commit 4d54271ef893: Corrected ampersand filtering logic in v_IsCharAcceptableInNames, addresses 2631
Committed by Teemu Piippo [Dusk] on Wednesday 31 December 1969 23:59:57

Changes in files:

 src/v_text.cpp | 4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
User avatar (0015007)
Ru5tK1ng (updater)
2016-06-04 16:38

 Tested with r160519-2047 and ampersands were filtered in names in the core IWADs.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: Korshun
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2016-02-11 17:28 Dusk New Issue
2016-02-12 14:09 Konar6 Note Added: 0014426
2016-02-23 22:40 Dusk Note Added: 0014488
2016-02-23 22:40 Dusk Assigned To => Dusk
2016-02-23 22:40 Dusk Status new => needs review
2016-02-28 10:41 cobalt Status needs review => needs testing
2016-02-28 10:41 cobalt Target Version => 3.0
2016-02-28 10:41 cobalt Description Updated View Revisions
2016-02-28 10:41 cobalt Note Added: 0014511
2016-06-04 16:38 Ru5tK1ng Note Added: 0015007
2016-06-04 16:38 Ru5tK1ng Status needs testing => resolved
2016-06-04 16:38 Ru5tK1ng Resolution open => fixed
2016-06-04 16:38 Ru5tK1ng Fixed in Version => 3.0
2016-06-04 16:38 Ru5tK1ng Description Updated View Revisions
2018-09-30 22:02 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker