MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002631Zandronum[All Projects] Bugpublic2016-02-11 17:282018-09-30 22:02
ReporterDusk 
Assigned ToDusk 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version3.0Fixed in Version3.0 
Summary0002631: v_IsCharAcceptableInNames rejects ampersands on bad grounds
Description

// [RC] Returns whether this character is allowed in names.
bool v_IsCharAcceptableInNames ( char c )
{
    ...
    // Pound is hard to type on USA boards.
    if ( c == 38 )
        return false;
    ...
}

The hell? ASCII doesn't even have a code for the pound character, that's latin-1.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-02-11 17:28DuskNew Issue
2016-02-12 14:09Konar6Note Added: 0014426
2016-02-23 22:40DuskNote Added: 0014488
2016-02-23 22:40DuskAssigned To => Dusk
2016-02-23 22:40DuskStatusnew => needs review
2016-02-28 10:41cobaltStatusneeds review => needs testing
2016-02-28 10:41cobaltTarget Version => 3.0
2016-02-28 10:41cobaltDescription Updatedbug_revision_view_page.php?rev_id=8784#r8784
2016-02-28 10:41cobaltNote Added: 0014511
2016-06-04 16:38Ru5tK1ngNote Added: 0015007
2016-06-04 16:38Ru5tK1ngStatusneeds testing => resolved
2016-06-04 16:38Ru5tK1ngResolutionopen => fixed
2016-06-04 16:38Ru5tK1ngFixed in Version => 3.0
2016-06-04 16:38Ru5tK1ngDescription Updatedbug_revision_view_page.php?rev_id=9046#r9046
2018-09-30 22:02Blzut3Statusresolved => closed

Notes
(0014426)
Konar6   
2016-02-12 14:09   
I think ampersands aren't supported in some ingame fonts, so it's just the comment that's misleading.
(0014488)
Dusk   
2016-02-23 22:40   
It was decided that since ampersands don't show up very well in Heretic, we should keep filtering them.

'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/72 [^]'
(0014511)
cobalt   
2016-02-28 10:41   
Issue addressed by commit 4d54271ef893: Corrected ampersand filtering logic in v_IsCharAcceptableInNames, addresses 2631
Committed by Teemu Piippo [Dusk] on Wednesday 31 December 1969 23:59:57

Changes in files:

 src/v_text.cpp | 4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
(0015007)
Ru5tK1ng   
2016-06-04 16:38   
Tested with r160519-2047 and ampersands were filtered in names in the core IWADs.