Anonymous | Login | Signup for a new account | 2024-04-19 22:42 UTC |
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0002561 | Zandronum | [All Projects] Suggestion | public | 2016-01-02 13:59 | 2018-09-30 21:48 | ||||
Reporter | Dusk | ||||||||
Assigned To | Dusk | ||||||||
Priority | normal | Severity | minor | Reproducibility | N/A | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | |||||||||
Target Version | 3.0 | Fixed in Version | 3.0 | ||||||
Summary | 0002561: CLIENT_WARNING_MESSAGES | ||||||||
Description | Do we still ever use client warning messages? If so I think this should be turned into a CVar. I almost broke client warning messages by renaming 'lID' to 'id' without updating this code and the compiler didn't complain because it's preprocessored away. This wouldn't have had a chance of happening if it was a CVar (and it'd probably be much more usable if Zandronum didn't have to be recompiled to use these messages). | ||||||||
Attached Files | Screenshot_Doom_20160206_125939.png [^] (651,297 bytes) 2016-02-06 21:16 Screenshot_Doom_20160206_131239.png [^] (640,487 bytes) 2016-02-06 21:16 | ||||||||
Relationships | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Notes | |
(0014116) Torr Samaho (administrator) 2016-01-17 20:29 |
I'm fine with changing this into a CVAR. |
(0014367) Dusk (developer) 2016-02-06 17:14 |
'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/64 [^]' |
(0014370) cobalt (updater) 2016-02-06 18:04 |
Issue addressed by commit 340e819e86cb: Replaced the CLIENT_WARNING_MESSAGES #ifdef stuff with a CVAR, cl_showwarnings, addresses 2561. This way we avoid the inherent problems of conditional compilation (namely, the code inside breaking without the compiler ever getting to warn us), and makes enabling these warning messages much easier to do. A couple of other warning messages are now also subject to this CVAR for consistency, and a warning message was added for SetThingState. Committed by Teemu Piippo [Dusk] on Wednesday 31 December 1969 23:59:57 Changes in files:
|
(0014382) WaTaKiD (updater) 2016-02-06 21:16 edited on: 2016-02-06 21:20 |
using:'https://www.dropbox.com/s/efn0f3skyqu5ue5/zandronum-3.0-r160206-1709-340e819-windows.zip?dl=0 [^]' i hosted a local server with doom2.wad map01 and coop, connected and joined a client with cl_showwarnings enabled and exited the map normally, upon loading the next map, see first attached screenshot and then with survival, see second attached screenshot regarding when the round reset upon joining, and when exiting the map note: i initially had sv_survivalcountdowntime set to 1, but if i set it to 3 then that message wont show upon round reset |
(0014533) WaTaKiD (updater) 2016-03-01 22:53 |
cl_showwarnings works, and as such this ticket will be marked as resolved meanwhile, warnings it prints (my above note for example) will be dealt with in separate tickets that will be related to this one |
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why. |
|
Supporters: | No one explicitly supports this issue yet. |
Opponents: | No one explicitly opposes this issue yet. |
Issue History | |||
Date Modified | Username | Field | Change |
2016-01-02 13:59 | Dusk | New Issue | |
2016-01-17 20:29 | Torr Samaho | Note Added: 0014116 | |
2016-02-05 22:24 | Dusk | Assigned To | => Dusk |
2016-02-05 22:24 | Dusk | Status | new => assigned |
2016-02-06 17:14 | Dusk | Note Added: 0014367 | |
2016-02-06 17:14 | Dusk | Status | assigned => needs review |
2016-02-06 18:04 | cobalt | Status | needs review => needs testing |
2016-02-06 18:04 | cobalt | Target Version | => 3.0 |
2016-02-06 18:04 | cobalt | Note Added: 0014370 | |
2016-02-06 21:16 | WaTaKiD | Note Added: 0014382 | |
2016-02-06 21:16 | WaTaKiD | File Added: Screenshot_Doom_20160206_125939.png | |
2016-02-06 21:16 | WaTaKiD | File Added: Screenshot_Doom_20160206_131239.png | |
2016-02-06 21:20 | WaTaKiD | Note Edited: 0014382 | View Revisions |
2016-03-01 22:53 | WaTaKiD | Note Added: 0014533 | |
2016-03-01 22:53 | WaTaKiD | Status | needs testing => resolved |
2016-03-01 22:53 | WaTaKiD | Resolution | open => fixed |
2016-03-01 22:53 | WaTaKiD | Fixed in Version | => 3.0 |
2016-03-01 23:19 | WaTaKiD | Relationship added | parent of 0002652 |
2016-03-01 23:22 | WaTaKiD | Relationship added | parent of 0002653 |
2016-03-01 23:28 | WaTaKiD | Relationship added | parent of 0002654 |
2016-03-01 23:32 | WaTaKiD | Relationship added | parent of 0002655 |
2016-03-06 21:22 | WaTaKiD | Relationship added | parent of 0002664 |
2016-03-06 21:29 | WaTaKiD | Relationship added | parent of 0002665 |
2016-03-06 21:49 | WaTaKiD | Relationship added | parent of 0002666 |
2016-03-06 21:54 | WaTaKiD | Relationship added | parent of 0002667 |
2016-03-06 22:26 | WaTaKiD | Relationship added | parent of 0002668 |
2016-03-06 22:27 | WaTaKiD | Relationship added | parent of 0002669 |
2016-12-07 10:08 | WaTaKiD | Relationship added | parent of 0002946 |
2016-12-07 10:16 | WaTaKiD | Relationship added | parent of 0002947 |
2016-12-07 10:28 | WaTaKiD | Relationship added | parent of 0002948 |
2016-12-07 10:34 | WaTaKiD | Relationship added | parent of 0002949 |
2016-12-07 10:54 | WaTaKiD | Relationship added | parent of 0002950 |
2016-12-07 11:20 | WaTaKiD | Relationship added | parent of 0002951 |
2016-12-07 11:20 | WaTaKiD | Relationship added | parent of 0002952 |
2016-12-07 11:25 | WaTaKiD | Relationship added | parent of 0002953 |
2017-02-09 00:57 | WaTaKiD | Relationship added | parent of 0003007 |
2017-02-09 00:59 | WaTaKiD | Relationship added | parent of 0003008 |
2018-09-30 21:48 | Blzut3 | Status | resolved => closed |
Copyright © 2000 - 2024 MantisBT Team |