Anonymous | Login | Signup for a new account | 2024-04-19 23:09 UTC |
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0002478 | Zandronum | [All Projects] Bug | public | 2015-10-05 15:32 | 2022-10-14 02:01 | ||||
Reporter | Dusk | ||||||||
Assigned To | Dusk | ||||||||
Priority | normal | Severity | minor | Reproducibility | have not tried | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | |||||||||
Target Version | 3.0 | Fixed in Version | 3.0 | ||||||
Summary | 0002478: sv_nokill and sv_disallowsuicide | ||||||||
Description | There's pretty clear redundancy in here that IMO should be removed. Both these CVars seem to do the same thing. sv_disallowsuicide, however, comes from ZDoom and is a dmflags so it should be the one to stay (even though its name is pretty horrible :|) | ||||||||
Attached Files | |||||||||
Relationships | |||||||||||
|
Notes | |
(0013611) Torr Samaho (administrator) 2015-10-05 17:11 |
I added sv_nokill to ST about a year before ZDoom introduced sv_disallowsuicide, that's where the redundancy comes from. Feel free to unify this, but it would be nice if we keep sv_nokill as alias to sv_disallowsuicide. |
(0013633) Dusk (developer) 2015-10-09 08:13 |
'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/31 [^]' sv_nokill is now another flag CVar that points to the same bit as sv_disallowsuicide, so now it's a dmflag with two CVars. Setting one CVar effectively sets the other. |
(0013638) Torr Samaho (administrator) 2015-10-10 09:11 |
Please see my comment on bitbucket. |
(0013645) cobalt (updater) 2015-10-10 14:06 |
Issue addressed by commit 077919020ed5: Merged sv_nokill and sv_disallowsuicide into one dmflag with two names (addresses 2478) Committed by Teemu Piippo [Dusk] on Saturday 10 October 2015 14:16:43 Changes in files:
|
(0013772) Ru5tK1ng (updater) 2015-11-09 23:57 |
Tested with r151108-1238 and setting one flag correctly sets the other. |
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why. |
|
Supporters: | Combinebobnt |
Opponents: | No one explicitly opposes this issue yet. |
Issue History | |||
Date Modified | Username | Field | Change |
2015-10-05 15:32 | Dusk | New Issue | |
2015-10-05 17:11 | Torr Samaho | Note Added: 0013611 | |
2015-10-09 08:13 | Dusk | Note Added: 0013633 | |
2015-10-09 08:13 | Dusk | Assigned To | => Dusk |
2015-10-09 08:13 | Dusk | Status | new => needs review |
2015-10-09 08:16 | Dusk | Relationship added | child of 0002484 |
2015-10-10 09:11 | Torr Samaho | Note Added: 0013638 | |
2015-10-10 09:11 | Torr Samaho | Status | needs review => feedback |
2015-10-10 11:17 | Dusk | Status | feedback => needs review |
2015-10-10 14:06 | cobalt | Status | needs review => needs testing |
2015-10-10 14:06 | cobalt | Target Version | => 3.0 |
2015-10-10 14:06 | cobalt | Note Added: 0013645 | |
2015-11-09 23:57 | Ru5tK1ng | Note Added: 0013772 | |
2015-11-09 23:58 | Ru5tK1ng | Status | needs testing => resolved |
2015-11-09 23:58 | Ru5tK1ng | Resolution | open => fixed |
2015-11-09 23:58 | Ru5tK1ng | Fixed in Version | => 3.0 |
2018-09-30 22:16 | Blzut3 | Status | resolved => closed |
2022-10-14 02:01 | WaTaKiD | Relationship added | related to 0001913 |
Copyright © 2000 - 2024 MantisBT Team |