MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002478Zandronum[All Projects] Bugpublic2015-10-05 15:322022-10-14 02:01
ReporterDusk 
Assigned ToDusk 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version3.0Fixed in Version3.0 
Summary0002478: sv_nokill and sv_disallowsuicide
DescriptionThere's pretty clear redundancy in here that IMO should be removed. Both these CVars seem to do the same thing. sv_disallowsuicide, however, comes from ZDoom and is a dmflags so it should be the one to stay (even though its name is pretty horrible :|)
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0001913closed  Remove unneeded sv_nokill 
child of 0002484resolved  Server setup menu 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-10-05 15:32DuskNew Issue
2015-10-05 17:11Torr SamahoNote Added: 0013611
2015-10-09 08:13DuskNote Added: 0013633
2015-10-09 08:13DuskAssigned To => Dusk
2015-10-09 08:13DuskStatusnew => needs review
2015-10-09 08:16DuskRelationship addedchild of 0002484
2015-10-10 09:11Torr SamahoNote Added: 0013638
2015-10-10 09:11Torr SamahoStatusneeds review => feedback
2015-10-10 11:17DuskStatusfeedback => needs review
2015-10-10 14:06cobaltStatusneeds review => needs testing
2015-10-10 14:06cobaltTarget Version => 3.0
2015-10-10 14:06cobaltNote Added: 0013645
2015-11-09 23:57Ru5tK1ngNote Added: 0013772
2015-11-09 23:58Ru5tK1ngStatusneeds testing => resolved
2015-11-09 23:58Ru5tK1ngResolutionopen => fixed
2015-11-09 23:58Ru5tK1ngFixed in Version => 3.0
2018-09-30 22:16Blzut3Statusresolved => closed
2022-10-14 02:01WaTaKiDRelationship addedrelated to 0001913

Notes
(0013611)
Torr Samaho   
2015-10-05 17:11   
I added sv_nokill to ST about a year before ZDoom introduced sv_disallowsuicide, that's where the redundancy comes from. Feel free to unify this, but it would be nice if we keep sv_nokill as alias to sv_disallowsuicide.
(0013633)
Dusk   
2015-10-09 08:13   
'https://bitbucket.org/Torr_Samaho/zandronum/pull-requests/31 [^]'

sv_nokill is now another flag CVar that points to the same bit as sv_disallowsuicide, so now it's a dmflag with two CVars. Setting one CVar effectively sets the other.
(0013638)
Torr Samaho   
2015-10-10 09:11   
Please see my comment on bitbucket.
(0013645)
cobalt   
2015-10-10 14:06   
Issue addressed by commit 077919020ed5: Merged sv_nokill and sv_disallowsuicide into one dmflag with two names (addresses 2478)
Committed by Teemu Piippo [Dusk] on Saturday 10 October 2015 14:16:43

Changes in files:

 docs/zandronum-history.txt | 1 +
 src/p_interaction.cpp | 4 ++++
 src/sv_main.cpp | 7 ++-----
 3 files changed, 7 insertions(+), 5 deletions(-)
(0013772)
Ru5tK1ng   
2015-11-09 23:57   
Tested with r151108-1238 and setting one flag correctly sets the other.