Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002361Zandronum[All Projects] Bugpublic2015-07-26 01:052023-05-15 13:35
ReporterRu5tK1ng 
Assigned ToDrinkyBird 
PrioritynormalSeverityminorReproducibilityalways
Statusneeds reviewResolutionopen 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version2.1 
Target Version3.2Fixed in Version 
Summary0002361: Floatbob items respawn incorrectly after Duel Countdown
DescriptionThis occurs both online and offline. If you have an item with the floatbob property on a floor below or above 0 height, the item will appear higher or lower than it should be after the duel countdown resets the map. If item respawn is on then item will respawn at the correct height. I have attached a test map that illustrates this.
Steps To Reproduce1. Download floattest.wad
2. Start on map01 and observe the float behavior
3. Make sure the mode is in duel and the duel countdown is greater than 1
4. add a bot
5. After the countdown resets the map, the floating is now incorrect
6. Spectate and rejoin if nothing changes
Attached Files? file icon floattest.wad [^] (3,562 bytes) 2015-07-26 01:05

- Relationships

-  Notes
User avatar (0013004)
Dusk (developer)
2015-07-26 01:26

 https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-request/138 [^]
User avatar (0013007)
WaTaKiD (updater)
2015-07-26 07:56

 this build contains the above commit:https://www.dropbox.com/s/ly8ias3ko9s4388/zandronum-2.1.2-r150726-0121-5069de9-windows.zip?dl=0 [^]
User avatar (0013008)
Ru5tK1ng (updater)
2015-07-26 20:35

 I tested the build locally and on a LAN server. The floating items didn't desync or float incorrectly at all.
User avatar (0013011)
Dusk (developer)
2015-07-27 17:08

 https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-request/1 [^]
User avatar (0015663)
Ru5tK1ng (updater)
2016-09-19 01:34

 I read the comments on that pull request and I tried for a good while to try to invoke the code that follows this if statement:

// If this object belongs to someone's inventory, and it originally spawned on the
// level, respawn the item in its original location, but don't take it out of the
// player's inventory.
    if (( pActor->IsKindOf( RUNTIME_CLASS( AInventory ))) &&
        ( static_cast<AInventory *>( pActor )->Owner ))


All floatbob items lived through countdowns, resets, ACS Resets, offline, online, custom inventory items, heretic timebomb, on floors, on 3d floors, z-height or no z-height, item respawn off or on.

I would say it's safe to say that single change is all that's needed to fix the bug. If someone devises a case where bobbing breaks with the fix, we at least already know what to change.
User avatar (0017787)
Combinebobnt (reporter)
2017-05-29 02:38

 affected old eon weapons and cyberrunner. all the items float at one height level in the map
User avatar (0022845)
DrinkyBird (developer)
2023-05-15 13:35

 Brought this up in the latest dev meeting as it recently came to my attention due to affecting a Jumpmaze X map. Proposed a fix that ended up the same as Dusk's but covered more bases (nightmare respawns and some obscure CCMD). We'll see what happens next meeting.

Issue Community Support
Only registered users can voice their support. Click here to register, or here to log in.
Supporters: Combinebobnt
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2015-07-26 01:05 Ru5tK1ng New Issue
2015-07-26 01:05 Ru5tK1ng File Added: floattest.wad
2015-07-26 01:26 Dusk Note Added: 0013004
2015-07-26 01:26 Dusk Assigned To => Dusk
2015-07-26 01:26 Dusk Status new => needs review
2015-07-26 01:27 Dusk Summary Floatbob Desyncs after Duel Countdown => Floatbob items respawn incorrectly after Duel Countdown
2015-07-26 07:56 WaTaKiD Note Added: 0013007
2015-07-26 20:35 Ru5tK1ng Note Added: 0013008
2015-07-27 17:08 Dusk Note Added: 0013011
2016-09-19 01:34 Ru5tK1ng Note Added: 0015663
2017-05-29 02:38 Combinebobnt Note Added: 0017787
2023-05-15 13:35 DrinkyBird Note Added: 0022845
2023-05-15 13:35 DrinkyBird Assigned To Dusk => DrinkyBird
2023-05-15 13:35 DrinkyBird Target Version => 3.2




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2023 MantisBT Team
Powered by Mantis Bugtracker