MantisBT - Zandronum
View Issue Details
0002361Zandronum[All Projects] Bugpublic2015-07-26 01:052024-03-07 18:32
Ru5tK1ng 
 
normalminoralways
resolvedfixed 
MicrosoftWindowsXP/Vista/7
2.1 
3.23.2 
0002361: Floatbob items respawn incorrectly after Duel Countdown
This occurs both online and offline. If you have an item with the floatbob property on a floor below or above 0 height, the item will appear higher or lower than it should be after the duel countdown resets the map. If item respawn is on then item will respawn at the correct height. I have attached a test map that illustrates this.
1. Download floattest.wad
2. Start on map01 and observe the float behavior
3. Make sure the mode is in duel and the duel countdown is greater than 1
4. add a bot
5. After the countdown resets the map, the floating is now incorrect
6. Spectate and rejoin if nothing changes
No tags attached.
? floattest.wad (3,562) 2015-07-26 01:05
https://zandronum.com/tracker/file_download.php?file_id=1590&type=bug
diff floatbob.diff (2,842) 2024-01-05 02:39
https://zandronum.com/tracker/file_download.php?file_id=2876&type=bug
? floattestv2.wad (6,316) 2024-03-03 06:43
https://zandronum.com/tracker/file_download.php?file_id=2905&type=bug
Issue History
2015-07-26 01:05Ru5tK1ngNew Issue
2015-07-26 01:05Ru5tK1ngFile Added: floattest.wad
2015-07-26 01:26DuskNote Added: 0013004
2015-07-26 01:26DuskAssigned To => Dusk
2015-07-26 01:26DuskStatusnew => needs review
2015-07-26 01:27DuskSummaryFloatbob Desyncs after Duel Countdown => Floatbob items respawn incorrectly after Duel Countdown
2015-07-26 07:56WaTaKiDNote Added: 0013007
2015-07-26 20:35Ru5tK1ngNote Added: 0013008
2015-07-27 17:08DuskNote Added: 0013011
2016-09-19 01:34Ru5tK1ngNote Added: 0015663
2017-05-29 02:38CombinebobntNote Added: 0017787
2023-05-15 13:35DrinkyBirdNote Added: 0022845
2023-05-15 13:35DrinkyBirdAssigned ToDusk => DrinkyBird
2023-05-15 13:35DrinkyBirdTarget Version => 3.2
2023-06-13 23:04DrinkyBirdAssigned ToDrinkyBird =>
2023-06-13 23:04DrinkyBirdStatusneeds review => confirmed
2023-06-13 23:04DrinkyBirdNote Deleted: 0022845
2024-01-05 02:39Ru5tK1ngFile Added: floatbob.diff
2024-01-05 02:43Ru5tK1ngNote Added: 0022971
2024-01-05 02:46Ru5tK1ngStatusconfirmed => needs review
2024-01-07 20:26Torr SamahoNote Added: 0022973
2024-01-07 21:38KaminskyNote Added: 0022975
2024-01-07 21:38KaminskyStatusneeds review => needs testing
2024-03-03 06:43Ru5tK1ngNote Added: 0023287
2024-03-03 06:43Ru5tK1ngStatusneeds testing => needs review
2024-03-03 06:43Ru5tK1ngFile Added: floattestv2.wad
2024-03-03 17:25Ru5tK1ngNote Added: 0023294
2024-03-03 17:25Ru5tK1ngStatusneeds review => needs testing
2024-03-07 18:32Ru5tK1ngNote Added: 0023313
2024-03-07 18:32Ru5tK1ngStatusneeds testing => resolved
2024-03-07 18:32Ru5tK1ngResolutionopen => fixed
2024-03-07 18:32Ru5tK1ngFixed in Version => 3.2

Notes
(0013004)
Dusk   
2015-07-26 01:26   
'https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-request/138 [^]'
(0013007)
WaTaKiD   
2015-07-26 07:56   
this build contains the above commit:'https://www.dropbox.com/s/ly8ias3ko9s4388/zandronum-2.1.2-r150726-0121-5069de9-windows.zip?dl=0 [^]'
(0013008)
Ru5tK1ng   
2015-07-26 20:35   
I tested the build locally and on a LAN server. The floating items didn't desync or float incorrectly at all.
(0013011)
Dusk   
2015-07-27 17:08   
'https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-request/1 [^]'
(0015663)
Ru5tK1ng   
2016-09-19 01:34   
I read the comments on that pull request and I tried for a good while to try to invoke the code that follows this if statement:

// If this object belongs to someone's inventory, and it originally spawned on the
// level, respawn the item in its original location, but don't take it out of the
// player's inventory.
    if (( pActor->IsKindOf( RUNTIME_CLASS( AInventory ))) &&
        ( static_cast<AInventory *>( pActor )->Owner ))


All floatbob items lived through countdowns, resets, ACS Resets, offline, online, custom inventory items, heretic timebomb, on floors, on 3d floors, z-height or no z-height, item respawn off or on.

I would say it's safe to say that single change is all that's needed to fix the bug. If someone devises a case where bobbing breaks with the fix, we at least already know what to change.
(0017787)
Combinebobnt   
2017-05-29 02:38   
affected old eon weapons and cyberrunner. all the items float at one height level in the map
(0022971)
Ru5tK1ng   
2024-01-05 02:43   
I uploaded a patch that fixes this issue and the awkward clipping behavior with gl_spriteclip 0.
(0022973)
Torr Samaho   
2024-01-07 20:26   
Part of this patch is in GZDoom code. So this sounds like this is a GZDoom. Is it? If so, did GZDoom fix this?
(0022975)
Kaminsky   
2024-01-07 21:38   
Ru5tK1ng: Hello, in regards to 2361, gzdoom did fix hexen floatbob clipping but way ahead in version 4.5.0
Torr Samaho: Ok, so that sounds like the GZDoom fix is way too far off to backport and considering our own fix should be fine.

The patch ("floatbob.diff") attached to this ticket was pushed into the repository:'https://foss.heptapod.net/zandronum/zandronum-stable/-/commit/17757ad8e820f40edf930d64f27b5641c62d1fa6 [^]'
(0023287)
Ru5tK1ng   
2024-03-03 06:43   
Mostly fixed from testing. Just needs 1 last adjustment:
'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/39 [^]'
(0023294)
Ru5tK1ng   
2024-03-03 17:25   
Change was merged in
(0023313)
Ru5tK1ng   
2024-03-07 18:32   
Pulled the latest changes and this bug can finally be put to rest.