Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002262Zandronum[All Projects] Bugpublic2015-05-27 00:412018-09-30 22:04
ReporterDusk 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0002262: A_RadiusGive doesn't work properly online
DescriptionThe server doesn't dictate the result of A_RadiusGive and clients execute the item give on their own.

Consider the attached decorate, cheat a rocket launcher (and a ragerune), take an imp ball to the face which will give a random amount of rockets. The ammo count and 'rcon printinv 0' will disagree on the amount of rockets and if you keep firing rockets you will either have more rockets than your client thinks or your client will keep trying to shoot rockets you actually don't have.
Steps To Reproduce

ACTOR MyDoomImpBall : DoomImpBall replaces DoomImpBall
{
    Damage 0

    States
    {
    Death:
        TNT1 A 0 A_RadiusGive ("RocketAmmo", 64, RGF_PLAYERS, random (1, 100))
        goto Super::Death
    }
}
Attached Files

- Relationships

-  Notes
User avatar (0013025)
Major Cooke (reporter)
2015-07-31 22:21

 Just to ensure everyone's aware, I've overhauled A_RadiusGive some time ago.

'http://zdoom.org/Changelog/8d7c93d/files [^]'
'http://zdoom.org/Changelog/52bfc1e/files [^]' <--Minor bugfix after the previous one.

Half of the flags were not even working at all before these, but now A_RadiusGive also supports items, and several other flags.

'http://zdoom.org/wiki/A_RadiusGive [^]' All details may be found here as well.
User avatar (0013026)
Dusk (developer)
2015-08-01 00:13
edited on: 2015-08-01 00:14

 3.0 only targets ZDoom 2.7.1 so that overhaul is not getting in right now, also it's not in any released ZDoom version so it won't be in the future either until ZDoom does a release.
User avatar (0013141)
Torr Samaho (administrator)
2015-08-09 10:20

 I agree with Dusk. We are concerned with compatibility with ZDoom's stable releases. It is ZDoom's business to ensure that its stable releases stay backwards compatible.

The online issues should be fixed now.
User avatar (0013143)
cobalt (updater)
2015-08-09 10:26

 Issue addressed by commit 5850bcb156ff: Fixed: A_RadiusGive didn't work properly online (fixes 2262).
Committed by Benjamin Berkels [Torr Samaho] on Sunday 09 August 2015 12:14:15

Changes in files:

 src/thingdef/thingdef_codeptr.cpp | 7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
User avatar (0013466)
Ru5tK1ng (updater)
2015-09-10 04:08

 This decorate example seemed to work fine with 3.0-150831-1814. I got random amounts of rockets and I never fired more than I had or less than I had.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2015-05-27 00:41 Dusk New Issue
2015-05-27 01:19 Dusk Target Version => 3.0
2015-07-31 22:21 Major Cooke Note Added: 0013025
2015-08-01 00:13 Dusk Note Added: 0013026
2015-08-01 00:14 Dusk Note Edited: 0013026 View Revisions
2015-08-09 10:20 Torr Samaho Note Added: 0013141
2015-08-09 10:20 Torr Samaho Assigned To => Torr Samaho
2015-08-09 10:20 Torr Samaho Status new => needs testing
2015-08-09 10:26 cobalt Note Added: 0013143
2015-09-10 04:08 Ru5tK1ng Note Added: 0013466
2015-09-10 07:10 Dusk Status needs testing => resolved
2015-09-10 07:10 Dusk Fixed in Version => 3.0
2015-09-10 07:10 Dusk Resolution open => fixed
2018-09-30 22:04 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker