MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002262Zandronum[All Projects] Bugpublic2015-05-27 00:412018-09-30 22:04
ReporterDusk 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0002262: A_RadiusGive doesn't work properly online
DescriptionThe server doesn't dictate the result of A_RadiusGive and clients execute the item give on their own.

Consider the attached decorate, cheat a rocket launcher (and a ragerune), take an imp ball to the face which will give a random amount of rockets. The ammo count and 'rcon printinv 0' will disagree on the amount of rockets and if you keep firing rockets you will either have more rockets than your client thinks or your client will keep trying to shoot rockets you actually don't have.
Steps To Reproduce

ACTOR MyDoomImpBall : DoomImpBall replaces DoomImpBall
{
    Damage 0

    States
    {
    Death:
        TNT1 A 0 A_RadiusGive ("RocketAmmo", 64, RGF_PLAYERS, random (1, 100))
        goto Super::Death
    }
}
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-05-27 00:41DuskNew Issue
2015-05-27 01:19DuskTarget Version => 3.0
2015-07-31 22:21Major CookeNote Added: 0013025
2015-08-01 00:13DuskNote Added: 0013026
2015-08-01 00:14DuskNote Edited: 0013026bug_revision_view_page.php?bugnote_id=13026#r7782
2015-08-09 10:20Torr SamahoNote Added: 0013141
2015-08-09 10:20Torr SamahoAssigned To => Torr Samaho
2015-08-09 10:20Torr SamahoStatusnew => needs testing
2015-08-09 10:26cobaltNote Added: 0013143
2015-09-10 04:08Ru5tK1ngNote Added: 0013466
2015-09-10 07:10DuskStatusneeds testing => resolved
2015-09-10 07:10DuskFixed in Version => 3.0
2015-09-10 07:10DuskResolutionopen => fixed
2018-09-30 22:04Blzut3Statusresolved => closed

Notes
(0013025)
Major Cooke   
2015-07-31 22:21   
Just to ensure everyone's aware, I've overhauled A_RadiusGive some time ago.

'http://zdoom.org/Changelog/8d7c93d/files [^]'
'http://zdoom.org/Changelog/52bfc1e/files [^]' <--Minor bugfix after the previous one.

Half of the flags were not even working at all before these, but now A_RadiusGive also supports items, and several other flags.

'http://zdoom.org/wiki/A_RadiusGive [^]' All details may be found here as well.
(0013026)
Dusk   
2015-08-01 00:13   
(edited on: 2015-08-01 00:14)
3.0 only targets ZDoom 2.7.1 so that overhaul is not getting in right now, also it's not in any released ZDoom version so it won't be in the future either until ZDoom does a release.
(0013141)
Torr Samaho   
2015-08-09 10:20   
I agree with Dusk. We are concerned with compatibility with ZDoom's stable releases. It is ZDoom's business to ensure that its stable releases stay backwards compatible.

The online issues should be fixed now.
(0013143)
cobalt   
2015-08-09 10:26   
Issue addressed by commit 5850bcb156ff: Fixed: A_RadiusGive didn't work properly online (fixes 2262).
Committed by Benjamin Berkels [Torr Samaho] on Sunday 09 August 2015 12:14:15

Changes in files:

 src/thingdef/thingdef_codeptr.cpp | 7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
(0013466)
Ru5tK1ng   
2015-09-10 04:08   
This decorate example seemed to work fine with 3.0-150831-1814. I got random amounts of rockets and I never fired more than I had or less than I had.