Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002247Zandronum[All Projects] Bugpublic2015-05-24 10:422018-09-30 22:19
ReporterDark-Assassin 
Assigned ToEdward-san 
PriorityhighSeveritymajorReproducibilityrandom
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0002247: A_SetScale weirdness online
DescriptionOnline under certain conditions, A_SetScale will fail.

Tested with zandronum-3.0-r150523-1323-d946e45-windows
Steps To ReproduceLoad A_SetScaleTest.wad online
Summon actors ScaleTest ScaleTest2 ScaleTest3 ScaleTest4
Observe the differences
Additional InformationI only found it happens before or after A_Jump unless 2 separate frames both with >1 tics have passed. Length of those frames doesn't matter.

This breaks instant scale setting. Random or not.
Attached Files? file icon A_SetScaleTest.wad [^] (917 bytes) 2015-05-24 10:42

- Relationships
has duplicate 0002264closedEdward-san A_SetScale doesn't work online 
related to 0002265closedTorr Samaho A_SpawnItemEx flag SXF_TRANSFERSCALE doesn't work online 

-  Notes
User avatar (0012777)
Edward-san (developer)
2015-06-23 20:19
edited on: 2015-07-25 09:54

 Should be fixed with'https://bitbucket.org/crimsondusk/zandronum-sandbox-stable/commits/53216adaddc420c73a42aac197e51d82a49ce0e8 [^]' (patch made for stable, because I managed to port A_SetScale and A_SetMass to 2.x here:'https://bitbucket.org/crimsondusk/zandronum-sandbox-stable/commits/f5e0789eeba2d9a448e9d7e3b0900d107b1887c2 [^]').

Edit: fixed some code churn here:'https://bitbucket.org/crimsondusk/zandronum-sandbox-stable/commits/1d189a899246658e48884f30e2fce7b5655749de [^]' and'https://bitbucket.org/crimsondusk/zandronum-sandbox-stable/commits/4119b132329fc8d3433aaffc6882379864126d6d. [^]'
User avatar (0013075)
Torr Samaho (administrator)
2015-08-07 17:17

 Please recreate the patches in a single changeset and without backports based on 3.0's current head.
User avatar (0013078)
Edward-san (developer)
2015-08-08 00:28

 Done, but please test if this works.
User avatar (0013083)
Torr Samaho (administrator)
2015-08-08 09:23
Quote from Edward-san
Done

Thanks!

Quote from Edward-san
but please test if this works.

Wait, does this mean you didn't test this?
User avatar (0013085)
Edward-san (developer)
2015-08-08 10:14
edited on: 2015-08-08 10:20

 I tested it before upstream git code upgrade, I didn't have the time to test it if this still works now, so this is why I didn't change from 'feedback' to 'needs review' after 0002247:0013078 .
User avatar (0013106)
Torr Samaho (administrator)
2015-08-08 17:11

 Thanks for your updated patch! I rebased, compressed and added it to the head.
User avatar (0013107)
cobalt (updater)
2015-08-08 17:22

 Issue addressed by commit bfeb65caeb71: - Fixed: A_SetScale did not work online (addresses 2247 and 2264).
Committed by Edoardo Prezioso [edward-san] on Saturday 08 August 2015 17:32:40

Changes in files:

 src/cl_main.cpp | 43 +++++++++++++++++++++++++++++++++++++++++++
 src/network.h | 6 ++++++
 src/network_enums.h | 1 +
 src/sv_commands.cpp | 20 ++++++++++++++++++++
 src/sv_commands.h | 1 +
 src/sv_main.cpp | 12 ++++++++++++
 src/thingdef/thingdef_codeptr.cpp | 21 +++++++++++++++++++++
 7 files changed, 104 insertions(+), 0 deletions(-)
User avatar (0013489)
Ru5tK1ng (updater)
2015-09-12 06:07

 I tried the test wad first with GZdoom 1.8.6 to verify zan 3.0 behavior was the same offline. Then I tested the wad online with 3.0 and the scale behavior between all 3 environments was the same.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2015-05-24 10:42 Dark-Assassin New Issue
2015-05-24 10:42 Dark-Assassin File Added: A_SetScaleTest.wad
2015-05-24 18:49 Dusk Product Version => 3.0
2015-05-24 18:49 Dusk Summary 3.0 Alpha - A_SetScale weirdness online => A_SetScale weirdness online
2015-05-24 19:37 Dusk Product Version 3.0 => 3.0-beta
2015-06-23 20:19 Edward-san Note Added: 0012777
2015-06-23 20:19 Edward-san Assigned To => Edward-san
2015-06-23 20:19 Edward-san Status new => needs review
2015-06-23 22:51 Edward-san Note Edited: 0012777 View Revisions
2015-06-23 22:55 Dusk Relationship added has duplicate 0002264
2015-07-25 09:54 Edward-san Note Edited: 0012777 View Revisions
2015-08-07 17:17 Torr Samaho Note Added: 0013075
2015-08-07 17:17 Torr Samaho Status needs review => feedback
2015-08-08 00:28 Edward-san Note Added: 0013078
2015-08-08 09:23 Torr Samaho Note Added: 0013083
2015-08-08 10:14 Edward-san Note Added: 0013085
2015-08-08 10:20 Edward-san Note Edited: 0013085 View Revisions
2015-08-08 15:26 Torr Samaho Relationship added related to 0002265
2015-08-08 17:11 Torr Samaho Note Added: 0013106
2015-08-08 17:11 Torr Samaho Status feedback => needs testing
2015-08-08 17:22 cobalt Target Version => 3.0
2015-08-08 17:22 cobalt Description Updated View Revisions
2015-08-08 17:22 cobalt Steps to Reproduce Updated View Revisions
2015-08-08 17:22 cobalt Additional Information Updated View Revisions
2015-08-08 17:22 cobalt Note Added: 0013107
2015-09-12 06:07 Ru5tK1ng Note Added: 0013489
2015-09-12 11:39 Dusk Status needs testing => resolved
2015-09-12 11:39 Dusk Fixed in Version => 3.0
2015-09-12 11:39 Dusk Resolution open => fixed
2018-09-30 22:19 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker