MantisBT - Zandronum |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0002247 | Zandronum | [All Projects] Bug | public | 2015-05-24 10:42 | 2018-09-30 22:19 |
|
| Reporter | Dark-Assassin | |
| Assigned To | Edward-san | |
| Priority | high | Severity | major | Reproducibility | random |
| Status | closed | Resolution | fixed | |
| Platform | | OS | | OS Version | |
| Product Version | 3.0-beta | |
| Target Version | 3.0 | Fixed in Version | 3.0 | |
|
| Summary | 0002247: A_SetScale weirdness online |
| Description | Online under certain conditions, A_SetScale will fail.
Tested with zandronum-3.0-r150523-1323-d946e45-windows |
| Steps To Reproduce | Load A_SetScaleTest.wad online
Summon actors ScaleTest ScaleTest2 ScaleTest3 ScaleTest4
Observe the differences |
| Additional Information | I only found it happens before or after A_Jump unless 2 separate frames both with >1 tics have passed. Length of those frames doesn't matter.
This breaks instant scale setting. Random or not. |
| Tags | No tags attached. |
| Relationships | | has duplicate | 0002264 | closed | Edward-san | A_SetScale doesn't work online | | related to | 0002265 | closed | Torr Samaho | A_SpawnItemEx flag SXF_TRANSFERSCALE doesn't work online |
|
| Attached Files |  A_SetScaleTest.wad (917) 2015-05-24 10:42
/tracker/file_download.php?file_id=1498&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2015-05-24 10:42 | Dark-Assassin | New Issue | |
| 2015-05-24 10:42 | Dark-Assassin | File Added: A_SetScaleTest.wad | |
| 2015-05-24 18:49 | Dusk | Product Version | => 3.0 |
| 2015-05-24 18:49 | Dusk | Summary | 3.0 Alpha - A_SetScale weirdness online => A_SetScale weirdness online |
| 2015-05-24 19:37 | Dusk | Product Version | 3.0 => 3.0-beta |
| 2015-06-23 20:19 | Edward-san | Note Added: 0012777 | |
| 2015-06-23 20:19 | Edward-san | Assigned To | => Edward-san |
| 2015-06-23 20:19 | Edward-san | Status | new => needs review |
| 2015-06-23 22:51 | Edward-san | Note Edited: 0012777 | bug_revision_view_page.php?bugnote_id=12777#r7525 |
| 2015-06-23 22:55 | Dusk | Relationship added | has duplicate 0002264 |
| 2015-07-25 09:54 | Edward-san | Note Edited: 0012777 | bug_revision_view_page.php?bugnote_id=12777#r7774 |
| 2015-08-07 17:17 | Torr Samaho | Note Added: 0013075 | |
| 2015-08-07 17:17 | Torr Samaho | Status | needs review => feedback |
| 2015-08-08 00:28 | Edward-san | Note Added: 0013078 | |
| 2015-08-08 09:23 | Torr Samaho | Note Added: 0013083 | |
| 2015-08-08 10:14 | Edward-san | Note Added: 0013085 | |
| 2015-08-08 10:20 | Edward-san | Note Edited: 0013085 | bug_revision_view_page.php?bugnote_id=13085#r7818 |
| 2015-08-08 15:26 | Torr Samaho | Relationship added | related to 0002265 |
| 2015-08-08 17:11 | Torr Samaho | Note Added: 0013106 | |
| 2015-08-08 17:11 | Torr Samaho | Status | feedback => needs testing |
| 2015-08-08 17:22 | cobalt | Target Version | => 3.0 |
| 2015-08-08 17:22 | cobalt | Description Updated | bug_revision_view_page.php?rev_id=7826#r7826 |
| 2015-08-08 17:22 | cobalt | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=7828#r7828 |
| 2015-08-08 17:22 | cobalt | Additional Information Updated | bug_revision_view_page.php?rev_id=7830#r7830 |
| 2015-08-08 17:22 | cobalt | Note Added: 0013107 | |
| 2015-09-12 06:07 | Ru5tK1ng | Note Added: 0013489 | |
| 2015-09-12 11:39 | Dusk | Status | needs testing => resolved |
| 2015-09-12 11:39 | Dusk | Fixed in Version | => 3.0 |
| 2015-09-12 11:39 | Dusk | Resolution | open => fixed |
| 2018-09-30 22:19 | Blzut3 | Status | resolved => closed |
|
Notes |
|
|
(0012777)
|
|
Edward-san
|
2015-06-23 20:19
(edited on: 2015-07-25 09:54) |
|
|
|
|
|
|
Please recreate the patches in a single changeset and without backports based on 3.0's current head. |
|
|
|
|
|
Done, but please test if this works. |
|
|
|
|
Quote from Edward-san
Done
Thanks!
Quote from Edward-san
but please test if this works.
Wait, does this mean you didn't test this? |
|
|
|
(0013085)
|
|
Edward-san
|
2015-08-08 10:14
(edited on: 2015-08-08 10:20) |
|
I tested it before upstream git code upgrade, I didn't have the time to test it if this still works now, so this is why I didn't change from 'feedback' to 'needs review' after 0002247:0013078 .
|
|
|
|
|
|
Thanks for your updated patch! I rebased, compressed and added it to the head. |
|
|
|
(0013107)
|
|
cobalt
|
|
2015-08-08 17:22
|
|
Issue addressed by commit bfeb65caeb71: - Fixed: A_SetScale did not work online (addresses 2247 and 2264).
Committed by Edoardo Prezioso [edward-san] on Saturday 08 August 2015 17:32:40
Changes in files:
src/cl_main.cpp | 43 +++++++++++++++++++++++++++++++++++++++++++
src/network.h | 6 ++++++
src/network_enums.h | 1 +
src/sv_commands.cpp | 20 ++++++++++++++++++++
src/sv_commands.h | 1 +
src/sv_main.cpp | 12 ++++++++++++
src/thingdef/thingdef_codeptr.cpp | 21 +++++++++++++++++++++
7 files changed, 104 insertions(+), 0 deletions(-)
|
|
|
|
|
|
I tried the test wad first with GZdoom 1.8.6 to verify zan 3.0 behavior was the same offline. Then I tested the wad online with 3.0 and the scale behavior between all 3 environments was the same. |
|