Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002186Zandronum[All Projects] Bugpublic2015-04-12 07:212018-09-30 21:38
ReporterEdward-san 
Assigned ToEdward-san 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version2.1Fixed in Version2.1 
Summary0002186: Inconsistent demo behavior of light strobe special
DescriptionI noticed that in p_spec.cpp, in function P_SpawnSpecials, the 'sync strobe fast' case has a different demo handling than the other light cases:


case dLight_StrobeFastSync:
    // SYNC STROBE FAST
    // [BC] In client mode, light specials may have been shut off by the server.
    // Therefore, we can't spawn them on our end.
    if ( NETWORK_GetState( ) != NETSTATE_CLIENT )
        new DStrobe (sector, STROBEBRIGHT, FASTDARK, true);
    sector->special &= 0xff00;
    break;


It doesn't have the 'CLIENTDEMO_IsPlaying() == false' check, but I don't know if this can be an issue.
Attached Files? file icon lightstrobefastsync.wad [^] (816 bytes) 2015-04-13 20:46
? file icon lightstrobefastsync_demo.cld [^] (5,497 bytes) 2015-04-13 20:47

- Relationships

-  Notes
User avatar (0012101)
Edward-san (developer)
2015-04-13 20:47

 Yeah, confirmed with the example wad and the demo I've attached.
User avatar (0012103)
Edward-san (developer)
2015-04-13 21:09

 Fixed:'https://bitbucket.org/crimsondusk/zandronum-sandbox/commits/7a4963e45cd4fa66f98e5857c0fbf54755cdb08c [^]'
User avatar (0012108)
cobalt (updater)
2015-04-14 15:02

 Issue addressed by commit 7a4963e4: - Fixed: the 'light fast strobe in sync' sector special would visually desync while playing a demo (addresses 2186).
Committed by edward_san [edward-san] on Monday 13 April 2015 23:04:43

Changes in files:
 docs/zandronum-history.txt | 1 +
 src/p_spec.cpp | 2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)
User avatar (0012580)
WaTaKiD (updater)
2015-06-07 16:02

 this issue seems fixed

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2015-04-12 07:21 Edward-san New Issue
2015-04-13 20:46 Edward-san File Added: lightstrobefastsync.wad
2015-04-13 20:47 Edward-san File Added: lightstrobefastsync_demo.cld
2015-04-13 20:47 Edward-san Note Added: 0012101
2015-04-13 20:48 Edward-san Assigned To => Edward-san
2015-04-13 20:48 Edward-san Status new => assigned
2015-04-13 21:09 Edward-san Note Added: 0012103
2015-04-13 21:09 Edward-san Status assigned => needs review
2015-04-14 15:02 cobalt Status needs review => needs testing
2015-04-14 15:02 cobalt Target Version => 2.1
2015-04-14 15:02 cobalt Description Updated View Revisions
2015-04-14 15:02 cobalt Note Added: 0012108
2015-06-07 16:02 WaTaKiD Note Added: 0012580
2015-06-07 16:02 WaTaKiD Status needs testing => resolved
2015-06-07 16:02 WaTaKiD Resolution open => fixed
2015-06-07 16:02 WaTaKiD Fixed in Version => 2.1
2015-06-07 16:02 WaTaKiD Description Updated View Revisions
2018-09-30 21:38 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker