MantisBT - Zandronum
View Issue Details
0002186Zandronum[All Projects] Bugpublic2015-04-12 07:212018-09-30 21:38
Edward-san 
Edward-san 
normalminorhave not tried
closedfixed 
 
2.12.1 
0002186: Inconsistent demo behavior of light strobe special
I noticed that in p_spec.cpp, in function P_SpawnSpecials, the 'sync strobe fast' case has a different demo handling than the other light cases:


case dLight_StrobeFastSync:
    // SYNC STROBE FAST
    // [BC] In client mode, light specials may have been shut off by the server.
    // Therefore, we can't spawn them on our end.
    if ( NETWORK_GetState( ) != NETSTATE_CLIENT )
        new DStrobe (sector, STROBEBRIGHT, FASTDARK, true);
    sector->special &= 0xff00;
    break;


It doesn't have the 'CLIENTDEMO_IsPlaying() == false' check, but I don't know if this can be an issue.
No tags attached.
? lightstrobefastsync.wad (816) 2015-04-13 20:46
/tracker/file_download.php?file_id=1459&type=bug
? lightstrobefastsync_demo.cld (5,497) 2015-04-13 20:47
/tracker/file_download.php?file_id=1460&type=bug
Issue History
2015-04-12 07:21Edward-sanNew Issue
2015-04-13 20:46Edward-sanFile Added: lightstrobefastsync.wad
2015-04-13 20:47Edward-sanFile Added: lightstrobefastsync_demo.cld
2015-04-13 20:47Edward-sanNote Added: 0012101
2015-04-13 20:48Edward-sanAssigned To => Edward-san
2015-04-13 20:48Edward-sanStatusnew => assigned
2015-04-13 21:09Edward-sanNote Added: 0012103
2015-04-13 21:09Edward-sanStatusassigned => needs review
2015-04-14 15:02cobaltStatusneeds review => needs testing
2015-04-14 15:02cobaltTarget Version => 2.1
2015-04-14 15:02cobaltDescription Updatedbug_revision_view_page.php?rev_id=6962#r6962
2015-04-14 15:02cobaltNote Added: 0012108
2015-06-07 16:02WaTaKiDNote Added: 0012580
2015-06-07 16:02WaTaKiDStatusneeds testing => resolved
2015-06-07 16:02WaTaKiDResolutionopen => fixed
2015-06-07 16:02WaTaKiDFixed in Version => 2.1
2015-06-07 16:02WaTaKiDDescription Updatedbug_revision_view_page.php?rev_id=7295#r7295
2018-09-30 21:38Blzut3Statusresolved => closed

Notes
(0012101)
Edward-san   
2015-04-13 20:47   
Yeah, confirmed with the example wad and the demo I've attached.
(0012103)
Edward-san   
2015-04-13 21:09   
Fixed:'https://bitbucket.org/crimsondusk/zandronum-sandbox/commits/7a4963e45cd4fa66f98e5857c0fbf54755cdb08c [^]'
(0012108)
cobalt   
2015-04-14 15:02   
Issue addressed by commit 7a4963e4: - Fixed: the 'light fast strobe in sync' sector special would visually desync while playing a demo (addresses 2186).
Committed by edward_san [edward-san] on Monday 13 April 2015 23:04:43

Changes in files:
 docs/zandronum-history.txt | 1 +
 src/p_spec.cpp | 2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)
(0012580)
WaTaKiD   
2015-06-07 16:02   
this issue seems fixed