Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002137Zandronum[All Projects] Suggestionpublic2015-03-26 07:452018-09-30 22:12
ReporterDark-Assassin 
Assigned ToDusk 
PrioritynoneSeverityfeatureReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version3.0Fixed in Version3.0 
Summary0002137: Rune System Change
DescriptionAt the moment, the rune system strictly uses native inventory actors.
If this were to change, it could open the system up quite a lot.

Steps To ReproduceRemove the actor Rune and all child actors.

Change Rune.Type from RuneGiver to actually use Inventory/Powerup actors rather than referencing the native Rune actors.

Set the default undefined duration to as infinite as possible.
However, allow any duration for timed runes.

Add Rune.Slot 0-255, for the possibility of multiple runes.
Picking up other Runes using the same slot will cancel out any other in that slot.
This isn't necessarily needed.
Attached Files

- Relationships
parent of 0000557closedDusk Make powerup versions of spread and reflection runes 

-  Notes
User avatar (0011898)
arkore (reporter)
2015-03-26 11:42

 I support this. I also think this will resolve the quirkiness of the runes when switching from one map to another in a hub.
User avatar (0011899)
Dusk (developer)
2015-03-27 11:06

 Rune.Slot is a definite No, that is too specific for the engine IMO. I agree with the feature otherwise though and I'm interested in implementing it in the future.
User avatar (0012222)
Dusk (developer)
2015-05-09 22:31

 I actually went and did this:
'https://bitbucket.org/crimsondusk/zandronum-sandbox/commits/13cd37099f9e [^]'
Build:'https://dl.dropboxusercontent.com/u/66055976/2015/builds/zandronum-sandbox-runes-150509-2214M.7z [^]'
User avatar (0012226)
Dark-Assassin (administrator)
2015-05-10 07:16

 Cool. I'll give it a run either late Monday or early Tuesday.
User avatar (0013233)
cobalt (updater)
2015-08-18 21:09

 Issue addressed by commit 2023c02646a0: Generalized the rune system (addresses 2137): - Runes are all now actually powerups. - RuneGiver is now a PowerupGiver derivative with some special code to handle runes. - Rune.Type is now effectively an alias of Powerup.Type. This means that spread, prosperity and reflection may now be used as powerups too, and any powerup can be turned into a rune.
Committed by Teemu Piippo [Dusk] on Tuesday 18 August 2015 20:28:38

Changes in files:

 docs/zandronum-history.txt | 1 +
 src/actor.h | 3 +
 src/cl_main.cpp | 11 +-
 src/g_doom/doom_sbar.cpp | 4 +-
 src/g_shared/a_artifacts.cpp | 605 ++++++++++----------------------------------------------------------------------------------------
 src/g_shared/a_artifacts.h | 121 +++----------------
 src/p_mobj.cpp | 4 +-
 src/sv_commands.cpp | 6 +-
 src/sv_main.cpp | 18 +-
 src/thingdef/thingdef_properties.cpp | 5 +-
 wadsrc/static/actors/shared/inventory.txt | 25 ++++
 wadsrc/static/decorate.txt | 1 -
 wadsrc_st/static/actors/skulltagrunes.txt | 50 +++-----
 wadsrc_st/static/decorate.txt | 1 +
 wadsrc_st/static/sprites/drara0.png | 0
 wadsrc_st/static/sprites/drarb0.png | 0
 wadsrc_st/static/sprites/drarc0.png | 0
 wadsrc_st/static/sprites/drard0.png | 0
 wadsrc_st/static/sprites/hasra0.png | 0
 wadsrc_st/static/sprites/hasrb0.png | 0
 wadsrc_st/static/sprites/hasrc0.png | 0
 wadsrc_st/static/sprites/hasrd0.png | 0
 wadsrc_st/static/sprites/hijra0.png | 0
 wadsrc_st/static/sprites/hijrb0.png | 0
 wadsrc_st/static/sprites/hijrc0.png | 0
 wadsrc_st/static/sprites/hijrd0.png | 0
 wadsrc_st/static/sprites/prsra0.png | 0
 wadsrc_st/static/sprites/prsrb0.png | 0
 wadsrc_st/static/sprites/prsrc0.png | 0
 wadsrc_st/static/sprites/prsrd0.png | 0
 wadsrc_st/static/sprites/prsre0.png | 0
 wadsrc_st/static/sprites/ragra0.png | 0
 wadsrc_st/static/sprites/ragrb0.png | 0
 wadsrc_st/static/sprites/ragrc0.png | 0
 wadsrc_st/static/sprites/ragrd0.png | 0
 wadsrc_st/static/sprites/ragre0.png | 0
 wadsrc_st/static/sprites/ragrf0.png | 0
 wadsrc_st/static/sprites/ragrg0.png | 0
 wadsrc_st/static/sprites/ragrh0.png | 0
 wadsrc_st/static/sprites/refra0.png | 0
 wadsrc_st/static/sprites/refrb0.png | 0
 wadsrc_st/static/sprites/regra0.png | 0
 wadsrc_st/static/sprites/regrb0.png | 0
 wadsrc_st/static/sprites/resra0.png | 0
 wadsrc_st/static/sprites/resrb0.png | 0
 wadsrc_st/static/sprites/resrc0.png | 0
 wadsrc_st/static/sprites/resrd0.png | 0
 wadsrc_st/static/sprites/resre0.png | 0
 wadsrc_st/static/sprites/resrf0.png | 0
 wadsrc_st/static/sprites/resrg0.png | 0
 wadsrc_st/static/sprites/resrh0.png | 0
 wadsrc_st/static/sprites/sprra0.png | 0
 wadsrc_st/static/sprites/sprrb0.png | 0
 wadsrc_st/static/sprites/sprrc0.png | 0
 wadsrc_st/static/sprites/sprrd0.png | 0
 wadsrc_st/static/sprites/strra0.png | 0
 wadsrc_st/static/sprites/strrb0.png | 0
 wadsrc_st/static/sprites/strrc0.png | 0
 wadsrc_st/static/sprites/strrd0.png | 0
 wadsrc_st/static/sprites/strre0.png | 0
 60 files changed, 170 insertions(+), 685 deletions(-)
User avatar (0013234)
Ivan (reporter)
2015-08-18 22:42

 I suppose this only covers the system and not certain runes specifically, right? Because, the reflection rune remains impossible to utilize properly. (Can't tweak values, can't tell who the owner is sometimes (I recall that being a problem, or something along those lines)) So, what about exposing the workings of that specific rune?
User avatar (0014022)
Ru5tK1ng (updater)
2015-12-25 21:47

 I was able to create power up versions of Spread, Reflection and Prosperity. I also made every power up into a rune except for Minotaur (doesn't really make sense as one) and Morph (looks to be broken).

@Ivan

This ticket primarily deals with how each rune and power ups are utilized and not necessarily their behavior. I'm guessing the reflection rune specifics might be better served in a separate ticket.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: ZzZombo Dark-Assassin Monsterovich DrinkyBird
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2015-03-26 07:45 Dark-Assassin New Issue
2015-03-26 11:42 arkore Note Added: 0011898
2015-03-27 11:05 Dusk Relationship added related to 0000557
2015-03-27 11:06 Dusk Note Added: 0011899
2015-03-27 11:06 Dusk Assigned To => Dusk
2015-03-27 11:06 Dusk Status new => acknowledged
2015-03-27 11:06 Dusk Relationship replaced parent of 0000557
2015-03-27 11:08 Dusk Target Version => 2.1
2015-04-25 21:04 Dusk Target Version 2.1 => 3.0
2015-05-09 22:31 Dusk Note Added: 0012222
2015-05-09 22:31 Dusk Status acknowledged => needs review
2015-05-10 07:16 Dark-Assassin Note Added: 0012226
2015-08-18 21:09 cobalt Status needs review => needs testing
2015-08-18 21:09 cobalt Description Updated View Revisions
2015-08-18 21:09 cobalt Steps to Reproduce Updated View Revisions
2015-08-18 21:09 cobalt Note Added: 0013233
2015-08-18 22:42 Ivan Note Added: 0013234
2015-12-25 21:47 Ru5tK1ng Note Added: 0014022
2016-01-31 23:31 Ru5tK1ng Status needs testing => resolved
2016-01-31 23:31 Ru5tK1ng Resolution open => fixed
2016-01-31 23:31 Ru5tK1ng Fixed in Version => 3.0
2016-01-31 23:31 Ru5tK1ng Description Updated View Revisions
2016-01-31 23:31 Ru5tK1ng Steps to Reproduce Updated View Revisions
2018-09-30 22:12 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker