0002055: cl_announcepickups doesn't work at all online.

Chat on our Discord Server Get the latest version: 3.2.1
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0002055

Zandronum

[All Projects] Bug

public

2015-01-05 18:18

2018-10-01 00:04

Reporter

Leonard

Assigned To

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

Microsoft

Windows

OS Version

XP/Vista/7

Product Version

1.3

Target Version

1.4

Fixed in Version

1.4

Summary

0002055: cl_announcepickups doesn't work at all online.

Description

The current implementation only works offline.

Additional Information

'http://zandronum.com/tracker/view.php?id=67 [^]'
'https://bitbucket.org/Torr_Samaho/zandronum-stable/commits/d1c059ef8372a24a752f305b5704002562f51dff [^]'

It doesn't work online because the current implementation only covers AInventory::Touch which is never executed in clients.

Attached Files

Relationships

Notes
(0011288) Leonard (developer) 2015-01-05 18:21	'https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-request/126/fixed-cvar-cl_announcepickups-didnt-work/diff [^]'

(0011300) cobalt (updater) 2015-01-05 20:48	Issue addressed by commit 91b4201cabc9: Fixed: CVAR cl_announcepickups didn't work in certain cases (fixes 2055). Committed by Leonard on Monday 05 January 2015 19:05:57 Changes in files: docs/zandronum-history.txt \| 1 + src/announcer.cpp \| 4 ++++ src/announcer.h \| 1 + src/cl_main.cpp \| 2 +- src/g_doom/a_doomartifacts.cpp \| 2 +- src/g_shared/a_pickups.cpp \| 4 ---- src/m_cheat.cpp \| 2 +- 7 files changed, 9 insertions(+), 7 deletions(-)

(0011302) WaTaKiD (updater) 2015-01-05 22:45	after testing with 1.4-r150105-1805, issue seems fixed

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2015-01-05 18:18	Leonard	New Issue
2015-01-05 18:21	Leonard	Note Added: 0011288
2015-01-05 19:38	Edward-san	Assigned To	=> Edward-san
2015-01-05 19:38	Edward-san	Status	new => assigned
2015-01-05 19:38	Edward-san	Assigned To	Edward-san =>
2015-01-05 19:40	Edward-san	Status	assigned => needs review
2015-01-05 20:47	cobalt	Status	needs review => needs testing
2015-01-05 20:47	cobalt	Target Version	=> 1.4
2015-01-05 20:47	cobalt	Additional Information Updated	View Revisions
2015-01-05 20:48	cobalt	Note Added: 0011300
2015-01-05 22:45	WaTaKiD	Note Added: 0011302
2015-01-08 14:36	Arco	Status	needs testing => resolved
2015-01-08 14:36	Arco	Resolution	open => fixed
2015-01-08 14:36	Arco	Fixed in Version	=> 1.4
2015-01-08 14:36	Arco	Additional Information Updated	View Revisions
2018-10-01 00:04	Blzut3	Status	resolved => closed

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.