MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002055Zandronum[All Projects] Bugpublic2015-01-05 18:182018-10-01 00:04
ReporterLeonard 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version1.3 
Target Version1.4Fixed in Version1.4 
Summary0002055: cl_announcepickups doesn't work at all online.
DescriptionThe current implementation only works offline.
Steps To Reproduce
Additional Information'http://zandronum.com/tracker/view.php?id=67 [^]'
'https://bitbucket.org/Torr_Samaho/zandronum-stable/commits/d1c059ef8372a24a752f305b5704002562f51dff [^]'

It doesn't work online because the current implementation only covers AInventory::Touch which is never executed in clients.
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-01-05 18:18LeonardNew Issue
2015-01-05 18:21LeonardNote Added: 0011288
2015-01-05 19:38Edward-sanAssigned To => Edward-san
2015-01-05 19:38Edward-sanStatusnew => assigned
2015-01-05 19:38Edward-sanAssigned ToEdward-san =>
2015-01-05 19:40Edward-sanStatusassigned => needs review
2015-01-05 20:47cobaltStatusneeds review => needs testing
2015-01-05 20:47cobaltTarget Version => 1.4
2015-01-05 20:47cobaltAdditional Information Updatedbug_revision_view_page.php?rev_id=6331#r6331
2015-01-05 20:48cobaltNote Added: 0011300
2015-01-05 22:45WaTaKiDNote Added: 0011302
2015-01-08 14:36ArcoStatusneeds testing => resolved
2015-01-08 14:36ArcoResolutionopen => fixed
2015-01-08 14:36ArcoFixed in Version => 1.4
2015-01-08 14:36ArcoAdditional Information Updatedbug_revision_view_page.php?rev_id=6352#r6352
2018-10-01 00:04Blzut3Statusresolved => closed

Notes
(0011288)
Leonard   
2015-01-05 18:21   
'https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-request/126/fixed-cvar-cl_announcepickups-didnt-work/diff [^]'
(0011300)
cobalt   
2015-01-05 20:48   
Issue addressed by commit 91b4201cabc9: Fixed: CVAR cl_announcepickups didn't work in certain cases (fixes 2055).
Committed by Leonard on Monday 05 January 2015 19:05:57

Changes in files:
 docs/zandronum-history.txt | 1 +
 src/announcer.cpp | 4 ++++
 src/announcer.h | 1 +
 src/cl_main.cpp | 2 +-
 src/g_doom/a_doomartifacts.cpp | 2 +-
 src/g_shared/a_pickups.cpp | 4 ----
 src/m_cheat.cpp | 2 +-
 7 files changed, 9 insertions(+), 7 deletions(-)
(0011302)
WaTaKiD   
2015-01-05 22:45   
after testing with 1.4-r150105-1805, issue seems fixed