0001916: Light effects from script doesn't stop after map reset - MantisBT

Zandronum

Chat on our Discord Server Get the latest version: 3.2.1
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

ID

Project

Category

View Status

Date Submitted

Last Update

0001916

Zandronum

[All Projects] Bug

public

2014-08-11 00:17

2018-10-01 00:08

Reporter

thomas

Assigned To

Torr Samaho

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

Microsoft

OS

Windows

OS Version

XP/Vista/7

Product Version

1.2

Target Version

1.4

Fixed in Version

1.4

Summary

0001916: Light effects from script doesn't stop after map reset

Description

When you call light_glow from a script to make a glowing light on a sector and the map is reset, the light effect remains.

Steps To Reproduce

Start example map in survival. hit switch. Check that the center of the room is glowing. Die.

Additional Information

I only tested this with light_glow, but it is likely that this also happens with other effects.

Also happens in the latest 2.0 build.

lighttest.wad [^] (4,140 bytes) 2014-08-11 00:17

lighttest2.wad [^] (4,153 bytes) 2014-10-12 14:14

Relationships

Notes
(0010331) Torr Samaho (administrator) 2014-10-04 16:04	This should fix the issue. Can somebody test this online and offline, and also check whether lighting effects spawned directly by the map on startup are not reset?

(0010338) Arco (updater) 2014-10-05 20:01	Works correctly on and offline in v2.0 r141001-1429M. Lighting effects spawned from the map are not affected.

(0010540) Torr Samaho (administrator) 2014-10-12 14:19	I cleaned and committed the fix to 1.4. Please confirm that it's still working.

(0010541) cobalt (updater) 2014-10-12 14:23	Issue addressed by commit 0fe01f1d6e11: Fixed: Light effects created by scripts weren't removed during a map reset. This addresses 1916. Committed by Benjamin Berkels [Torr Samaho] on Sunday 12 October 2014 16:18:15 Changes in files: docs/zandronum-history.txt \| 1 + src/g_game.cpp \| 15 +++++++++++++++ src/p_lights.cpp \| 7 +++++++ src/p_spec.h \| 3 +++ 4 files changed, 26 insertions(+), 0 deletions(-)

(0010601) StrikerMan780 (reporter) 2014-10-15 22:15 edited on: 2014-10-15 22:16	Lighttest2.wad confirmed to reset the glowing light after map reset in survival using this build:'http://l.xd.cm:8080/builders/windows-x86-stable/builds/18 [^]' (I'm on a testing rampage it seems.)

(0010608) Torr Samaho (administrator) 2014-10-16 05:56	Thanks for checking!

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2014-08-11 00:17	thomas	New Issue
2014-08-11 00:17	thomas	File Added: lighttest.wad
2014-10-04 15:22	Torr Samaho	Assigned To	=> Torr Samaho
2014-10-04 15:22	Torr Samaho	Status	new => assigned
2014-10-04 16:04	Torr Samaho	Note Added: 0010331
2014-10-04 16:04	Torr Samaho	Status	assigned => needs testing
2014-10-05 20:01	Arco	Note Added: 0010338
2014-10-05 20:01	Arco	Status	needs testing => resolved
2014-10-05 20:01	Arco	Resolution	open => fixed
2014-10-05 20:01	Arco	Fixed in Version	=> 2.0
2014-10-12 14:14	Torr Samaho	File Added: lighttest2.wad
2014-10-12 14:19	Torr Samaho	Status	resolved => needs testing
2014-10-12 14:19	Torr Samaho	Fixed in Version	2.0 =>
2014-10-12 14:19	Torr Samaho	Target Version	=> 1.4
2014-10-12 14:19	Torr Samaho	Note Added: 0010540
2014-10-12 14:23	cobalt	Note Added: 0010541
2014-10-15 22:15	StrikerMan780	Note Added: 0010601
2014-10-15 22:16	StrikerMan780	Note Edited: 0010601	View Revisions
2014-10-16 05:56	Torr Samaho	Note Added: 0010608
2014-10-16 05:56	Torr Samaho	Status	needs testing => resolved
2014-10-16 05:56	Torr Samaho	Fixed in Version	=> 1.4
2018-10-01 00:08	Blzut3	Status	resolved => closed

Questions or other issues? Contact Us.

Links

Copyright © 2012-2025, Torr Samaho & Zandronum Team.

Doom and Doom II are the property of id Software.

Copyright © 2000 - 2025 MantisBT Team