MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001916Zandronum[All Projects] Bugpublic2014-08-11 00:172018-10-01 00:08
Reporterthomas 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version1.2 
Target Version1.4Fixed in Version1.4 
Summary0001916: Light effects from script doesn't stop after map reset
DescriptionWhen you call light_glow from a script to make a glowing light on a sector and the map is reset, the light effect remains.
Steps To ReproduceStart example map in survival. hit switch. Check that the center of the room is glowing. Die.
Additional InformationI only tested this with light_glow, but it is likely that this also happens with other effects.

Also happens in the latest 2.0 build.
TagsNo tags attached.
Relationships
Attached Files? lighttest.wad (4,140) 2014-08-11 00:17
/tracker/file_download.php?file_id=1282&type=bug
? lighttest2.wad (4,153) 2014-10-12 14:14
/tracker/file_download.php?file_id=1308&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-08-11 00:17thomasNew Issue
2014-08-11 00:17thomasFile Added: lighttest.wad
2014-10-04 15:22Torr SamahoAssigned To => Torr Samaho
2014-10-04 15:22Torr SamahoStatusnew => assigned
2014-10-04 16:04Torr SamahoNote Added: 0010331
2014-10-04 16:04Torr SamahoStatusassigned => needs testing
2014-10-05 20:01ArcoNote Added: 0010338
2014-10-05 20:01ArcoStatusneeds testing => resolved
2014-10-05 20:01ArcoResolutionopen => fixed
2014-10-05 20:01ArcoFixed in Version => 2.0
2014-10-12 14:14Torr SamahoFile Added: lighttest2.wad
2014-10-12 14:19Torr SamahoStatusresolved => needs testing
2014-10-12 14:19Torr SamahoFixed in Version2.0 =>
2014-10-12 14:19Torr SamahoTarget Version => 1.4
2014-10-12 14:19Torr SamahoNote Added: 0010540
2014-10-12 14:23cobaltNote Added: 0010541
2014-10-15 22:15StrikerMan780Note Added: 0010601
2014-10-15 22:16StrikerMan780Note Edited: 0010601bug_revision_view_page.php?bugnote_id=10601#r5772
2014-10-16 05:56Torr SamahoNote Added: 0010608
2014-10-16 05:56Torr SamahoStatusneeds testing => resolved
2014-10-16 05:56Torr SamahoFixed in Version => 1.4
2018-10-01 00:08Blzut3Statusresolved => closed

Notes
(0010331)
Torr Samaho   
2014-10-04 16:04   
This should fix the issue. Can somebody test this online and offline, and also check whether lighting effects spawned directly by the map on startup are not reset?
(0010338)
Arco   
2014-10-05 20:01   
Works correctly on and offline in v2.0 r141001-1429M. Lighting effects spawned from the map are not affected.
(0010540)
Torr Samaho   
2014-10-12 14:19   
I cleaned and committed the fix to 1.4. Please confirm that it's still working.
(0010541)
cobalt   
2014-10-12 14:23   
Issue addressed by commit 0fe01f1d6e11: Fixed: Light effects created by scripts weren't removed during a map reset. This addresses 1916.
Committed by Benjamin Berkels [Torr Samaho] on Sunday 12 October 2014 16:18:15

Changes in files:
 docs/zandronum-history.txt | 1 +
 src/g_game.cpp | 15 +++++++++++++++
 src/p_lights.cpp | 7 +++++++
 src/p_spec.h | 3 +++
 4 files changed, 26 insertions(+), 0 deletions(-)
(0010601)
StrikerMan780   
2014-10-15 22:15   
(edited on: 2014-10-15 22:16)
Lighttest2.wad confirmed to reset the glowing light after map reset in survival using this build:'http://l.xd.cm:8080/builders/windows-x86-stable/builds/18 [^]'

(I'm on a testing rampage it seems.)
(0010608)
Torr Samaho   
2014-10-16 05:56   
Thanks for checking!