Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001809Zandronum[All Projects] Bugpublic2014-06-01 16:362018-09-30 22:23
ReporterCatastrophe 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version1.2 
Target Version3.0Fixed in Version3.0 
Summary0001809: Adding +NOSKIN to a playerclass breaks SkinInfo's crouchsprite
DescriptionSimple, in all out war I found out that adding +NOSKIN to the default player class makes your player sprite go squish instead of actually changing to the crouchsprite=. Odd thing is that skin= will still work.
Steps To ReproduceDefine a skin via skininfo with a crouch sprite.

Add weapon.preferredskin to a weapon and set it to use the skin you just defined.

Test to see if the crouch sprite works. (it should)

Now, go to your default playerclass and add +NOSKIN

Test again, this time crouch sprite won't show up and the sprite= will just go squish whenever you try to crouch.
Attached Files7z file icon Mirror.7z [^] (5,236 bytes) 2014-10-25 09:56

- Relationships

-  Notes
User avatar (0008832)
Catastrophe (reporter)
2014-06-01 16:51

 Also happens in 1.2.1
User avatar (0009815)
Catastrophe (reporter)
2014-07-01 08:06

 Update, it seems that setting skins off on the multiplayer settings also removes crouch sprites.
User avatar (0009830)
Esum (reporter)
2014-07-03 20:09

 What about fixing it this way:'https://bitbucket.org/esum/zandronum-stable/commits/5a6aa19fe2d511b0b51697f2552646254f0360f9 [^]'
(I don't do additional checks because if the condition is true the other checks must have been done earlier)
User avatar (0009837)
Catastrophe (reporter)
2014-07-04 17:58

 If that is the fix I received in IRC, then it worked for me.
User avatar (0009838)
Esum (reporter)
2014-07-04 19:22

 It is.
User avatar (0009949)
Torr Samaho (administrator)
2014-07-12 15:48

 I think it would be better to add the extra checks one block above, i.e.

                // [BB] PreferredSkin overrides NOSKIN.
                else if ( ( !(player->mo->flags4 & MF4_NOSKIN) || ( player->ReadyWeapon && ( player->ReadyWeapon->PreferredSkin != NAME_None ) ) ) &&
                        (mo->sprite == skins[lSkin].sprite ||
                         mo->sprite == skins[lSkin].crouchsprite))
                {
                    crouchspriteno = skins[lSkin].crouchsprite;
                }

Since there is no minimal example wad, I can't test though whether this works.
User avatar (0009952)
Catastrophe (reporter)
2014-07-12 17:26

 Not really minimal, but this should demonstrate it properly:'https://www.dropbox.com/s/7wjt0cw3793gp69/aow2X_r8test5.pk3 [^]'

map:'https://www.dropbox.com/s/o7w5yoxdlkesrsd/Mirror.wad [^]'

Go to map mirror, do give weapons, pick a weapon and try crouching, you'll notice that the sprite gets squished. However, on esums build it appears to fix the squishing behavior.
User avatar (0010679)
Torr Samaho (administrator)
2014-10-25 10:20

 Since I got no feedback to 0001809:0009949, I went ahead and added the altered patch.
User avatar (0013284)
Ru5tK1ng (updater)
2015-08-26 02:32

 After getting an updated test wad, I tested on my server and I can confirm the crouch sprites now work in 3.0-alpha-150819-2351.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2014-06-01 16:36 Catastrophe New Issue
2014-06-01 16:51 Catastrophe Note Added: 0008832
2014-06-15 16:43 Watermelon Status new => confirmed
2014-07-01 08:06 Catastrophe Note Added: 0009815
2014-07-03 20:09 Esum Note Added: 0009830
2014-07-04 00:30 Dusk Status confirmed => needs review
2014-07-04 17:58 Catastrophe Note Added: 0009837
2014-07-04 19:22 Esum Note Added: 0009838
2014-07-12 15:48 Torr Samaho Note Added: 0009949
2014-07-12 17:26 Catastrophe Note Added: 0009952
2014-10-25 09:56 Torr Samaho File Added: Mirror.7z
2014-10-25 10:20 Torr Samaho Note Added: 0010679
2014-10-25 10:20 Torr Samaho Assigned To => Torr Samaho
2014-10-25 10:20 Torr Samaho Status needs review => needs testing
2015-08-25 22:47 Ru5tK1ng Note Added: 0013274
2015-08-26 02:31 Ru5tK1ng Note Deleted: 0013274
2015-08-26 02:32 Ru5tK1ng Note Added: 0013284
2015-08-28 23:00 Dusk Status needs testing => resolved
2015-08-28 23:00 Dusk Fixed in Version => 3.0
2015-08-28 23:00 Dusk Resolution open => fixed
2015-08-28 23:00 Dusk Target Version => 3.0
2018-09-30 22:23 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker