MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001809Zandronum[All Projects] Bugpublic2014-06-01 16:362018-09-30 22:23
ReporterCatastrophe 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version1.2 
Target Version3.0Fixed in Version3.0 
Summary0001809: Adding +NOSKIN to a playerclass breaks SkinInfo's crouchsprite
DescriptionSimple, in all out war I found out that adding +NOSKIN to the default player class makes your player sprite go squish instead of actually changing to the crouchsprite=. Odd thing is that skin= will still work.
Steps To ReproduceDefine a skin via skininfo with a crouch sprite.

Add weapon.preferredskin to a weapon and set it to use the skin you just defined.

Test to see if the crouch sprite works. (it should)

Now, go to your default playerclass and add +NOSKIN

Test again, this time crouch sprite won't show up and the sprite= will just go squish whenever you try to crouch.
Additional Information
TagsNo tags attached.
Relationships
Attached Files7z Mirror.7z (5,236) 2014-10-25 09:56
/tracker/file_download.php?file_id=1315&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-06-01 16:36CatastropheNew Issue
2014-06-01 16:51CatastropheNote Added: 0008832
2014-06-15 16:43WatermelonStatusnew => confirmed
2014-07-01 08:06CatastropheNote Added: 0009815
2014-07-03 20:09EsumNote Added: 0009830
2014-07-04 00:30DuskStatusconfirmed => needs review
2014-07-04 17:58CatastropheNote Added: 0009837
2014-07-04 19:22EsumNote Added: 0009838
2014-07-12 15:48Torr SamahoNote Added: 0009949
2014-07-12 17:26CatastropheNote Added: 0009952
2014-10-25 09:56Torr SamahoFile Added: Mirror.7z
2014-10-25 10:20Torr SamahoNote Added: 0010679
2014-10-25 10:20Torr SamahoAssigned To => Torr Samaho
2014-10-25 10:20Torr SamahoStatusneeds review => needs testing
2015-08-25 22:47Ru5tK1ngNote Added: 0013274
2015-08-26 02:31Ru5tK1ngNote Deleted: 0013274
2015-08-26 02:32Ru5tK1ngNote Added: 0013284
2015-08-28 23:00DuskStatusneeds testing => resolved
2015-08-28 23:00DuskFixed in Version => 3.0
2015-08-28 23:00DuskResolutionopen => fixed
2015-08-28 23:00DuskTarget Version => 3.0
2018-09-30 22:23Blzut3Statusresolved => closed

Notes
(0008832)
Catastrophe   
2014-06-01 16:51   
Also happens in 1.2.1
(0009815)
Catastrophe   
2014-07-01 08:06   
Update, it seems that setting skins off on the multiplayer settings also removes crouch sprites.
(0009830)
Esum   
2014-07-03 20:09   
What about fixing it this way:'https://bitbucket.org/esum/zandronum-stable/commits/5a6aa19fe2d511b0b51697f2552646254f0360f9 [^]'
(I don't do additional checks because if the condition is true the other checks must have been done earlier)
(0009837)
Catastrophe   
2014-07-04 17:58   
If that is the fix I received in IRC, then it worked for me.
(0009838)
Esum   
2014-07-04 19:22   
It is.
(0009949)
Torr Samaho   
2014-07-12 15:48   
I think it would be better to add the extra checks one block above, i.e.

                // [BB] PreferredSkin overrides NOSKIN.
                else if ( ( !(player->mo->flags4 & MF4_NOSKIN) || ( player->ReadyWeapon && ( player->ReadyWeapon->PreferredSkin != NAME_None ) ) ) &&
                        (mo->sprite == skins[lSkin].sprite ||
                         mo->sprite == skins[lSkin].crouchsprite))
                {
                    crouchspriteno = skins[lSkin].crouchsprite;
                }

Since there is no minimal example wad, I can't test though whether this works.
(0009952)
Catastrophe   
2014-07-12 17:26   
Not really minimal, but this should demonstrate it properly:'https://www.dropbox.com/s/7wjt0cw3793gp69/aow2X_r8test5.pk3 [^]'

map:'https://www.dropbox.com/s/o7w5yoxdlkesrsd/Mirror.wad [^]'

Go to map mirror, do give weapons, pick a weapon and try crouching, you'll notice that the sprite gets squished. However, on esums build it appears to fix the squishing behavior.
(0010679)
Torr Samaho   
2014-10-25 10:20   
Since I got no feedback to 0001809:0009949, I went ahead and added the altered patch.
(0013284)
Ru5tK1ng   
2015-08-26 02:32   
After getting an updated test wad, I tested on my server and I can confirm the crouch sprites now work in 3.0-alpha-150819-2351.