Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001766Doomseeker[All Projects] Suggestionpublic2014-03-31 22:072018-09-29 14:45
ReporterZalewa 
Assigned ToZalewa 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version0.12 BetaFixed in Version0.12 Beta 
Summary0001766: Unify method of WAD finding for server list and server joins
DescriptionThis is more of an internal issue, as I don't think there's actually any case where any WAD path discrepancy can present itself right now.

Currently tooltips use a different method of WAD finding for path display when "show me locations of my WADs" checkbox is enabled, and a different one for when the user actually joins the game. This may produce some discrepancies where the WADs which were shown as 'MISSING' are now magically found, or where WADs are loaded from different location than Doomseeker previously displayed.

In short:
Tooltips should just use PathFinder from GameClientRunner.
Attached Files

- Relationships

-  Notes
User avatar (0008473)
Zalewa (developer)
2014-04-01 17:39
edited on: 2014-04-01 18:57

 This isn't actually a bit more complicated than I initially thought.

The discrepancy was put in intentionally, sort of, as the previous setup collided with Skulltag testing executables. I'll start by reviving the 'pluginapi' branch and modifying the testing binaries installation procedure so that it won't get fired everytime we try to call ExeFile::pathToExe(), but rather there will be a separate ExeFile::install() method that will do the trick.
User avatar (0008474)
Zalewa (developer)
2014-04-01 19:12
edited on: 2014-04-01 19:12

 Split committed. I think the installation procedure within Zandronum plugin can be somewhat improved, as the path retrieval still performs some write operations to the file system, but if I didn't miss anything it shouldn't trigger any message boxes or other pop-ups anymore.

I think that in distant future this can be exploited to support automatic installation of source-ports, but that's probably not what we should focus on...
User avatar (0008475)
Zalewa (developer)
2014-04-02 17:01

 Change committed to pluginapi branch: link.

IWAD and PWADs tooltips will need some testing, as well as game joining. I intentionally left PathFinder for demo loading as it is right now. The change only affected WAD finding related to server joins.
User avatar (0008632)
Zalewa (developer)
2014-04-23 18:36

 Change available on beta update channel. Please test if IWAD and WADS columns tooltips work correctly and if there aren't any weird bugs when trying to join servers that host different WADs.
User avatar (0008778)
Zalewa (developer)
2014-05-11 16:50

 Resolving due to release of version 0.12 where this is implemented.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2014-03-31 22:07 Zalewa New Issue
2014-04-01 17:15 Zalewa Assigned To => Zalewa
2014-04-01 17:15 Zalewa Status new => assigned
2014-04-01 17:39 Zalewa Note Added: 0008473
2014-04-01 18:57 Zalewa Note Edited: 0008473 View Revisions
2014-04-01 19:12 Zalewa Note Added: 0008474
2014-04-01 19:12 Zalewa Note Edited: 0008474 View Revisions
2014-04-02 17:01 Zalewa Note Added: 0008475
2014-04-02 17:01 Zalewa Status assigned => needs review
2014-04-06 12:25 Zalewa Target Version => 0.12 Beta
2014-04-23 18:36 Zalewa Note Added: 0008632
2014-04-23 18:36 Zalewa Status needs review => needs testing
2014-05-11 16:50 Zalewa Note Added: 0008778
2014-05-11 16:50 Zalewa Status needs testing => resolved
2014-05-11 16:50 Zalewa Fixed in Version => 0.12 Beta
2014-05-11 16:50 Zalewa Resolution open => fixed
2018-09-29 14:45 WubTheCaptain Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker