MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001766Doomseeker[All Projects] Suggestionpublic2014-03-31 22:072018-09-29 14:45
ReporterZalewa 
Assigned ToZalewa 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version0.12 BetaFixed in Version0.12 Beta 
Summary0001766: Unify method of WAD finding for server list and server joins
DescriptionThis is more of an internal issue, as I don't think there's actually any case where any WAD path discrepancy can present itself right now.

Currently tooltips use a different method of WAD finding for path display when "show me locations of my WADs" checkbox is enabled, and a different one for when the user actually joins the game. This may produce some discrepancies where the WADs which were shown as 'MISSING' are now magically found, or where WADs are loaded from different location than Doomseeker previously displayed.

In short:
Tooltips should just use PathFinder from GameClientRunner.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-03-31 22:07ZalewaNew Issue
2014-04-01 17:15ZalewaAssigned To => Zalewa
2014-04-01 17:15ZalewaStatusnew => assigned
2014-04-01 17:39ZalewaNote Added: 0008473
2014-04-01 18:57ZalewaNote Edited: 0008473bug_revision_view_page.php?bugnote_id=8473#r4593
2014-04-01 19:12ZalewaNote Added: 0008474
2014-04-01 19:12ZalewaNote Edited: 0008474bug_revision_view_page.php?bugnote_id=8474#r4595
2014-04-02 17:01ZalewaNote Added: 0008475
2014-04-02 17:01ZalewaStatusassigned => needs review
2014-04-06 12:25ZalewaTarget Version => 0.12 Beta
2014-04-23 18:36ZalewaNote Added: 0008632
2014-04-23 18:36ZalewaStatusneeds review => needs testing
2014-05-11 16:50ZalewaNote Added: 0008778
2014-05-11 16:50ZalewaStatusneeds testing => resolved
2014-05-11 16:50ZalewaFixed in Version => 0.12 Beta
2014-05-11 16:50ZalewaResolutionopen => fixed
2018-09-29 14:45WubTheCaptainStatusresolved => closed

Notes
(0008473)
Zalewa   
2014-04-01 17:39   
(edited on: 2014-04-01 18:57)
This isn't actually a bit more complicated than I initially thought.

The discrepancy was put in intentionally, sort of, as the previous setup collided with Skulltag testing executables. I'll start by reviving the 'pluginapi' branch and modifying the testing binaries installation procedure so that it won't get fired everytime we try to call ExeFile::pathToExe(), but rather there will be a separate ExeFile::install() method that will do the trick.
(0008474)
Zalewa   
2014-04-01 19:12   
Split committed. I think the installation procedure within Zandronum plugin can be somewhat improved, as the path retrieval still performs some write operations to the file system, but if I didn't miss anything it shouldn't trigger any message boxes or other pop-ups anymore.

I think that in distant future this can be exploited to support automatic installation of source-ports, but that's probably not what we should focus on...
(0008475)
Zalewa   
2014-04-02 17:01   
Change committed to pluginapi branch: link.

IWAD and PWADs tooltips will need some testing, as well as game joining. I intentionally left PathFinder for demo loading as it is right now. The change only affected WAD finding related to server joins.
(0008632)
Zalewa   
2014-04-23 18:36   
Change available on beta update channel. Please test if IWAD and WADS columns tooltips work correctly and if there aren't any weird bugs when trying to join servers that host different WADs.
(0008778)
Zalewa   
2014-05-11 16:50   
Resolving due to release of version 0.12 where this is implemented.