Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001683Zandronum[All Projects] Bugpublic2014-01-26 02:142015-12-13 03:11
ReporterAlexMax 
Assigned To 
PrioritynormalSeverityminorReproducibilityunable to reproduce
StatusclosedResolutionno change required 
PlatformOSOS Version
Product Version1.2 
Target VersionFixed in Version 
Summary0001683: P_CheckSight Assert failed
DescriptionGot this error message on my jumpmaze server that crashed:

zandronum-server: /home/alexmax/workspace/zandronum/src/p_sight.cpp:646: bool P_CheckSight(const AActor*, const AActor*, int): Assertion `t1 != __null' failed.
Attached Files? file icon hubs-sighted-torches.wad [^] (735,145 bytes) 2015-08-03 20:50

- Relationships

-  Notes
User avatar (0008134)
Dusk (developer)
2014-01-26 10:28

 and no backtrace?
User avatar (0008136)
Torr Samaho (administrator)
2014-01-26 20:29

 From the line number I guess this is from 1.2, isn't it?
User avatar (0008141)
AlexMax (developer)
2014-01-27 22:49

 Correct. I didn't get a backtrace, the assert was the best I could do. I was hoping that it would be something simple like properly vetting incoming packets or something.
User avatar (0009415)
Watermelon (developer)
2014-06-15 15:10

 We should probably add a safeguard?
User avatar (0011467)
ZzZombo (reporter)
2015-01-21 02:20

 IIRC the function already has a "pointer != NULL" check right after the assert...
User avatar (0011471)
Edward-san (developer)
2015-01-21 07:59

 If you compile with CMake, if you compile the game with RelWithDebInfo, the assertion should go away, but I believe there's a good reason the assertion is present.

Also, the assertion happens because for some reason the codepointer A_CheckSight calls P_CheckSight with first parameter NULL, as if one of the player's camera is missing (you need at least 2 players to reproduce, sadly with big mods).
User avatar (0013037)
arkore (reporter)
2015-08-03 20:52

 I've added an example wad here now, using hub maps, because this is related to 0002342 -- same error occurred there too.
User avatar (0013038)
Edward-san (developer)
2015-08-03 22:22
edited on: 2015-08-03 22:24

 The example wad makes the assertion appear when zandronum-server is compiled with Debug mode on. To reproduce:

- host a server with the example wad,
- connect two clients,
- join both clients as players,
- let the first one walk through the portal,
- after teleporting to the hub map, walk forward, until the server crashes.
User avatar (0013978)
Dusk (developer)
2015-12-13 03:10

 Assertion failures may happen if Debug builds are used. If you don't want them, don't use Debug builds.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: WaTaKiD Navi arkore
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2014-01-26 02:14 AlexMax New Issue
2014-01-26 10:28 Dusk Note Added: 0008134
2014-01-26 20:29 Torr Samaho Note Added: 0008136
2014-01-27 22:49 AlexMax Note Added: 0008141
2014-01-28 19:52 Torr Samaho Product Version => 1.2
2014-06-15 15:10 Watermelon Note Added: 0009415
2014-06-15 15:10 Watermelon Status new => confirmed
2015-01-21 02:20 ZzZombo Note Added: 0011467
2015-01-21 07:59 Edward-san Note Added: 0011471
2015-08-03 20:50 arkore File Added: hubs-sighted-torches.wad
2015-08-03 20:52 arkore Note Added: 0013037
2015-08-03 22:22 Edward-san Note Added: 0013038
2015-08-03 22:24 Edward-san Note Edited: 0013038 View Revisions
2015-12-13 03:10 Dusk Note Added: 0013978
2015-12-13 03:10 Dusk Status confirmed => closed
2015-12-13 03:11 Dusk Resolution open => no change required




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker