MantisBT - Zandronum
View Issue Details
0001683Zandronum[All Projects] Bugpublic2014-01-26 02:142015-12-13 03:11
AlexMax 
 
normalminorunable to reproduce
closedno change required 
1.2 
 
0001683: P_CheckSight Assert failed
Got this error message on my jumpmaze server that crashed:

zandronum-server: /home/alexmax/workspace/zandronum/src/p_sight.cpp:646: bool P_CheckSight(const AActor*, const AActor*, int): Assertion `t1 != __null' failed.
No tags attached.
? hubs-sighted-torches.wad (735,145) 2015-08-03 20:50
/tracker/file_download.php?file_id=1597&type=bug
Issue History
2014-01-26 02:14AlexMaxNew Issue
2014-01-26 10:28DuskNote Added: 0008134
2014-01-26 20:29Torr SamahoNote Added: 0008136
2014-01-27 22:49AlexMaxNote Added: 0008141
2014-01-28 19:52Torr SamahoProduct Version => 1.2
2014-06-15 15:10WatermelonNote Added: 0009415
2014-06-15 15:10WatermelonStatusnew => confirmed
2015-01-21 02:20ZzZomboNote Added: 0011467
2015-01-21 07:59Edward-sanNote Added: 0011471
2015-08-03 20:50arkoreFile Added: hubs-sighted-torches.wad
2015-08-03 20:52arkoreNote Added: 0013037
2015-08-03 22:22Edward-sanNote Added: 0013038
2015-08-03 22:24Edward-sanNote Edited: 0013038bug_revision_view_page.php?bugnote_id=13038#r7798
2015-12-13 03:10DuskNote Added: 0013978
2015-12-13 03:10DuskStatusconfirmed => closed
2015-12-13 03:11DuskResolutionopen => no change required

Notes
(0008134)
Dusk   
2014-01-26 10:28   
and no backtrace?
(0008136)
Torr Samaho   
2014-01-26 20:29   
From the line number I guess this is from 1.2, isn't it?
(0008141)
AlexMax   
2014-01-27 22:49   
Correct. I didn't get a backtrace, the assert was the best I could do. I was hoping that it would be something simple like properly vetting incoming packets or something.
(0009415)
Watermelon   
2014-06-15 15:10   
We should probably add a safeguard?
(0011467)
ZzZombo   
2015-01-21 02:20   
IIRC the function already has a "pointer != NULL" check right after the assert...
(0011471)
Edward-san   
2015-01-21 07:59   
If you compile with CMake, if you compile the game with RelWithDebInfo, the assertion should go away, but I believe there's a good reason the assertion is present.

Also, the assertion happens because for some reason the codepointer A_CheckSight calls P_CheckSight with first parameter NULL, as if one of the player's camera is missing (you need at least 2 players to reproduce, sadly with big mods).
(0013037)
arkore   
2015-08-03 20:52   
I've added an example wad here now, using hub maps, because this is related to 0002342 -- same error occurred there too.
(0013038)
Edward-san   
2015-08-03 22:22   
(edited on: 2015-08-03 22:24)
The example wad makes the assertion appear when zandronum-server is compiled with Debug mode on. To reproduce:

- host a server with the example wad,
- connect two clients,
- join both clients as players,
- let the first one walk through the portal,
- after teleporting to the hub map, walk forward, until the server crashes.

(0013978)
Dusk   
2015-12-13 03:10   
Assertion failures may happen if Debug builds are used. If you don't want them, don't use Debug builds.