Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000160Zandronum[All Projects] Bugpublic2010-11-01 04:472018-09-30 20:03
Reporterunknownna 
Assigned ToTorr Samaho 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version98c 
Target VersionFixed in Version1.0 
Summary0000160: flag/skull/terminator sphere holders and medals
DescriptionWhen a flag/skull/terminator sphere holder gets a medal, the medal isn't displayed above the player sprite, but the flag/skull/sphere fades like a medal.

So if you get many different medals in a row, the flag/skull/sphere fades away until all the medals disappear. This means that in the worst case, no one can see who the flag holder is.
Additional InformationConfirmed in 98c and 98d-r2999.
This happens both offline and online.
Attached Files? file icon 2010.11.03_08.19.03_doom2.cld [^] (133,354 bytes) 2010-11-03 07:24
zip file icon CrashReport_demo.zip [^] (17,046 bytes) 2010-11-03 07:28
? file icon 2010.11.06_19.12.57_doom2.cld [^] (85,321 bytes) 2010-11-06 18:16
png file icon Screenshot_Doom_20110429_055045.png [^] (37,021 bytes) 2011-04-29 04:00


png file icon Screenshot_Doom_20110429_055406.png [^] (40,439 bytes) 2011-04-29 04:01


? file icon 2011.05.15_03.18.28_doom2.cld [^] (22,047 bytes) 2011-05-15 01:21
? file icon 2011.05.15_03.19.35_doom2.cld [^] (15,660 bytes) 2011-05-15 01:21
? file icon 2011.05.16_00.20.26_doom2.cld [^] (26,146 bytes) 2011-05-15 22:24
? file icon 2011.05.16_14.21.34_doom2.cld [^] (13,842 bytes) 2011-05-16 12:26
? file icon 2011.05.18_01.18.01_doom2.cld [^] (15,909 bytes) 2011-05-17 23:28
? file icon 2011.05.19_04.19.25_doom2.cld [^] (18,529 bytes) 2011-05-19 02:23

- Relationships

-  Notes
User avatar (0000501)
Torr Samaho (administrator)
2010-11-01 12:16

Please test if this fixes the issue.
User avatar (0000513)
unknownna (updater)
2010-11-01 18:41
edited on: 2010-11-01 19:59

Looks like it did.

EDIT:

The flag/skull/sphere animation resets when the medals disappear. It's a very minor issue and has no effect on the gameplay.

And the "first frag" medal is not given in all team modes for some reason.

User avatar (0000521)
Torr Samaho (administrator)
2010-11-01 21:54

The medal code intentionally only awards the "first frag" medal in frag based game modes, i.e. DM, TDM, Terminator, Duel.
User avatar (0000523)
unknownna (updater)
2010-11-01 22:14

I see. The reason why it felt "wrong" is due to the "frags" counter in ST/CTF mode.
User avatar (0000535)
unknownna (updater)
2010-11-02 23:44
edited on: 2010-11-02 23:56

Found another issue. If you die as a flag/skull/sphere holder while having a medal, the medal is awarded twice. Well, it's not given twice, but the announcer repeats the soundfile.

EDIT:

Even found another issue. If you score while having a medal, the announcer repeats the medal announcement. Probably the same as the above.

User avatar (0000537)
Torr Samaho (administrator)
2010-11-03 06:27

Can you record a small client side demo of the double announcement?
User avatar (0000538)
unknownna (updater)
2010-11-03 07:24
edited on: 2010-11-03 07:30

Recorded one with 98c.

Managed to get a crash report out of the demo. The demo didn't end properly and "togglemap" then caused it to crash.

User avatar (0000555)
Torr Samaho (administrator)
2010-11-06 17:57

A lot of things have changed since 98c, it would be much easier to debug this with a demo recorded with 98d-3016.
User avatar (0000558)
unknownna (updater)
2010-11-06 18:19

Alright, recorded a new demo with 98d-3016.
User avatar (0001495)
unknownna (updater)
2011-04-28 12:43

This also happens when you drop a terminator sphere.
User avatar (0001498)
unknownna (updater)
2011-04-29 03:58

If a player earns a medal before picking up a flag/hellstone/skull/terminator sphere, the corresponding icons will not be displayed until the medal icons have faded away.
User avatar (0001629)
Torr Samaho (administrator)
2011-05-15 00:52

> If a player earns a medal before picking up a flag/hellstone/skull/terminator sphere, the corresponding icons will not be displayed until the medal icons have faded away.

Can you make a small demo of this with 3232?
User avatar (0001631)
unknownna (updater)
2011-05-15 01:22

The first demo showcases how it looks like when it happens to other players. The second demo showcases how it looks like when it happens to your player.
User avatar (0001639)
Torr Samaho (administrator)
2011-05-15 20:44

This should fix the carrier icon problem. Unfortunately this required some restructuring of the model code, so we need to keep an eye on potential new problems of the medal code.
User avatar (0001640)
unknownna (updater)
2011-05-15 21:24
edited on: 2011-05-15 21:35

It doesn't work in CTF/Skulltag. The announcer repeats the medal announcement in a very fast manner until the corresponding icon fades away.

I also noticed a separate issue: If someone picks up the hellstone before a "map" map change to a CTF/Skulltag map, the sv_possessionholdtime counter will not be removed in the next map. This happens online.

User avatar (0001641)
Torr Samaho (administrator)
2011-05-15 22:11

> It doesn't work in CTF/Skulltag. The announcer repeats the medal announcement in a very fast manner until the corresponding icon fades away.

Can you make a demo of this? And is the behavior in CTF/Skulltag now any different from what happens in 98d?

> I also noticed a separate issue: If someone picks up the hellstone before a "map" map change to a CTF/Skulltag map, the sv_possessionholdtime counter will not be removed in the next map. This happens online.

Please make a new ticket for this.
User avatar (0001642)
unknownna (updater)
2011-05-15 22:21

> And is the behavior in CTF/Skulltag now any different from what happens in 98d?

Yes. It didn't behave like this in 98d.
User avatar (0001643)
Torr Samaho (administrator)
2011-05-15 23:46

I see. This should fix the new CTF/Skulltag issue.
User avatar (0001644)
unknownna (updater)
2011-05-16 00:03

It fixed the issue.
User avatar (0001645)
Torr Samaho (administrator)
2011-05-16 12:08

Does the double announcement still happen? If so, can you record a demo of it with 3240?
User avatar (0001646)
unknownna (updater)
2011-05-16 12:27

Yes, and I recorded a demo if it.

BTW: What happened to cl_announcer? There's a new option: Default.
User avatar (0001647)
Torr Samaho (administrator)
2011-05-16 12:52

> What happened to cl_announcer? There's a new option: Default.

Blzut extended the announcer code. Let me quote him to elaborate this: "I added a "Default" announcer which is automatically populated by the entries from the first announcer to define the entry. Optionally the sounds can be explicitly provided by creating an announcer with the name "Default" which is additive. If an announcer does not have an entry it will fall back to the default announcer preventing the need to continuously update announcers."
User avatar (0001653)
Torr Samaho (administrator)
2011-05-17 01:16

Please test if this fixes the double announcer problem. Please also test if this doesn't break the announcer sounds when the player gets more medals while one is already displayed.
User avatar (0001657)
unknownna (updater)
2011-05-17 02:26

> Please test if this fixes the double announcer problem.

It fixed the double announcement. But the corresponding medal icon is still displayed above the player after losing the flag/skull/hellstone/terminator sphere. It's probably not a bug, but it can look strange when a medal icon is displayed above the sprite of a dead flag carrier.

> Please also test if this doesn't break the announcer sounds when the player gets more medals while one is already displayed.

It seems to work properly.

Separate issues:

* If I earn an Accuracy/Precision medal, missing a shot will not reset the progress, unless the corresponding medal icon has faded away before I miss the shot. This also happens in 98d.
* Medal progress is not cleared after death. This also happens in 98d.
* If you die and respawn while having a medal icon above your sprite, the ally icon will not be displayed upon respawn. This also happens in 98d.
User avatar (0001663)
Torr Samaho (administrator)
2011-05-17 23:10

> It's probably not a bug, but it can look strange when a medal icon is displayed above the sprite of a dead flag carrier.

That's intended. Does dying remove the current medal? If not, then this behavior is consistent in the sense that the carrier icon just suppresses the display of the medal icon.

> * Medal progress is not cleared after death. This also happens in 98d.

That's intended. Only those medals that need it by design take dying into account (Domination and YouFailIt).

> * If you die and respawn while having a medal icon above your sprite, the ally icon will not be displayed upon respawn. This also happens in 98d.

Can you make a short demo of this?
User avatar (0001664)
unknownna (updater)
2011-05-17 23:25
edited on: 2011-05-17 23:36

> Does dying remove the current medal?

No.

> Can you make a short demo of this?

Recorded a demo of it with 3241M. The ally icon is suppressed by the invisible medal.

User avatar (0001668)
Torr Samaho (administrator)
2011-05-18 00:44

> Recorded a demo of it with 3241M. The ally icon is suppressed by the invisible medal.

I see. Thanks! What happens if the player has more medals on the stack while dying and respawning, i.e. when the invisible medal vanishes, does the next medal appear? If so, I'd say the correct behavior would be to display the invisible medal (as apposed to showing the ally icon).
User avatar (0001674)
unknownna (updater)
2011-05-18 01:39

> What happens if the player has more medals on the stack while dying and respawning, i.e. when the invisible medal vanishes, does the next medal appear?

In TDM:

RailGun: The Impressive medal is displayed after the invisible First Frag medal.
Chaingun: The First Frag medal is displayed after the invisible Accuracy/Precision medal.
User avatar (0001684)
Torr Samaho (administrator)
2011-05-19 00:48

> If I earn an Accuracy/Precision medal, missing a shot will not reset the progress, unless the corresponding medal icon has faded away before I miss the shot. This also happens in 98d.

I can't reproduce this. Can you make a demo of this?
User avatar (0001685)
unknownna (updater)
2011-05-19 01:12
edited on: 2011-05-19 01:14

> I can't reproduce this.

I got it wrong. The progress is reset, but the Precision medals suppress the Accuracy medals.

User avatar (0001686)
Torr Samaho (administrator)
2011-05-19 01:22

This should prevent the current medal icon from getting invisible when a player respawns.

> The progress is reset, but the Precision medals suppress the Accuracy medals

Can you elaborate what happens and what you think should happen instead?
User avatar (0001687)
unknownna (updater)
2011-05-19 02:25

> This should prevent the current medal icon from getting invisible when a player respawns.

It fixed the issue.

> Can you elaborate what happens and what you think should happen instead?

1. I fire at my opponent with a chaingun until I earn an Accuracy medal.
2. I fire at my opponent with a chaingun until I earn a Precision medal.
3. I miss a few shots.
4. I fire at my opponent with a chaingun until I earn a Precision medal.

Expected behavior:

1. I fire at my opponent with a chaingun until I earn an Accuracy medal.
2. I fire at my opponent with a chaingun until I earn a Precision medal.
3. I miss a few shots.
4. I fire at my opponent with a chaingun until I earn an Accuracy medal.
5. I fire at my opponent with a chaingun until I earn a Precision medal.

I recorded a demo of it with 3246M.
User avatar (0001712)
Torr Samaho (administrator)
2011-05-21 17:01

What you describe as expected it what actually happens, you can see this with +showmedals. The second accuracy medal is not explicitly announced though because by the time you get the second precision medal, the second accuracy is still in the medal queue. A long time ago Rivecoder changed the queue such that whenever a medal is added while a lower version of it is still on the queue, the lower version is removed. It's debatable whether or not this is the optimal behavior, but at least it seems to be what Rivecoder intended.
User avatar (0001714)
unknownna (updater)
2011-05-21 19:07

> What you describe as expected it what actually happens, you can see this with +showmedals.

You're right.

> A long time ago Rivecoder changed the queue such that whenever a medal is added while a lower version of it is still on the queue, the lower version is removed. It's debatable whether or not this is the optimal behavior, but at least it seems to be what Rivecoder intended.

I see, so it's the intended behavior.
User avatar (0001722)
Torr Samaho (administrator)
2011-05-21 22:57

Ok, from a quick glance I'd say we resolved all issues in this report. Or did I overlook something?
User avatar (0001726)
unknownna (updater)
2011-05-21 23:20

> Or did I overlook something?

I think you got it right. Let us mark this as resolved.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2010-11-01 04:47 unknownna New Issue
2010-11-01 12:16 Torr Samaho Note Added: 0000501
2010-11-01 12:16 Torr Samaho Assigned To => Torr Samaho
2010-11-01 12:16 Torr Samaho Status new => feedback
2010-11-01 18:41 unknownna Note Added: 0000513
2010-11-01 18:41 unknownna Status feedback => assigned
2010-11-01 18:43 unknownna Note Edited: 0000513 View Revisions
2010-11-01 18:44 unknownna Note Edited: 0000513 View Revisions
2010-11-01 18:48 unknownna Note Edited: 0000513 View Revisions
2010-11-01 19:53 unknownna Note Edited: 0000513 View Revisions
2010-11-01 19:59 unknownna Note Edited: 0000513 View Revisions
2010-11-01 21:54 Torr Samaho Note Added: 0000521
2010-11-01 22:14 unknownna Note Added: 0000523
2010-11-02 23:44 unknownna Note Added: 0000535
2010-11-02 23:48 unknownna Note Edited: 0000535 View Revisions
2010-11-02 23:56 unknownna Note Edited: 0000535 View Revisions
2010-11-03 06:27 Torr Samaho Note Added: 0000537
2010-11-03 06:27 Torr Samaho Status assigned => feedback
2010-11-03 07:24 unknownna File Added: 2010.11.03_08.19.03_doom2.cld
2010-11-03 07:24 unknownna Note Added: 0000538
2010-11-03 07:24 unknownna Status feedback => assigned
2010-11-03 07:28 unknownna File Added: CrashReport_demo.zip
2010-11-03 07:30 unknownna Note Edited: 0000538 View Revisions
2010-11-06 17:57 Torr Samaho Note Added: 0000555
2010-11-06 17:57 Torr Samaho Status assigned => feedback
2010-11-06 18:16 Anonymous File Added: 2010.11.06_19.12.57_doom2.cld
2010-11-06 18:19 unknownna Note Added: 0000558
2010-11-06 18:19 unknownna Status feedback => assigned
2011-04-28 12:43 unknownna Note Added: 0001495
2011-04-29 03:58 unknownna Note Added: 0001498
2011-04-29 04:00 unknownna File Added: Screenshot_Doom_20110429_055045.png
2011-04-29 04:01 unknownna File Added: Screenshot_Doom_20110429_055406.png
2011-05-15 00:52 Torr Samaho Note Added: 0001629
2011-05-15 01:21 unknownna File Added: 2011.05.15_03.18.28_doom2.cld
2011-05-15 01:21 unknownna File Added: 2011.05.15_03.19.35_doom2.cld
2011-05-15 01:22 unknownna Note Added: 0001631
2011-05-15 20:44 Torr Samaho Note Added: 0001639
2011-05-15 21:16 Torr Samaho Status assigned => feedback
2011-05-15 21:24 unknownna Note Added: 0001640
2011-05-15 21:24 unknownna Status feedback => assigned
2011-05-15 21:35 unknownna Note Edited: 0001640 View Revisions
2011-05-15 22:11 Torr Samaho Note Added: 0001641
2011-05-15 22:11 Torr Samaho Status assigned => feedback
2011-05-15 22:21 unknownna Note Added: 0001642
2011-05-15 22:21 unknownna Status feedback => assigned
2011-05-15 22:24 unknownna File Added: 2011.05.16_00.20.26_doom2.cld
2011-05-15 23:46 Torr Samaho Note Added: 0001643
2011-05-15 23:47 Torr Samaho Status assigned => feedback
2011-05-16 00:03 unknownna Note Added: 0001644
2011-05-16 00:03 unknownna Status feedback => assigned
2011-05-16 12:08 Torr Samaho Note Added: 0001645
2011-05-16 12:09 Torr Samaho Status assigned => feedback
2011-05-16 12:26 unknownna File Added: 2011.05.16_14.21.34_doom2.cld
2011-05-16 12:27 unknownna Note Added: 0001646
2011-05-16 12:27 unknownna Status feedback => assigned
2011-05-16 12:52 Torr Samaho Note Added: 0001647
2011-05-17 01:16 Torr Samaho Note Added: 0001653
2011-05-17 01:17 Torr Samaho Status assigned => feedback
2011-05-17 02:26 unknownna Note Added: 0001657
2011-05-17 02:26 unknownna Status feedback => assigned
2011-05-17 23:10 Torr Samaho Note Added: 0001663
2011-05-17 23:25 unknownna Note Added: 0001664
2011-05-17 23:28 unknownna File Added: 2011.05.18_01.18.01_doom2.cld
2011-05-17 23:36 unknownna Note Edited: 0001664 View Revisions
2011-05-18 00:44 Torr Samaho Note Added: 0001668
2011-05-18 01:39 unknownna Note Added: 0001674
2011-05-19 00:48 Torr Samaho Note Added: 0001684
2011-05-19 01:12 unknownna Note Added: 0001685
2011-05-19 01:14 unknownna Note Edited: 0001685 View Revisions
2011-05-19 01:22 Torr Samaho Note Added: 0001686
2011-05-19 01:23 Torr Samaho Status assigned => feedback
2011-05-19 02:23 unknownna File Added: 2011.05.19_04.19.25_doom2.cld
2011-05-19 02:25 unknownna Note Added: 0001687
2011-05-19 02:25 unknownna Status feedback => assigned
2011-05-21 17:01 Torr Samaho Note Added: 0001712
2011-05-21 17:03 Torr Samaho Status assigned => feedback
2011-05-21 19:07 unknownna Note Added: 0001714
2011-05-21 19:07 unknownna Status feedback => assigned
2011-05-21 22:57 Torr Samaho Note Added: 0001722
2011-05-21 22:57 Torr Samaho Status assigned => feedback
2011-05-21 23:20 unknownna Note Added: 0001726
2011-05-21 23:20 unknownna Status feedback => assigned
2011-05-21 23:23 Torr Samaho Status assigned => resolved
2011-05-21 23:23 Torr Samaho Fixed in Version => 1.0
2011-05-21 23:23 Torr Samaho Resolution open => fixed
2012-06-09 13:22 Torr Samaho Category General => Bug
2018-09-30 20:03 Blzut3 Status resolved => closed






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker