MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000160Zandronum[All Projects] Bugpublic2010-11-01 04:472018-09-30 20:03
Reporterunknownna 
Assigned ToTorr Samaho 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version98c 
Target VersionFixed in Version1.0 
Summary0000160: flag/skull/terminator sphere holders and medals
DescriptionWhen a flag/skull/terminator sphere holder gets a medal, the medal isn't displayed above the player sprite, but the flag/skull/sphere fades like a medal.

So if you get many different medals in a row, the flag/skull/sphere fades away until all the medals disappear. This means that in the worst case, no one can see who the flag holder is.
Steps To Reproduce
Additional InformationConfirmed in 98c and 98d-r2999.
This happens both offline and online.
TagsNo tags attached.
Relationships
Attached Files? 2010.11.03_08.19.03_doom2.cld (133,354) 2010-11-03 07:24
/tracker/file_download.php?file_id=80&type=bug
zip CrashReport_demo.zip (17,046) 2010-11-03 07:28
/tracker/file_download.php?file_id=81&type=bug
? 2010.11.06_19.12.57_doom2.cld (85,321) 2010-11-06 18:16
/tracker/file_download.php?file_id=83&type=bug
png Screenshot_Doom_20110429_055045.png (37,021) 2011-04-29 04:00
/tracker/file_download.php?file_id=291&type=bug
png

png Screenshot_Doom_20110429_055406.png (40,439) 2011-04-29 04:01
/tracker/file_download.php?file_id=292&type=bug
png

? 2011.05.15_03.18.28_doom2.cld (22,047) 2011-05-15 01:21
/tracker/file_download.php?file_id=312&type=bug
? 2011.05.15_03.19.35_doom2.cld (15,660) 2011-05-15 01:21
/tracker/file_download.php?file_id=313&type=bug
? 2011.05.16_00.20.26_doom2.cld (26,146) 2011-05-15 22:24
/tracker/file_download.php?file_id=316&type=bug
? 2011.05.16_14.21.34_doom2.cld (13,842) 2011-05-16 12:26
/tracker/file_download.php?file_id=317&type=bug
? 2011.05.18_01.18.01_doom2.cld (15,909) 2011-05-17 23:28
/tracker/file_download.php?file_id=329&type=bug
? 2011.05.19_04.19.25_doom2.cld (18,529) 2011-05-19 02:23
/tracker/file_download.php?file_id=332&type=bug
Issue History
Date ModifiedUsernameFieldChange
2010-11-01 04:47unknownnaNew Issue
2010-11-01 12:16Torr SamahoNote Added: 0000501
2010-11-01 12:16Torr SamahoAssigned To => Torr Samaho
2010-11-01 12:16Torr SamahoStatusnew => feedback
2010-11-01 18:41unknownnaNote Added: 0000513
2010-11-01 18:41unknownnaStatusfeedback => assigned
2010-11-01 18:43unknownnaNote Edited: 0000513bug_revision_view_page.php?bugnote_id=513#r236
2010-11-01 18:44unknownnaNote Edited: 0000513bug_revision_view_page.php?bugnote_id=513#r237
2010-11-01 18:48unknownnaNote Edited: 0000513bug_revision_view_page.php?bugnote_id=513#r238
2010-11-01 19:53unknownnaNote Edited: 0000513bug_revision_view_page.php?bugnote_id=513#r244
2010-11-01 19:59unknownnaNote Edited: 0000513bug_revision_view_page.php?bugnote_id=513#r245
2010-11-01 21:54Torr SamahoNote Added: 0000521
2010-11-01 22:14unknownnaNote Added: 0000523
2010-11-02 23:44unknownnaNote Added: 0000535
2010-11-02 23:48unknownnaNote Edited: 0000535bug_revision_view_page.php?bugnote_id=535#r267
2010-11-02 23:56unknownnaNote Edited: 0000535bug_revision_view_page.php?bugnote_id=535#r268
2010-11-03 06:27Torr SamahoNote Added: 0000537
2010-11-03 06:27Torr SamahoStatusassigned => feedback
2010-11-03 07:24unknownnaFile Added: 2010.11.03_08.19.03_doom2.cld
2010-11-03 07:24unknownnaNote Added: 0000538
2010-11-03 07:24unknownnaStatusfeedback => assigned
2010-11-03 07:28unknownnaFile Added: CrashReport_demo.zip
2010-11-03 07:30unknownnaNote Edited: 0000538bug_revision_view_page.php?bugnote_id=538#r275
2010-11-06 17:57Torr SamahoNote Added: 0000555
2010-11-06 17:57Torr SamahoStatusassigned => feedback
2010-11-06 18:16AnonymousFile Added: 2010.11.06_19.12.57_doom2.cld
2010-11-06 18:19unknownnaNote Added: 0000558
2010-11-06 18:19unknownnaStatusfeedback => assigned
2011-04-28 12:43unknownnaNote Added: 0001495
2011-04-29 03:58unknownnaNote Added: 0001498
2011-04-29 04:00unknownnaFile Added: Screenshot_Doom_20110429_055045.png
2011-04-29 04:01unknownnaFile Added: Screenshot_Doom_20110429_055406.png
2011-05-15 00:52Torr SamahoNote Added: 0001629
2011-05-15 01:21unknownnaFile Added: 2011.05.15_03.18.28_doom2.cld
2011-05-15 01:21unknownnaFile Added: 2011.05.15_03.19.35_doom2.cld
2011-05-15 01:22unknownnaNote Added: 0001631
2011-05-15 20:44Torr SamahoNote Added: 0001639
2011-05-15 21:16Torr SamahoStatusassigned => feedback
2011-05-15 21:24unknownnaNote Added: 0001640
2011-05-15 21:24unknownnaStatusfeedback => assigned
2011-05-15 21:35unknownnaNote Edited: 0001640bug_revision_view_page.php?bugnote_id=1640#r845
2011-05-15 22:11Torr SamahoNote Added: 0001641
2011-05-15 22:11Torr SamahoStatusassigned => feedback
2011-05-15 22:21unknownnaNote Added: 0001642
2011-05-15 22:21unknownnaStatusfeedback => assigned
2011-05-15 22:24unknownnaFile Added: 2011.05.16_00.20.26_doom2.cld
2011-05-15 23:46Torr SamahoNote Added: 0001643
2011-05-15 23:47Torr SamahoStatusassigned => feedback
2011-05-16 00:03unknownnaNote Added: 0001644
2011-05-16 00:03unknownnaStatusfeedback => assigned
2011-05-16 12:08Torr SamahoNote Added: 0001645
2011-05-16 12:09Torr SamahoStatusassigned => feedback
2011-05-16 12:26unknownnaFile Added: 2011.05.16_14.21.34_doom2.cld
2011-05-16 12:27unknownnaNote Added: 0001646
2011-05-16 12:27unknownnaStatusfeedback => assigned
2011-05-16 12:52Torr SamahoNote Added: 0001647
2011-05-17 01:16Torr SamahoNote Added: 0001653
2011-05-17 01:17Torr SamahoStatusassigned => feedback
2011-05-17 02:26unknownnaNote Added: 0001657
2011-05-17 02:26unknownnaStatusfeedback => assigned
2011-05-17 23:10Torr SamahoNote Added: 0001663
2011-05-17 23:25unknownnaNote Added: 0001664
2011-05-17 23:28unknownnaFile Added: 2011.05.18_01.18.01_doom2.cld
2011-05-17 23:36unknownnaNote Edited: 0001664bug_revision_view_page.php?bugnote_id=1664#r849
2011-05-18 00:44Torr SamahoNote Added: 0001668
2011-05-18 01:39unknownnaNote Added: 0001674
2011-05-19 00:48Torr SamahoNote Added: 0001684
2011-05-19 01:12unknownnaNote Added: 0001685
2011-05-19 01:14unknownnaNote Edited: 0001685bug_revision_view_page.php?bugnote_id=1685#r859
2011-05-19 01:22Torr SamahoNote Added: 0001686
2011-05-19 01:23Torr SamahoStatusassigned => feedback
2011-05-19 02:23unknownnaFile Added: 2011.05.19_04.19.25_doom2.cld
2011-05-19 02:25unknownnaNote Added: 0001687
2011-05-19 02:25unknownnaStatusfeedback => assigned
2011-05-21 17:01Torr SamahoNote Added: 0001712
2011-05-21 17:03Torr SamahoStatusassigned => feedback
2011-05-21 19:07unknownnaNote Added: 0001714
2011-05-21 19:07unknownnaStatusfeedback => assigned
2011-05-21 22:57Torr SamahoNote Added: 0001722
2011-05-21 22:57Torr SamahoStatusassigned => feedback
2011-05-21 23:20unknownnaNote Added: 0001726
2011-05-21 23:20unknownnaStatusfeedback => assigned
2011-05-21 23:23Torr SamahoStatusassigned => resolved
2011-05-21 23:23Torr SamahoFixed in Version => 1.0
2011-05-21 23:23Torr SamahoResolutionopen => fixed
2012-06-09 13:22Torr SamahoCategoryGeneral => Bug
2018-09-30 20:03Blzut3Statusresolved => closed

Notes
(0000501)
Torr Samaho   
2010-11-01 12:16   
Please test if this fixes the issue.
(0000513)
unknownna   
2010-11-01 18:41   
(edited on: 2010-11-01 19:59)
Looks like it did.

EDIT:

The flag/skull/sphere animation resets when the medals disappear. It's a very minor issue and has no effect on the gameplay.

And the "first frag" medal is not given in all team modes for some reason.
(0000521)
Torr Samaho   
2010-11-01 21:54   
The medal code intentionally only awards the "first frag" medal in frag based game modes, i.e. DM, TDM, Terminator, Duel.
(0000523)
unknownna   
2010-11-01 22:14   
I see. The reason why it felt "wrong" is due to the "frags" counter in ST/CTF mode.
(0000535)
unknownna   
2010-11-02 23:44   
(edited on: 2010-11-02 23:56)
Found another issue. If you die as a flag/skull/sphere holder while having a medal, the medal is awarded twice. Well, it's not given twice, but the announcer repeats the soundfile.

EDIT:

Even found another issue. If you score while having a medal, the announcer repeats the medal announcement. Probably the same as the above.
(0000537)
Torr Samaho   
2010-11-03 06:27   
Can you record a small client side demo of the double announcement?
(0000538)
unknownna   
2010-11-03 07:24   
(edited on: 2010-11-03 07:30)
Recorded one with 98c.

Managed to get a crash report out of the demo. The demo didn't end properly and "togglemap" then caused it to crash.
(0000555)
Torr Samaho   
2010-11-06 17:57   
A lot of things have changed since 98c, it would be much easier to debug this with a demo recorded with 98d-3016.
(0000558)
unknownna   
2010-11-06 18:19   
Alright, recorded a new demo with 98d-3016.
(0001495)
unknownna   
2011-04-28 12:43   
This also happens when you drop a terminator sphere.
(0001498)
unknownna   
2011-04-29 03:58   
If a player earns a medal before picking up a flag/hellstone/skull/terminator sphere, the corresponding icons will not be displayed until the medal icons have faded away.
(0001629)
Torr Samaho   
2011-05-15 00:52   
> If a player earns a medal before picking up a flag/hellstone/skull/terminator sphere, the corresponding icons will not be displayed until the medal icons have faded away.

Can you make a small demo of this with 3232?
(0001631)
unknownna   
2011-05-15 01:22   
The first demo showcases how it looks like when it happens to other players. The second demo showcases how it looks like when it happens to your player.
(0001639)
Torr Samaho   
2011-05-15 20:44   
This should fix the carrier icon problem. Unfortunately this required some restructuring of the model code, so we need to keep an eye on potential new problems of the medal code.
(0001640)
unknownna   
2011-05-15 21:24   
(edited on: 2011-05-15 21:35)
It doesn't work in CTF/Skulltag. The announcer repeats the medal announcement in a very fast manner until the corresponding icon fades away.

I also noticed a separate issue: If someone picks up the hellstone before a "map" map change to a CTF/Skulltag map, the sv_possessionholdtime counter will not be removed in the next map. This happens online.
(0001641)
Torr Samaho   
2011-05-15 22:11   
> It doesn't work in CTF/Skulltag. The announcer repeats the medal announcement in a very fast manner until the corresponding icon fades away.

Can you make a demo of this? And is the behavior in CTF/Skulltag now any different from what happens in 98d?

> I also noticed a separate issue: If someone picks up the hellstone before a "map" map change to a CTF/Skulltag map, the sv_possessionholdtime counter will not be removed in the next map. This happens online.

Please make a new ticket for this.
(0001642)
unknownna   
2011-05-15 22:21   
> And is the behavior in CTF/Skulltag now any different from what happens in 98d?

Yes. It didn't behave like this in 98d.
(0001643)
Torr Samaho   
2011-05-15 23:46   
I see. This should fix the new CTF/Skulltag issue.
(0001644)
unknownna   
2011-05-16 00:03   
It fixed the issue.
(0001645)
Torr Samaho   
2011-05-16 12:08   
Does the double announcement still happen? If so, can you record a demo of it with 3240?
(0001646)
unknownna   
2011-05-16 12:27   
Yes, and I recorded a demo if it.

BTW: What happened to cl_announcer? There's a new option: Default.
(0001647)
Torr Samaho   
2011-05-16 12:52   
> What happened to cl_announcer? There's a new option: Default.

Blzut extended the announcer code. Let me quote him to elaborate this: "I added a "Default" announcer which is automatically populated by the entries from the first announcer to define the entry. Optionally the sounds can be explicitly provided by creating an announcer with the name "Default" which is additive. If an announcer does not have an entry it will fall back to the default announcer preventing the need to continuously update announcers."
(0001653)
Torr Samaho   
2011-05-17 01:16   
Please test if this fixes the double announcer problem. Please also test if this doesn't break the announcer sounds when the player gets more medals while one is already displayed.
(0001657)
unknownna   
2011-05-17 02:26   
> Please test if this fixes the double announcer problem.

It fixed the double announcement. But the corresponding medal icon is still displayed above the player after losing the flag/skull/hellstone/terminator sphere. It's probably not a bug, but it can look strange when a medal icon is displayed above the sprite of a dead flag carrier.

> Please also test if this doesn't break the announcer sounds when the player gets more medals while one is already displayed.

It seems to work properly.

Separate issues:

* If I earn an Accuracy/Precision medal, missing a shot will not reset the progress, unless the corresponding medal icon has faded away before I miss the shot. This also happens in 98d.
* Medal progress is not cleared after death. This also happens in 98d.
* If you die and respawn while having a medal icon above your sprite, the ally icon will not be displayed upon respawn. This also happens in 98d.
(0001663)
Torr Samaho   
2011-05-17 23:10   
> It's probably not a bug, but it can look strange when a medal icon is displayed above the sprite of a dead flag carrier.

That's intended. Does dying remove the current medal? If not, then this behavior is consistent in the sense that the carrier icon just suppresses the display of the medal icon.

> * Medal progress is not cleared after death. This also happens in 98d.

That's intended. Only those medals that need it by design take dying into account (Domination and YouFailIt).

> * If you die and respawn while having a medal icon above your sprite, the ally icon will not be displayed upon respawn. This also happens in 98d.

Can you make a short demo of this?
(0001664)
unknownna   
2011-05-17 23:25   
(edited on: 2011-05-17 23:36)
> Does dying remove the current medal?

No.

> Can you make a short demo of this?

Recorded a demo of it with 3241M. The ally icon is suppressed by the invisible medal.
(0001668)
Torr Samaho   
2011-05-18 00:44   
> Recorded a demo of it with 3241M. The ally icon is suppressed by the invisible medal.

I see. Thanks! What happens if the player has more medals on the stack while dying and respawning, i.e. when the invisible medal vanishes, does the next medal appear? If so, I'd say the correct behavior would be to display the invisible medal (as apposed to showing the ally icon).
(0001674)
unknownna   
2011-05-18 01:39   
> What happens if the player has more medals on the stack while dying and respawning, i.e. when the invisible medal vanishes, does the next medal appear?

In TDM:

RailGun: The Impressive medal is displayed after the invisible First Frag medal.
Chaingun: The First Frag medal is displayed after the invisible Accuracy/Precision medal.
(0001684)
Torr Samaho   
2011-05-19 00:48   
> If I earn an Accuracy/Precision medal, missing a shot will not reset the progress, unless the corresponding medal icon has faded away before I miss the shot. This also happens in 98d.

I can't reproduce this. Can you make a demo of this?
(0001685)
unknownna   
2011-05-19 01:12   
(edited on: 2011-05-19 01:14)
> I can't reproduce this.

I got it wrong. The progress is reset, but the Precision medals suppress the Accuracy medals.
(0001686)
Torr Samaho   
2011-05-19 01:22   
This should prevent the current medal icon from getting invisible when a player respawns.

> The progress is reset, but the Precision medals suppress the Accuracy medals

Can you elaborate what happens and what you think should happen instead?
(0001687)
unknownna   
2011-05-19 02:25   
> This should prevent the current medal icon from getting invisible when a player respawns.

It fixed the issue.

> Can you elaborate what happens and what you think should happen instead?

1. I fire at my opponent with a chaingun until I earn an Accuracy medal.
2. I fire at my opponent with a chaingun until I earn a Precision medal.
3. I miss a few shots.
4. I fire at my opponent with a chaingun until I earn a Precision medal.

Expected behavior:

1. I fire at my opponent with a chaingun until I earn an Accuracy medal.
2. I fire at my opponent with a chaingun until I earn a Precision medal.
3. I miss a few shots.
4. I fire at my opponent with a chaingun until I earn an Accuracy medal.
5. I fire at my opponent with a chaingun until I earn a Precision medal.

I recorded a demo of it with 3246M.
(0001712)
Torr Samaho   
2011-05-21 17:01   
What you describe as expected it what actually happens, you can see this with +showmedals. The second accuracy medal is not explicitly announced though because by the time you get the second precision medal, the second accuracy is still in the medal queue. A long time ago Rivecoder changed the queue such that whenever a medal is added while a lower version of it is still on the queue, the lower version is removed. It's debatable whether or not this is the optimal behavior, but at least it seems to be what Rivecoder intended.
(0001714)
unknownna   
2011-05-21 19:07   
> What you describe as expected it what actually happens, you can see this with +showmedals.

You're right.

> A long time ago Rivecoder changed the queue such that whenever a medal is added while a lower version of it is still on the queue, the lower version is removed. It's debatable whether or not this is the optimal behavior, but at least it seems to be what Rivecoder intended.

I see, so it's the intended behavior.
(0001722)
Torr Samaho   
2011-05-21 22:57   
Ok, from a quick glance I'd say we resolved all issues in this report. Or did I overlook something?
(0001726)
unknownna   
2011-05-21 23:20   
> Or did I overlook something?

I think you got it right. Let us mark this as resolved.