0001455: Flags now always fall through bridges regardless of the compatflag - MantisBT

Zandronum

Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

ID

Project

Category

View Status

Date Submitted

Last Update

0001455

Zandronum

[All Projects] Bug

public

2013-08-09 18:44

2018-09-30 21:33

Reporter

Watermelon

Assigned To

Torr Samaho

Priority

high

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS

OS Version

Product Version

1.1.1

Target Version

Fixed in Version

1.2

Summary

0001455: Flags now always fall through bridges regardless of the compatflag

Description

On and off forces bridge drops. I assume the flag being on is supposed to make it drop only.

Relationships

related to

closed

Dropped White Flag Spawns Underneath 3D floors

Notes
(0006966) Torr Samaho (administrator) 2013-08-10 09:11	Can somebody check when this broke?

(0006977) Watermelon (developer) 2013-08-10 15:29	So apparently it is not the bridge code for the bridge commit, looks like I'll have to go through all the commits and find out where it broke. Something else has affected it.

(0006978) Torr Samaho (administrator) 2013-08-10 16:16	These builds may be helpful to track down the problem.

(0006982) Torr Samaho (administrator) 2013-08-10 18:37	[19:45] Water`:'https://bitbucket.org/Torr_Samaho/zandronum/commits/ff8f59afe1ad61cc1196f1cbda282b74ef1318a8 [^]' [19:45] Water`: im going to try to solve that ticket [19:52] Torr_Samaho: Re-examining this patch I think I see an inconsistency in there: [19:53] Torr_Samaho: In p_user:cpp [19:53] Torr_Samaho: pTeamItem = Spawn( TEAM_GetItem( i ), x, y, z, NO_REPLACE ); [19:53] Torr_Samaho: was replaced by [19:53] Torr_Samaho: pTeamItem = Spawn( TEAM_GetItem( i ), x, y, ONFLOORZ, NO_REPLACE );

(0006983) Torr Samaho (administrator) 2013-08-10 18:38	[19:56] Torr_Samaho: Anyway, before this change the dropping was handled inconsistently on disconnect and on death. [19:56] Torr_Samaho: The ONFLOORZ handling comes from the on disconnect handling.

(0007066) Torr Samaho (administrator) 2013-08-25 19:41	I did some quick testing and the "ONFLOORZ" to "z" change seems to do exactly what we want, so I'll go ahead and make this change.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2013-08-09 18:44	Watermelon	New Issue
2013-08-10 09:11	Torr Samaho	Note Added: 0006966
2013-08-10 15:29	Watermelon	Note Added: 0006977
2013-08-10 16:16	Torr Samaho	Note Added: 0006978
2013-08-10 18:37	Torr Samaho	Note Added: 0006982
2013-08-10 18:38	Torr Samaho	Note Added: 0006983
2013-08-25 19:41	Torr Samaho	Note Added: 0007066
2013-08-25 21:09	Torr Samaho	Assigned To	=> Torr Samaho
2013-08-25 21:09	Torr Samaho	Status	new => assigned
2013-12-27 07:58	Torr Samaho	Status	assigned => needs testing
2014-03-02 17:46	Qent	Status	needs testing => resolved
2014-03-02 17:46	Qent	Fixed in Version	=> 1.2
2014-03-02 17:46	Qent	Resolution	open => fixed
2016-06-16 12:22	Edward-san	Relationship added	related to 0002757
2018-09-30 21:33	Blzut3	Status	resolved => closed

Questions or other issues? Contact Us.

Links

Copyright © 2012-2024, Torr Samaho & Zandronum Team.

Doom and Doom II are the property of id Software.

Copyright © 2000 - 2024 MantisBT Team