0001333: The master <-> server protocol is missing a command to inform the server when it's banned from hosting

Chat on our Discord Server Get the latest version: 3.2
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001333

Zandronum

[All Projects] Bug

public

2013-05-01 12:48

2018-09-30 22:42

Reporter

Konar6

Assigned To

Torr Samaho

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

1.2

Target Version

1.3

Fixed in Version

Summary

0001333: The master <-> server protocol is missing a command to inform the server when it's banned from hosting

Description

The server host has no way of knowing that his server is banned or blocked on the master. Example situation here ->'http://zandronum.com/forum/showthread.php?tid=941&pid=32941#pid32941 [^]'

Additional Information

Technical background: the master actually sends MSC_IPISBANNED to the banned/blocked server, but that command is regarded more as a command to launchers, the server doesn't catch it because the value of MSC_IPISBANNED is the same as CLC_USERINFO which the server silently discards in SERVER_DetermineConnectionType(). I fixed it in this proposed patch without restructuring the command values (without breaking the launcher protocol) ->'https://bitbucket.org/Konar6/kpatch/commits/2717 [^]'

Attached Files

Relationships

Notes
(0006309) Konar6 (reporter) 2013-05-01 13:31	Here is a better patch ->'https://bitbucket.org/Konar6/kpatch/commits/2719 [^]' As Dusk advised me, the previous version didn't account for the CLC_USERINFO value possibly changing.

(0007368) Torr Samaho (administrator) 2013-10-10 16:50	'https://bitbucket.org/Konar6/kpatch/commits/2719 [^]' looks ok. I'll port it.

(0007375) Torr Samaho (administrator) 2013-10-10 19:42	Done.

(0007377) Konar6 (reporter) 2013-10-10 20:05	I tested the fix back then and it worked. + to clarify, it's limited to just few seconds after the startup to prevent abuse of triggering this alert on remote servers by sending a packet with spoofed source IP.

(0007389) Torr Samaho (administrator) 2013-10-12 18:08	This binary can be used for testing.

(0007692) Qent (updater) 2013-12-10 18:26	I tested this successfully on the real master server. There's just the cosmetic issue that the error message appears twice when I host.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2013-05-01 12:48	Konar6	New Issue
2013-05-01 13:31	Konar6	Note Added: 0006309
2013-10-10 16:50	Torr Samaho	Note Added: 0007368
2013-10-10 16:51	Torr Samaho	Product Version	=> 1.2
2013-10-10 16:51	Torr Samaho	Target Version	=> 1.3
2013-10-10 16:54	Torr Samaho	Assigned To	=> Torr Samaho
2013-10-10 16:54	Torr Samaho	Status	new => assigned
2013-10-10 19:42	Torr Samaho	Note Added: 0007375
2013-10-10 19:42	Torr Samaho	Status	assigned => needs testing
2013-10-10 20:05	Konar6	Note Added: 0007377
2013-10-12 18:08	Torr Samaho	Note Added: 0007389
2013-12-10 18:26	Qent	Note Added: 0007692
2014-06-03 17:51	Arco	Status	needs testing => resolved
2014-06-03 17:51	Arco	Resolution	open => fixed
2018-09-30 22:42	Blzut3	Status	resolved => closed

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.