MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001333Zandronum[All Projects] Bugpublic2013-05-01 12:482018-09-30 22:42
ReporterKonar6 
Assigned ToTorr Samaho 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.2 
Target Version1.3Fixed in Version 
Summary0001333: The master <-> server protocol is missing a command to inform the server when it's banned from hosting
DescriptionThe server host has no way of knowing that his server is banned or blocked on the master. Example situation here ->'http://zandronum.com/forum/showthread.php?tid=941&pid=32941#pid32941 [^]'
Steps To Reproduce
Additional InformationTechnical background: the master actually sends MSC_IPISBANNED to the banned/blocked server, but that command is regarded more as a command to launchers, the server doesn't catch it because the value of MSC_IPISBANNED is the same as CLC_USERINFO which the server silently discards in SERVER_DetermineConnectionType(). I fixed it in this proposed patch without restructuring the command values (without breaking the launcher protocol) ->'https://bitbucket.org/Konar6/kpatch/commits/2717 [^]'
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-05-01 12:48Konar6New Issue
2013-05-01 13:31Konar6Note Added: 0006309
2013-10-10 16:50Torr SamahoNote Added: 0007368
2013-10-10 16:51Torr SamahoProduct Version => 1.2
2013-10-10 16:51Torr SamahoTarget Version => 1.3
2013-10-10 16:54Torr SamahoAssigned To => Torr Samaho
2013-10-10 16:54Torr SamahoStatusnew => assigned
2013-10-10 19:42Torr SamahoNote Added: 0007375
2013-10-10 19:42Torr SamahoStatusassigned => needs testing
2013-10-10 20:05Konar6Note Added: 0007377
2013-10-12 18:08Torr SamahoNote Added: 0007389
2013-12-10 18:26QentNote Added: 0007692
2014-06-03 17:51ArcoStatusneeds testing => resolved
2014-06-03 17:51ArcoResolutionopen => fixed
2018-09-30 22:42Blzut3Statusresolved => closed

Notes
(0006309)
Konar6   
2013-05-01 13:31   
Here is a better patch ->'https://bitbucket.org/Konar6/kpatch/commits/2719 [^]'
As Dusk advised me, the previous version didn't account for the CLC_USERINFO value possibly changing.
(0007368)
Torr Samaho   
2013-10-10 16:50   
'https://bitbucket.org/Konar6/kpatch/commits/2719 [^]' looks ok. I'll port it.
(0007375)
Torr Samaho   
2013-10-10 19:42   
Done.
(0007377)
Konar6   
2013-10-10 20:05   
I tested the fix back then and it worked.
+ to clarify, it's limited to just few seconds after the startup to prevent abuse of triggering this alert on remote servers by sending a packet with spoofed source IP.
(0007389)
Torr Samaho   
2013-10-12 18:08   
This binary can be used for testing.
(0007692)
Qent   
2013-12-10 18:26   
I tested this successfully on the real master server. There's just the cosmetic issue that the error message appears twice when I host.