0001197: Player_SetTeam doesn't clear coopspy

Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001197

Zandronum

[All Projects] Bug

public

2012-12-02 12:01

2013-12-08 12:36

Reporter

Dusk

Assigned To

Dusk

Priority

normal

Severity

minor

Reproducibility

always

Status

feedback

Resolution

open

Platform

OS Version

Product Version

1.0

Target Version

Fixed in Version

Summary

0001197: Player_SetTeam doesn't clear coopspy

Description

If Player_SetTeam is used to change a player's team, they will retain their coop spy target and continue to spy on his ex-ally.

Steps To Reproduce

- Load attached wad and start a game
- While still spectating, add a bot. Join the bot's team.
- Run to the opposite team's "base" and to its switch. Before you press it, change coop spy target to your bot ally.
- Hit the switch, which switches you to the enemy team. You will still be spying the bot, but if you reset your spy target you can't re-enter the bot's local view.

Attached Files

Player_SetTeamCoopSpyTest.wad.zip [^] (1,871 bytes) 2012-12-02 12:01

Relationships

Notes
(0005460) Dusk (developer) 2012-12-02 12:21	Fixed

(0005461) Torr Samaho (administrator) 2012-12-02 14:02	Looks good. The only thing I noticed it that it seems that the view gets reset even if the team is not changed. We can probably ignore this though.

(0005474) Torr Samaho (administrator) 2012-12-04 20:48	Quick question: Did you test whether SERVERCOMMANDS_SetPlayerCamera is actually necessary? IIRC the client calls PLAYER_SetTeam in response to SERVERCOMMANDS_SetPlayerTeam, so "pPlayer->camera = pPlayer->mo" should already reset the view on the client.

**Issue Community Support**
Only registered users can voice their support. Click here to register, or here to log in.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2012-12-02 12:01	Dusk	New Issue
2012-12-02 12:01	Dusk	Status	new => assigned
2012-12-02 12:01	Dusk	Assigned To	=> Dusk
2012-12-02 12:01	Dusk	File Added: Player_SetTeamCoopSpyTest.wad.zip
2012-12-02 12:02	Dusk	Product Version	1.1-beta => 1.0
2012-12-02 12:21	Dusk	Note Added: 0005460
2012-12-02 12:21	Dusk	Status	assigned => needs review
2012-12-02 14:02	Torr Samaho	Note Added: 0005461
2012-12-04 20:48	Torr Samaho	Note Added: 0005474
2013-12-08 08:58	Torr Samaho	Status	needs review => feedback

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.