MantisBT - Zandronum
View Issue Details
0001197Zandronum[All Projects] Bugpublic2012-12-02 12:012013-12-08 12:36
Dusk 
Dusk 
normalminoralways
feedbackopen 
1.0 
 
0001197: Player_SetTeam doesn't clear coopspy
If Player_SetTeam is used to change a player's team, they will retain their coop spy target and continue to spy on his ex-ally.
- Load attached wad and start a game
- While still spectating, add a bot. Join the bot's team.
- Run to the opposite team's "base" and to its switch. Before you press it, change coop spy target to your bot ally.
- Hit the switch, which switches you to the enemy team. You will still be spying the bot, but if you reset your spy target you can't re-enter the bot's local view.
No tags attached.
zip Player_SetTeamCoopSpyTest.wad.zip (1,871) 2012-12-02 12:01
/tracker/file_download.php?file_id=894&type=bug
Issue History
2012-12-02 12:01DuskNew Issue
2012-12-02 12:01DuskStatusnew => assigned
2012-12-02 12:01DuskAssigned To => Dusk
2012-12-02 12:01DuskFile Added: Player_SetTeamCoopSpyTest.wad.zip
2012-12-02 12:02DuskProduct Version1.1-beta => 1.0
2012-12-02 12:21DuskNote Added: 0005460
2012-12-02 12:21DuskStatusassigned => needs review
2012-12-02 14:02Torr SamahoNote Added: 0005461
2012-12-04 20:48Torr SamahoNote Added: 0005474
2013-12-08 08:58Torr SamahoStatusneeds review => feedback

Notes
(0005460)
Dusk   
2012-12-02 12:21   
Fixed
(0005461)
Torr Samaho   
2012-12-02 14:02   
Looks good. The only thing I noticed it that it seems that the view gets reset even if the team is not changed. We can probably ignore this though.
(0005474)
Torr Samaho   
2012-12-04 20:48   
Quick question: Did you test whether SERVERCOMMANDS_SetPlayerCamera is actually necessary? IIRC the client calls PLAYER_SetTeam in response to SERVERCOMMANDS_SetPlayerTeam, so "pPlayer->camera = pPlayer->mo" should already reset the view on the client.