0000118: Announcer does not play sounds while in TimeFreeze

Notes
(0000362) unknownna (updater) 2010-10-14 08:45	You're right. It started to behave like this in 98a. It doesn't mute pick-up sounds for some reason.

(0000363) Dark-Assassin (administrator) 2010-10-14 09:55	Well, This was something that was added to zdoom. There was a discussion about it somewhere. IMO it was fine and good when it was original, like in the trailer.

(0000373) Cutman (reporter) 2010-10-15 15:22	All sounds except pickup sounds by the player are stopped I believe, even the music. I kinda like the effect though.

(0000387) Torr Samaho (administrator) 2010-10-17 08:41	AFAIK this is the intended ZDoom behavior of the ZDoom revision Skulltag is using. Can somebody confirm this?

(0000432) unknownna (updater) 2010-10-17 21:35	GZDoom 323 and 98c behave the same way from what I can tell. Pickup sounds aren't muted. I do think that since the announcer is specific to Skulltag, it shouldn't be voided, at least not when announcing "Time Freeze!".

(0001124) unknownna (updater) 2011-02-24 03:10	Chat sounds aren't muted in GZDoom 323 and ZDoom 2.5.0. They are muted in Skulltag 98x

(0011501) Edward-san (developer) 2015-01-22 17:12 edited on: 2015-01-22 17:32	It's because in zdoom, chat sound call passes CHAN_VOICE \| CHAN_UI (see d_net.cpp in DEM_SAY case of Net_DoCommand), while announcer and our chat pass just CHAN_VOICE. this commit contains the fix. Tested offline, multiplayer emulated and online with two clients.

(0011525) Torr Samaho (administrator) 2015-01-25 10:00	I added your fix.

(0011534) cobalt (updater) 2015-01-25 11:46	Issue addressed by commit 0884d052b6ea: - Fixed: Since Skulltag 98a, chat and announcer stopped producing sounds in game during Time Freeze and in intermission after map exiting while Time Freeze was on (fixes 118). Committed by edward_san [edward-san] on Thursday 22 January 2015 18:28:52 Changes in files: docs/zandronum-history.txt \| 1 + src/announcer.cpp \| 2 +- src/chat.cpp \| 6 +++--- 3 files changed, 5 insertions(+), 4 deletions(-)

(0011619) Marcaek (reporter) 2015-02-07 23:26	Seems to work here.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue Community Support

This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.

Supporters:

No one explicitly supports this issue yet.

Opponents:

No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2010-10-14 08:35	Dark-Assassin	New Issue
2010-10-14 08:45	unknownna	Note Added: 0000362
2010-10-14 09:55	Dark-Assassin	Note Added: 0000363
2010-10-15 15:22	Cutman	Note Added: 0000373
2010-10-17 08:41	Torr Samaho	Note Added: 0000387
2010-10-17 08:41	Torr Samaho	Status	new => feedback
2010-10-17 21:35	unknownna	Note Added: 0000432
2011-02-24 03:10	unknownna	Note Added: 0001124
2012-06-09 13:22	Torr Samaho	Category	General => Bug
2015-01-22 17:12	Edward-san	Note Added: 0011501
2015-01-22 17:12	Edward-san	Note Edited: 0011501	View Revisions
2015-01-22 17:32	Edward-san	Note Edited: 0011501	View Revisions
2015-01-22 17:32	Edward-san	Assigned To	=> Edward-san
2015-01-22 17:32	Edward-san	Status	feedback => needs review
2015-01-25 10:00	Torr Samaho	Note Added: 0011525
2015-01-25 10:00	Torr Samaho	Status	needs review => needs testing
2015-01-25 11:46	cobalt	Target Version	=> 1.4
2015-01-25 11:46	cobalt	Note Added: 0011534
2015-02-07 23:26	Marcaek	Note Added: 0011619
2015-02-08 00:58	Dusk	Status	needs testing => resolved
2015-02-08 00:58	Dusk	Fixed in Version	=> 1.4
2015-02-08 00:58	Dusk	Resolution	open => fixed
2018-09-30 23:43	Blzut3	Status	resolved => closed

Relationships