MantisBT - Zandronum
View Issue Details
0000118Zandronum[All Projects] Bugpublic2010-10-14 08:352018-09-30 23:43
Dark-Assassin 
Edward-san 
lowminoralways
closedfixed 
 
1.41.4 
0000118: Announcer does not play sounds while in TimeFreeze
Since the update of the timefreeze code, all sounds were muted. Thus it has also muted announcer sounds, which IMO should not be muted. The announcer even does not say "Time Freeze" anymore.
No tags attached.
Issue History
2010-10-14 08:35Dark-AssassinNew Issue
2010-10-14 08:45unknownnaNote Added: 0000362
2010-10-14 09:55Dark-AssassinNote Added: 0000363
2010-10-15 15:22CutmanNote Added: 0000373
2010-10-17 08:41Torr SamahoNote Added: 0000387
2010-10-17 08:41Torr SamahoStatusnew => feedback
2010-10-17 21:35unknownnaNote Added: 0000432
2011-02-24 03:10unknownnaNote Added: 0001124
2012-06-09 13:22Torr SamahoCategoryGeneral => Bug
2015-01-22 17:12Edward-sanNote Added: 0011501
2015-01-22 17:12Edward-sanNote Edited: 0011501bug_revision_view_page.php?bugnote_id=11501#r6499
2015-01-22 17:32Edward-sanNote Edited: 0011501bug_revision_view_page.php?bugnote_id=11501#r6500
2015-01-22 17:32Edward-sanAssigned To => Edward-san
2015-01-22 17:32Edward-sanStatusfeedback => needs review
2015-01-25 10:00Torr SamahoNote Added: 0011525
2015-01-25 10:00Torr SamahoStatusneeds review => needs testing
2015-01-25 11:46cobaltTarget Version => 1.4
2015-01-25 11:46cobaltNote Added: 0011534
2015-02-07 23:26MarcaekNote Added: 0011619
2015-02-08 00:58DuskStatusneeds testing => resolved
2015-02-08 00:58DuskFixed in Version => 1.4
2015-02-08 00:58DuskResolutionopen => fixed
2018-09-30 23:43Blzut3Statusresolved => closed

Notes
(0000362)
unknownna   
2010-10-14 08:45   
You're right. It started to behave like this in 98a. It doesn't mute pick-up sounds for some reason.
(0000363)
Dark-Assassin   
2010-10-14 09:55   
Well, This was something that was added to zdoom. There was a discussion about it somewhere. IMO it was fine and good when it was original, like in the trailer.
(0000373)
Cutman   
2010-10-15 15:22   
All sounds except pickup sounds by the player are stopped I believe, even the music. I kinda like the effect though.
(0000387)
Torr Samaho   
2010-10-17 08:41   
AFAIK this is the intended ZDoom behavior of the ZDoom revision Skulltag is using. Can somebody confirm this?
(0000432)
unknownna   
2010-10-17 21:35   
GZDoom 323 and 98c behave the same way from what I can tell. Pickup sounds aren't muted.

I do think that since the announcer is specific to Skulltag, it shouldn't be voided, at least not when announcing "Time Freeze!".
(0001124)
unknownna   
2011-02-24 03:10   
Chat sounds aren't muted in GZDoom 323 and ZDoom 2.5.0. They are muted in Skulltag 98x
(0011501)
Edward-san   
2015-01-22 17:12   
(edited on: 2015-01-22 17:32)
It's because in zdoom, chat sound call passes CHAN_VOICE | CHAN_UI (see d_net.cpp in DEM_SAY case of Net_DoCommand), while announcer and our chat pass just CHAN_VOICE.

this commit contains the fix. Tested offline, multiplayer emulated and online with two clients.

(0011525)
Torr Samaho   
2015-01-25 10:00   
I added your fix.
(0011534)
cobalt   
2015-01-25 11:46   
Issue addressed by commit 0884d052b6ea: - Fixed: Since Skulltag 98a, chat and announcer stopped producing sounds in game during Time Freeze and in intermission after map exiting while Time Freeze was on (fixes 118).
Committed by edward_san [edward-san] on Thursday 22 January 2015 18:28:52

Changes in files:
 docs/zandronum-history.txt | 1 +
 src/announcer.cpp | 2 +-
 src/chat.cpp | 6 +++---
 3 files changed, 5 insertions(+), 4 deletions(-)
(0011619)
Marcaek   
2015-02-07 23:26   
Seems to work here.