Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002079Zandronum[All Projects] Bugpublic2015-01-23 15:292018-09-30 23:00
ReporterEdward-san 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version2.0-beta 
Target Version2.0Fixed in Version2.0 
Summary0002079: Polyobj_DoorSwing inconsistencies between zandronum and zdoom and between offline and online
DescriptionWhile testing the door action in ticket 0002075, I got stumbled by a series of inconsistencies with zdoom trunk and between offline and online.

Also, apparently zdoom trunk doesn't do what'http://zdoom.org/wiki/PolyObjects [^]' suggests, related to the polyobj types. I need to clarify this on the zdoom forum.

I made three examples wad from the same example wad in ticket 0002075 , but they're cleaner and each differs from the polydoor type.
Attached Files? file icon poly_swing_harmless.wad [^] (7,348 bytes) 2015-01-23 15:49
? file icon poly_swing_harmful.wad [^] (7,348 bytes) 2015-01-23 15:49
? file icon poly_swing_crush.wad [^] (7,348 bytes) 2015-01-23 15:49

- Relationships
related to 0002091closedTorr Samaho 2-sided polyobjects don't push the player anymore 

-  Notes
User avatar (0011541)
Edward-san (developer)
2015-01-25 15:54
edited on: 2015-01-25 15:59

 Reporting what I found regarding the inconsistency between zandronum and zdoom:

zandronum 2.0 inherits a bug from zdoom 2.5, which was reported here and the example wads here belong to that (if you test the harmless example wad offline, the door does not push you away).
That was fixed in r2620. This commit also fixes two bugs which were reported: APROP_Invulnerable not working, 7-years old bug at that time and the ArmorFactor issue, which happen both also in zandronum 2.0.

I could apply the patch to zandronum 2.0 without problems and this makes the poly door in the example wads work exactly as in zdoom trunk.
User avatar (0011543)
Edward-san (developer)
2015-01-25 18:06

 After fixing it, regarding the offline and online inconsistency: when a player gets in the way of the polyobject, the client will see the polyobject continuing the rotation, even though it should not and should wait for the obstacle to get pushed away.
User avatar (0011579)
Torr Samaho (administrator)
2015-02-01 15:39

 I started to look into the issue. The problem is that the client doesn't check locally whether the door is blocked, while the server doesn't inform the client about the block either.

I think this problem crept in with TIHan's poly object door changes. I'll see what we can do about this.
User avatar (0011580)
Torr Samaho (administrator)
2015-02-01 16:02

 This should fix the issue.
User avatar (0011582)
Edward-san (developer)
2015-02-01 18:46
edited on: 2015-02-01 18:46

 While I can't run it because I have linux, offline I reported a bug to zdoom which happens also in zandronum and regards a possible way to break the door. Sadly it's still in review, I hope randi or graf can accept one of the two patches I made to fix it.
User avatar (0011583)
cobalt (updater)
2015-02-01 20:37

 Issue addressed by commit b59b2ee01bab: Fixed: Blocked poly object doors were not handled properly online (addresses 2079).
Committed by Benjamin Berkels [Torr Samaho] on Sunday 01 February 2015 21:35:45

Changes in files:
 docs/zandronum-history.txt | 1 +
 src/po_man.cpp | 14 +++++++++++++-
 src/po_man.h | 3 +++
 3 files changed, 17 insertions(+), 1 deletions(-)
User avatar (0011592)
Edward-san (developer)
2015-02-02 14:47

 Yeah, the online fix works fine for me. Waiting for more feedback to confirm this.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2015-01-23 15:29 Edward-san New Issue
2015-01-23 15:29 Edward-san File Added: poly_swing_harmless.wad
2015-01-23 15:30 Edward-san File Deleted: poly_swing_harmless.wad
2015-01-23 15:49 Edward-san File Added: poly_swing_harmless.wad
2015-01-23 15:49 Edward-san File Added: poly_swing_harmful.wad
2015-01-23 15:49 Edward-san File Added: poly_swing_crush.wad
2015-01-25 15:54 Edward-san Note Added: 0011541
2015-01-25 15:55 Edward-san Note Edited: 0011541 View Revisions
2015-01-25 15:59 Edward-san Note Edited: 0011541 View Revisions
2015-01-25 18:06 Edward-san Note Added: 0011543
2015-02-01 15:39 Torr Samaho Note Added: 0011579
2015-02-01 15:39 Torr Samaho Assigned To => Torr Samaho
2015-02-01 15:39 Torr Samaho Status new => assigned
2015-02-01 16:02 Torr Samaho Note Added: 0011580
2015-02-01 16:47 Torr Samaho Status assigned => needs testing
2015-02-01 18:46 Edward-san Note Added: 0011582
2015-02-01 18:46 Edward-san Note Edited: 0011582 View Revisions
2015-02-01 20:37 cobalt Target Version => 2.0
2015-02-01 20:37 cobalt Description Updated View Revisions
2015-02-01 20:37 cobalt Note Added: 0011583
2015-02-02 14:47 Edward-san Note Added: 0011592
2015-02-03 17:54 Edward-san Relationship added related to 0002091
2015-03-29 20:20 Dusk Status needs testing => resolved
2015-03-29 20:20 Dusk Fixed in Version => 2.0
2015-03-29 20:20 Dusk Resolution open => fixed
2018-09-30 23:00 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker