MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002079Zandronum[All Projects] Bugpublic2015-01-23 15:292018-09-30 23:00
ReporterEdward-san 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version2.0-beta 
Target Version2.0Fixed in Version2.0 
Summary0002079: Polyobj_DoorSwing inconsistencies between zandronum and zdoom and between offline and online
DescriptionWhile testing the door action in ticket 0002075, I got stumbled by a series of inconsistencies with zdoom trunk and between offline and online.

Also, apparently zdoom trunk doesn't do what'http://zdoom.org/wiki/PolyObjects [^]' suggests, related to the polyobj types. I need to clarify this on the zdoom forum.

I made three examples wad from the same example wad in ticket 0002075 , but they're cleaner and each differs from the polydoor type.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0002091closed Torr Samaho 2-sided polyobjects don't push the player anymore 
Attached Files? poly_swing_harmless.wad (7,348) 2015-01-23 15:49
https://zandronum.com/tracker/file_download.php?file_id=1393&type=bug
? poly_swing_harmful.wad (7,348) 2015-01-23 15:49
https://zandronum.com/tracker/file_download.php?file_id=1394&type=bug
? poly_swing_crush.wad (7,348) 2015-01-23 15:49
https://zandronum.com/tracker/file_download.php?file_id=1395&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-01-23 15:29Edward-sanNew Issue
2015-01-23 15:29Edward-sanFile Added: poly_swing_harmless.wad
2015-01-23 15:30Edward-sanFile Deleted: poly_swing_harmless.wad
2015-01-23 15:49Edward-sanFile Added: poly_swing_harmless.wad
2015-01-23 15:49Edward-sanFile Added: poly_swing_harmful.wad
2015-01-23 15:49Edward-sanFile Added: poly_swing_crush.wad
2015-01-25 15:54Edward-sanNote Added: 0011541
2015-01-25 15:55Edward-sanNote Edited: 0011541bug_revision_view_page.php?bugnote_id=11541#r6538
2015-01-25 15:59Edward-sanNote Edited: 0011541bug_revision_view_page.php?bugnote_id=11541#r6539
2015-01-25 18:06Edward-sanNote Added: 0011543
2015-02-01 15:39Torr SamahoNote Added: 0011579
2015-02-01 15:39Torr SamahoAssigned To => Torr Samaho
2015-02-01 15:39Torr SamahoStatusnew => assigned
2015-02-01 16:02Torr SamahoNote Added: 0011580
2015-02-01 16:47Torr SamahoStatusassigned => needs testing
2015-02-01 18:46Edward-sanNote Added: 0011582
2015-02-01 18:46Edward-sanNote Edited: 0011582bug_revision_view_page.php?bugnote_id=11582#r6559
2015-02-01 20:37cobaltTarget Version => 2.0
2015-02-01 20:37cobaltDescription Updatedbug_revision_view_page.php?rev_id=6561#r6561
2015-02-01 20:37cobaltNote Added: 0011583
2015-02-02 14:47Edward-sanNote Added: 0011592
2015-02-03 17:54Edward-sanRelationship addedrelated to 0002091
2015-03-29 20:20DuskStatusneeds testing => resolved
2015-03-29 20:20DuskFixed in Version => 2.0
2015-03-29 20:20DuskResolutionopen => fixed
2018-09-30 23:00Blzut3Statusresolved => closed

Notes
(0011541)
Edward-san   
2015-01-25 15:54   
(edited on: 2015-01-25 15:59)
Reporting what I found regarding the inconsistency between zandronum and zdoom:

zandronum 2.0 inherits a bug from zdoom 2.5, which was reported here and the example wads here belong to that (if you test the harmless example wad offline, the door does not push you away).
That was fixed in r2620. This commit also fixes two bugs which were reported: APROP_Invulnerable not working, 7-years old bug at that time and the ArmorFactor issue, which happen both also in zandronum 2.0.

I could apply the patch to zandronum 2.0 without problems and this makes the poly door in the example wads work exactly as in zdoom trunk.
(0011543)
Edward-san   
2015-01-25 18:06   
After fixing it, regarding the offline and online inconsistency: when a player gets in the way of the polyobject, the client will see the polyobject continuing the rotation, even though it should not and should wait for the obstacle to get pushed away.
(0011579)
Torr Samaho   
2015-02-01 15:39   
I started to look into the issue. The problem is that the client doesn't check locally whether the door is blocked, while the server doesn't inform the client about the block either.

I think this problem crept in with TIHan's poly object door changes. I'll see what we can do about this.
(0011580)
Torr Samaho   
2015-02-01 16:02   
This should fix the issue.
(0011582)
Edward-san   
2015-02-01 18:46   
While I can't run it because I have linux, offline I reported a bug to zdoom which happens also in zandronum and regards a possible way to break the door. Sadly it's still in review, I hope randi or graf can accept one of the two patches I made to fix it.
(0011583)
cobalt   
2015-02-01 20:37   
Issue addressed by commit b59b2ee01bab: Fixed: Blocked poly object doors were not handled properly online (addresses 2079).
Committed by Benjamin Berkels [Torr Samaho] on Sunday 01 February 2015 21:35:45

Changes in files:
 docs/zandronum-history.txt | 1 +
 src/po_man.cpp | 14 +++++++++++++-
 src/po_man.h | 3 +++
 3 files changed, 17 insertions(+), 1 deletions(-)
(0011592)
Edward-san   
2015-02-02 14:47   
Yeah, the online fix works fine for me. Waiting for more feedback to confirm this.