0000865: Ability to change flag thing dimensions

(0003682)
Ivan (reporter)
2012-06-06 10:39

It adds to the gameplay doesn't it ? It's fine the way it is IMO otherwise it'd be too easy. (I agree it doesn't make sense, though)

(0003687)
jwaffe (reporter)
2012-06-06 21:37

In some maps I can imagine it does, though it seems like something the modder should be able to adjust to fit the environment.

(0003695)
Torr Samaho (administrator)
2012-06-09 11:52

> though it seems like something the modder should be able to adjust to fit the environment.

This is already possible with DECORATE + TEAMINFO, isn't it?

(0004274)
jwaffe (reporter)
2012-08-05 17:58
edited on: 2012-08-05 18:16

No, unfortunately TEAMINFO has no effect, see attached wad, MAP01

I set the height to 900 but the actual hitbox of the flag is unchanged. The flag actor has been updated ("New" in pickup message) but the height is the same.

Seems that something about the flag actors' collision is hard coded.

EDIT - no extra PWADs are necessary to run this, it supplies its own flag graphics.

This bug occurs with the white flag as well.

EDIT - Teaminfo isn't necessary to replace the flag, a simple NewFlagActor : FlagActor replaces FlagActor is sufficient for the new flag to appear (indicated by a changed pickup message), though the height does not change.

(0004277)
Dusk (developer)
2012-08-05 19:13

I'll take a look at this..

(0004282)
Torr Samaho (administrator)
2012-08-06 06:42

Quote from jwaffe
Teaminfo isn't necessary to replace the flag, a simple NewFlagActor : FlagActor replaces FlagActor is sufficient for the new flag to appear (indicated by a changed pickup message), though the height does not change.

Flags are not supposed to be replaced like this. Try replacing them with the FlagItem TEAMINFO property and check if it works then.

(0004286)
jwaffe (reporter)
2012-08-06 12:29
edited on: 2012-08-06 12:30

@Torr - In the attached example wad I used Flagitem in TEAMINFO + DECORATE; in a later test I used just DECORATE for the white flag and the pickup message was changed, so I guessed they were the same. I don't recall if I tested the functionality of that white flag, though.

(0004294)
Dusk (developer)
2012-08-06 20:55

Alright - the problem is that the height property gets ignored for not just flags but ALL inventory. And it happens in latest ZDoom.

Reported.

(0004342)
Dusk (developer)
2012-08-11 12:43

This got fixed:'http://forum.zdoom.org/viewtopic.php?f=7&t=33654 [^]'

(0004451)
jwaffe (reporter)
2012-08-25 19:15

Any updates on this? Is this fix in the latest Zand build, or will it be put in later?

(0004452)
Torr Samaho (administrator)
2012-08-25 20:00

The fix is not included in 1.0 and I didn't check the fix yet. So can't say how easy it is to backport it.

(0004460)
Torr Samaho (administrator)
2012-08-26 10:27

Turned out that the fix is easy to back port. Please test if this the issue.

(0004461)
jwaffe (reporter)
2012-08-26 11:19
edited on: 2012-08-26 11:20

The height of the flag is now correctly changed offline, however, I noticed some other strange behavior, if I jump or have a position anywhere above the floor height and I use "kill" in this map, the flag sprite disappears but it can still be picked up.

I recall this bug being present in the stable zand build too, I believe it has something to do with TEAMINFO/custom flags

This bug went away when I raised the ceiling height.

(0004464)
Torr Samaho (administrator)
2012-08-26 14:30

Quote from jwaffe
I noticed some other strange behavior, if I jump or have a position anywhere above the floor height and I use "kill" in this map, the flag sprite disappears but it can still be picked up.

Is it any different in 98d?

(0004465)
jwaffe (reporter)
2012-08-26 14:46

98D has the same effect, but worse

if I die while jumping with the flag the flag completely disappears and can't be picked up.

Also, when I tried to reset the map while the flag was "gone", it caused Windows 7 to lock up.

(0004469)
Torr Samaho (administrator)
2012-08-26 19:14

And how is the

Quote from jwaffe
I jump or have a position anywhere above the floor height and I use "kill" in this map, the flag sprite disappears but it can still be picked up.

problem in the ZDoom?

(0004472)
jwaffe (reporter)
2012-08-26 19:35

I'm not sure how to implement this in zDoom, Teamitem.Flag.[Red/Blue]Flag are skulltag specific actors, and I can't think of a way to reproduce the flag drop and return behavior without those base actors.

It doesn't seem to happen while dropping a weapon while jumping in zDoom, though that's the closest thing I can think of to the flag glitch.

(0023421)
Ru5tK1ng (updater)
2024-03-18 20:57

No long an issue in 3.1

This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	Combinebobnt
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2012-06-06 03:23	jwaffe	New Issue
2012-06-06 10:39	Ivan	Note Added: 0003682
2012-06-06 21:37	jwaffe	Note Added: 0003687
2012-06-09 11:52	Torr Samaho	Note Added: 0003695
2012-06-09 11:53	Torr Samaho	Status	new => feedback
2012-08-05 17:58	jwaffe	File Added: TeamInfoBugTest.wad
2012-08-05 17:58	jwaffe	Note Added: 0004274
2012-08-05 17:58	jwaffe	Status	feedback => new
2012-08-05 17:59	jwaffe	Note Edited: 0004274	View Revisions
2012-08-05 18:00	jwaffe	Note Edited: 0004274	View Revisions
2012-08-05 18:08	jwaffe	Note Edited: 0004274	View Revisions
2012-08-05 18:16	jwaffe	Note Edited: 0004274	View Revisions
2012-08-05 18:16	jwaffe	Note Edited: 0004274	View Revisions
2012-08-05 19:13	Dusk	Note Added: 0004277
2012-08-05 19:13	Dusk	Assigned To	=> Dusk
2012-08-05 19:13	Dusk	Status	new => assigned
2012-08-06 06:42	Torr Samaho	Note Added: 0004282
2012-08-06 12:29	jwaffe	Note Added: 0004286
2012-08-06 12:29	jwaffe	Note Edited: 0004286	View Revisions
2012-08-06 12:30	jwaffe	Note Edited: 0004286	View Revisions
2012-08-06 20:55	Dusk	Note Added: 0004294
2012-08-06 20:55	Dusk	Assigned To	Dusk =>
2012-08-06 20:55	Dusk	Status	assigned => acknowledged
2012-08-06 20:55	Dusk	Resolution	open => waiting for zdoom
2012-08-06 20:57	Dusk	Category	Suggestion => Bug
2012-08-11 12:43	Dusk	Note Added: 0004342
2012-08-11 12:43	Dusk	Status	acknowledged => feedback
2012-08-11 12:43	Dusk	Resolution	waiting for zdoom => open
2012-08-25 19:15	jwaffe	Note Added: 0004451
2012-08-25 19:15	jwaffe	Status	feedback => new
2012-08-25 20:00	Torr Samaho	Note Added: 0004452
2012-08-26 10:27	Torr Samaho	Note Added: 0004460
2012-08-26 10:28	Torr Samaho	Assigned To	=> Torr Samaho
2012-08-26 10:28	Torr Samaho	Status	new => feedback
2012-08-26 11:19	jwaffe	Note Added: 0004461
2012-08-26 11:19	jwaffe	Status	feedback => assigned
2012-08-26 11:20	jwaffe	Note Edited: 0004461	View Revisions
2012-08-26 14:30	Torr Samaho	Note Added: 0004464
2012-08-26 14:30	Torr Samaho	Status	assigned => feedback
2012-08-26 14:46	jwaffe	Note Added: 0004465
2012-08-26 14:46	jwaffe	Status	feedback => assigned
2012-08-26 19:14	Torr Samaho	Note Added: 0004469
2012-08-26 19:15	Torr Samaho	Assigned To	Torr Samaho =>
2012-08-26 19:15	Torr Samaho	Status	assigned => feedback
2012-08-26 19:27	Torr Samaho	Assigned To	=> Torr Samaho
2012-08-26 19:27	Torr Samaho	Status	feedback => assigned
2012-08-26 19:35	jwaffe	Note Added: 0004472
2024-03-18 20:57	Ru5tK1ng	Note Added: 0023421
2024-03-18 20:57	Ru5tK1ng	Status	assigned => resolved
2024-03-18 20:57	Ru5tK1ng	Resolution	open => fixed

Notes
(0003682) Ivan (reporter) 2012-06-06 10:39	It adds to the gameplay doesn't it ? It's fine the way it is IMO otherwise it'd be too easy. (I agree it doesn't make sense, though)

(0003687) jwaffe (reporter) 2012-06-06 21:37	In some maps I can imagine it does, though it seems like something the modder should be able to adjust to fit the environment.

(0003695) Torr Samaho (administrator) 2012-06-09 11:52	> though it seems like something the modder should be able to adjust to fit the environment. This is already possible with DECORATE + TEAMINFO, isn't it?

(0004274) jwaffe (reporter) 2012-08-05 17:58 edited on: 2012-08-05 18:16	No, unfortunately TEAMINFO has no effect, see attached wad, MAP01 I set the height to 900 but the actual hitbox of the flag is unchanged. The flag actor has been updated ("New" in pickup message) but the height is the same. Seems that something about the flag actors' collision is hard coded. EDIT - no extra PWADs are necessary to run this, it supplies its own flag graphics. This bug occurs with the white flag as well. EDIT - Teaminfo isn't necessary to replace the flag, a simple NewFlagActor : FlagActor replaces FlagActor is sufficient for the new flag to appear (indicated by a changed pickup message), though the height does not change.

(0004277) Dusk (developer) 2012-08-05 19:13	I'll take a look at this..

(0004282) Torr Samaho (administrator) 2012-08-06 06:42	Quote from jwaffe Teaminfo isn't necessary to replace the flag, a simple NewFlagActor : FlagActor replaces FlagActor is sufficient for the new flag to appear (indicated by a changed pickup message), though the height does not change. Flags are not supposed to be replaced like this. Try replacing them with the FlagItem TEAMINFO property and check if it works then.

(0004286) jwaffe (reporter) 2012-08-06 12:29 edited on: 2012-08-06 12:30	@Torr - In the attached example wad I used Flagitem in TEAMINFO + DECORATE; in a later test I used just DECORATE for the white flag and the pickup message was changed, so I guessed they were the same. I don't recall if I tested the functionality of that white flag, though.

(0004294) Dusk (developer) 2012-08-06 20:55	Alright - the problem is that the height property gets ignored for not just flags but ALL inventory. And it happens in latest ZDoom. Reported.

(0004342) Dusk (developer) 2012-08-11 12:43	This got fixed:'http://forum.zdoom.org/viewtopic.php?f=7&t=33654 [^]'

(0004451) jwaffe (reporter) 2012-08-25 19:15	Any updates on this? Is this fix in the latest Zand build, or will it be put in later?

(0004452) Torr Samaho (administrator) 2012-08-25 20:00	The fix is not included in 1.0 and I didn't check the fix yet. So can't say how easy it is to backport it.

(0004460) Torr Samaho (administrator) 2012-08-26 10:27	Turned out that the fix is easy to back port. Please test if this the issue.

(0004461) jwaffe (reporter) 2012-08-26 11:19 edited on: 2012-08-26 11:20	The height of the flag is now correctly changed offline, however, I noticed some other strange behavior, if I jump or have a position anywhere above the floor height and I use "kill" in this map, the flag sprite disappears but it can still be picked up. I recall this bug being present in the stable zand build too, I believe it has something to do with TEAMINFO/custom flags This bug went away when I raised the ceiling height.

(0004464) Torr Samaho (administrator) 2012-08-26 14:30	Quote from jwaffe I noticed some other strange behavior, if I jump or have a position anywhere above the floor height and I use "kill" in this map, the flag sprite disappears but it can still be picked up. Is it any different in 98d?

(0004465) jwaffe (reporter) 2012-08-26 14:46	98D has the same effect, but worse if I die while jumping with the flag the flag completely disappears and can't be picked up. Also, when I tried to reset the map while the flag was "gone", it caused Windows 7 to lock up.

(0004469) Torr Samaho (administrator) 2012-08-26 19:14	And how is the Quote from jwaffe I jump or have a position anywhere above the floor height and I use "kill" in this map, the flag sprite disappears but it can still be picked up. problem in the ZDoom?

(0004472) jwaffe (reporter) 2012-08-26 19:35	I'm not sure how to implement this in zDoom, Teamitem.Flag.[Red/Blue]Flag are skulltag specific actors, and I can't think of a way to reproduce the flag drop and return behavior without those base actors. It doesn't seem to happen while dropping a weapon while jumping in zDoom, though that's the closest thing I can think of to the flag glitch.

(0023421) Ru5tK1ng (updater) 2024-03-18 20:57	No long an issue in 3.1

Relationships