0000823: Strange ACS Crash

Notes
(0003492) Edward-san (developer) 2012-04-29 15:56	You need to specify if it crashes in 98d and in latest 98e alpha.

(0003493) Tribeam213 (reporter) 2012-04-29 15:57	Derp 98e alpha

(0003501) Torr Samaho (administrator) 2012-04-30 00:47	Does it work in ZDoom?

(0003504) Tribeam213 (reporter) 2012-04-30 02:36 edited on: 2012-04-30 07:34	This does work in ZDoom, however I haven't upgraded GZDoom in a long time and it doesn't work there. Edit: Newest GZDoom rev does not crash, the GZDoom version I used before had zdoom r3010. zdoom r3563(that's the earliest I could find on the svn builds) didn't crash. so I'm guessing between r3010 and r3563 is a fix. Edit2: I "think" i might of found the main issue, though thats a maybe; it appears that if a script has more than 20 variables, ACS becomes unstable and all kinds of weird things start to happen like string corruption and crashing. moving them to map scope fixes everything.

(0003562) Blzut3 (administrator) 2012-05-04 22:11	There was a bug in ZDoom where the chunk that tells the VM to allocate room for more than 20 variables (the default limit is 20) was not read properly. I don't know the revision for the fix offhand, but if someone were to look through the log for p_acs.cpp they should find it.

(0003573) MP2E (reporter) 2012-05-06 23:41	Two revisions from ZDoom that possibly fix this: 'http://zdoom.org/Changelog/3352/files [^]' 'http://zdoom.org/Changelog/3359/files [^]' Not going any farther as they're backports.

(0004262) Torr Samaho (administrator) 2012-08-05 10:37	I backported the fix from 3352 and this seems to fix the problem. Please confirm with this binary.

(0004427) Dusk (developer) 2012-08-24 10:39	confirmed fixed

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue Community Support

This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.

Supporters:

No one explicitly supports this issue yet.

Opponents:

No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2012-04-29 15:38	Tribeam213	New Issue
2012-04-29 15:56	Edward-san	Note Added: 0003492
2012-04-29 15:57	Tribeam213	Note Added: 0003493
2012-04-29 16:52	Dusk	Product Version	=> 1.0-beta
2012-04-30 00:47	Torr Samaho	Note Added: 0003501
2012-04-30 02:36	Tribeam213	Note Added: 0003504
2012-04-30 02:37	Tribeam213	Note Edited: 0003504	View Revisions
2012-04-30 04:55	Tribeam213	Note Edited: 0003504	View Revisions
2012-04-30 07:34	Tribeam213	Note Edited: 0003504	View Revisions
2012-04-30 07:34	Tribeam213	Note Edited: 0003504	View Revisions
2012-05-04 22:11	Blzut3	Note Added: 0003562
2012-05-06 23:41	MP2E	Note Added: 0003573
2012-06-09 13:22	Torr Samaho	Category	General => Bug
2012-07-31 19:28	Torr Samaho	Status	new => acknowledged
2012-08-05 10:08	Torr Samaho	File Added: ACScrash.wad
2012-08-05 10:37	Torr Samaho	Note Added: 0004262
2012-08-05 10:37	Torr Samaho	Assigned To	=> Torr Samaho
2012-08-05 10:37	Torr Samaho	Status	acknowledged => needs testing
2012-08-24 10:39	Dusk	Note Added: 0004427
2012-08-24 10:39	Dusk	Status	needs testing => resolved
2012-08-24 10:39	Dusk	Fixed in Version	=> 1.0
2012-08-24 10:39	Dusk	Resolution	open => fixed
2018-09-30 19:52	Blzut3	Status	resolved => closed

Relationships