MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000823Zandronum[All Projects] Bugpublic2012-04-29 15:382018-09-30 19:52
ReporterTribeam213 
Assigned ToTorr Samaho 
PrioritynormalSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version1.0-beta 
Target VersionFixed in Version1.0 
Summary0000823: Strange ACS Crash
Description'http://pastebin.com/Seh0yUep [^]'

Was programing some scripts when a strange crash started to occur. I narrowed the problem and created this script to demonstrate.
Steps To ReproducePut this in a blank map, play it, puke 5
the scripts have comments with extra details.
Additional InformationThis crash does not bring up the crash dialog.
TagsNo tags attached.
Relationships
Attached Files? ACScrash.wad (2,663) 2012-08-05 10:08
/tracker/file_download.php?file_id=657&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-04-29 15:38Tribeam213New Issue
2012-04-29 15:56Edward-sanNote Added: 0003492
2012-04-29 15:57Tribeam213Note Added: 0003493
2012-04-29 16:52DuskProduct Version => 1.0-beta
2012-04-30 00:47Torr SamahoNote Added: 0003501
2012-04-30 02:36Tribeam213Note Added: 0003504
2012-04-30 02:37Tribeam213Note Edited: 0003504bug_revision_view_page.php?bugnote_id=3504#r1885
2012-04-30 04:55Tribeam213Note Edited: 0003504bug_revision_view_page.php?bugnote_id=3504#r1889
2012-04-30 07:34Tribeam213Note Edited: 0003504bug_revision_view_page.php?bugnote_id=3504#r1890
2012-04-30 07:34Tribeam213Note Edited: 0003504bug_revision_view_page.php?bugnote_id=3504#r1891
2012-05-04 22:11Blzut3Note Added: 0003562
2012-05-06 23:41MP2ENote Added: 0003573
2012-06-09 13:22Torr SamahoCategoryGeneral => Bug
2012-07-31 19:28Torr SamahoStatusnew => acknowledged
2012-08-05 10:08Torr SamahoFile Added: ACScrash.wad
2012-08-05 10:37Torr SamahoNote Added: 0004262
2012-08-05 10:37Torr SamahoAssigned To => Torr Samaho
2012-08-05 10:37Torr SamahoStatusacknowledged => needs testing
2012-08-24 10:39DuskNote Added: 0004427
2012-08-24 10:39DuskStatusneeds testing => resolved
2012-08-24 10:39DuskFixed in Version => 1.0
2012-08-24 10:39DuskResolutionopen => fixed
2018-09-30 19:52Blzut3Statusresolved => closed

Notes
(0003492)
Edward-san   
2012-04-29 15:56   
You need to specify if it crashes in 98d and in latest 98e alpha.
(0003493)
Tribeam213   
2012-04-29 15:57   
Derp 98e alpha
(0003501)
Torr Samaho   
2012-04-30 00:47   
Does it work in ZDoom?
(0003504)
Tribeam213   
2012-04-30 02:36   
(edited on: 2012-04-30 07:34)
This does work in ZDoom, however I haven't upgraded GZDoom in a long time and it doesn't work there.

Edit:
Newest GZDoom rev does not crash,
the GZDoom version I used before had zdoom r3010.
zdoom r3563(that's the earliest I could find on the svn builds) didn't crash.

so I'm guessing between r3010 and r3563 is a fix.

Edit2: I "think" i might of found the main issue, though thats a maybe; it appears that if a script has more than 20 variables, ACS becomes unstable and all kinds of weird things start to happen like string corruption and crashing.
moving them to map scope fixes everything.
(0003562)
Blzut3   
2012-05-04 22:11   
There was a bug in ZDoom where the chunk that tells the VM to allocate room for more than 20 variables (the default limit is 20) was not read properly. I don't know the revision for the fix offhand, but if someone were to look through the log for p_acs.cpp they should find it.
(0003573)
MP2E   
2012-05-06 23:41   
Two revisions from ZDoom that possibly fix this:
'http://zdoom.org/Changelog/3352/files [^]'
'http://zdoom.org/Changelog/3359/files [^]'

Not going any farther as they're backports.
(0004262)
Torr Samaho   
2012-08-05 10:37   
I backported the fix from 3352 and this seems to fix the problem. Please confirm with this binary.
(0004427)
Dusk   
2012-08-24 10:39   
confirmed fixed