Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000744Zandronum[All Projects] Bugpublic2012-03-29 11:092018-09-30 22:47
Reporterunknownna 
Assigned ToTorr Samaho 
PrioritylowSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version98d 
Target VersionFixed in Version 
Summary0000744: View bobs after unmorphing online
DescriptionSame as 0000309: View bobs after teleporting online (movebob) and 0000484: View bobs after being affected by Thing_Stop online.
Steps To Reproduce1. Start a server with the example WAD loaded.
2. Connect a client to the server.
3. Join the game.
4. Walk over the gray line.
5. After unmorphing, hold +forward just for a little while before releasing it.
Attached Files? file icon morph_bug_test_06.wad [^] (2,357 bytes) 2012-03-29 11:09
jpg file icon assertion.jpg [^] (301,741 bytes) 2012-04-03 02:34

- Relationships
related to 0000309closedTorr Samaho View bobs after teleporting online (movebob) 
related to 0000484closedDusk View bobs after being affected by Thing_Stop online 
related to 0000764feedbackTIHan View bobs after being affected by A_Stop + PROP_FROZEN 

-  Notes
User avatar (0003119)
TIHan (reporter)
2012-04-03 02:28
edited on: 2012-04-03 06:50

There is something weird going on with the example wad here. In debug mode, I get an assertion on AActor::ObtainInventory which means Inventory was NOT NULL and somehow we called ObtainInventory. This doesn't crash in release mode, but there is something funky here.

As for the viewbobs, I think I'm more concerned about this assertion.

The assertion occurs in singleplayer and on the server.

Edit3:
I thought about this a little backwards here. For clarification... if the expression inside assert is true, program continues on happy go lucky. If the expression turns false, it will display a message almost like an error.
Currently, I'm not sure if this is a ZDoom error. I need to compile a debug binary of one.

User avatar (0003134)
TIHan (reporter)
2012-04-04 23:49
edited on: 2012-04-04 23:49

It seems the assertion's expression returning false also happens in ZDoom 1551 and the ZDoom 2.5.0 r2508; so that's their problem. It doesn't crash anything, it's just telling the programmers that something is wrong. I'll go ahead and fix the bug here.

User avatar (0003135)
Edward-san (developer)
2012-04-05 00:38

I was able to reproduce the assertion failure in latest svn, hence I reported it to zdoom devs.
User avatar (0003136)
TIHan (reporter)
2012-04-05 02:49
edited on: 2012-04-05 05:03

Fixed.
'https://bitbucket.org/TIHan/tst/changeset/9ed77293c3a7 [^]'

Edit: If there needs to be a discussion on reaction time, I have found at least one other use case for it.

User avatar (0003156)
Edward-san (developer)
2012-04-06 10:26

'http://zdoom.org/Changelog/3519/files [^]'
Fixed: It was possible to give inventory items to the base actors of something morphed. This would cause an assertion failure when unmorphing.
User avatar (0003160)
Torr Samaho (administrator)
2012-04-07 00:29
edited on: 2012-04-07 00:32

> If there needs to be a discussion on reaction time, I have found at least one other use case for it.

Please tell me about the other occurrence. I think the unmorphing problem alone can be fixed very simply and without additional net traffic as follows:


diff -r 4aeebb963aca src/cl_main.cpp
--- a/src/cl_main.cpp Wed Apr 04 22:28:40 2012 -0400
+++ b/src/cl_main.cpp Fri Apr 06 20:28:19 2012 -0400
@@ -3879,9 +3879,15 @@
         // morph time since the server handles the timing of the unmorphing.
         pPlayer->morphTics = -1;
     }
- else
+ else
+ {
         pPlayer->morphTics = 0;
 
+ if ( bPlayerWasMorphed )
+ pPlayer->mo->reactiontime = 18;
+ }
+
+
     // If this is the consoleplayer, set the realorigin and ServerXYZMom.
     if ( ulPlayer == static_cast<ULONG>(consoleplayer) )
     {


EDIT: Possibly one needs


diff -r 4aeebb963aca src/g_shared/a_morph.cpp
--- a/src/g_shared/a_morph.cpp Wed Apr 04 22:28:40 2012 -0400
+++ b/src/g_shared/a_morph.cpp Fri Apr 06 20:31:07 2012 -0400
@@ -386,6 +386,8 @@
     // [BB] Tell the clients to unmorph the player, also give back the original inventory to the player.
     if ( NETWORK_GetState( ) == NETSTATE_SERVER )
     {
+ SERVER_AdjustPlayersReactiontime ( static_cast<ULONG> ( player - players ) );
+
         SERVERCOMMANDS_SpawnPlayer( ULONG( player-players ), PST_LIVE );
         SERVER_ResetInventory( ULONG( player-players ));
         SERVERCOMMANDS_SetThingFlags( player->mo, FLAGSET_FLAGS );


in addition.


Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2012-03-29 11:09 unknownna New Issue
2012-03-29 11:09 unknownna File Added: morph_bug_test_06.wad
2012-03-29 11:09 unknownna Status new => confirmed
2012-03-29 14:19 TIHan Assigned To => TIHan
2012-03-29 14:19 TIHan Status confirmed => assigned
2012-04-03 02:28 TIHan Note Added: 0003119
2012-04-03 02:28 TIHan Status assigned => feedback
2012-04-03 02:29 TIHan Note Edited: 0003119 View Revisions
2012-04-03 02:31 TIHan Relationship added related to 0000309
2012-04-03 02:32 TIHan Relationship added related to 0000484
2012-04-03 02:32 TIHan File Added: assertion.png
2012-04-03 02:33 TIHan File Deleted: assertion.png
2012-04-03 02:34 TIHan File Added: assertion.jpg
2012-04-03 02:55 TIHan Note Edited: 0003119 View Revisions
2012-04-03 06:21 TIHan Note Edited: 0003119 View Revisions
2012-04-03 06:38 TIHan Note Edited: 0003119 View Revisions
2012-04-03 06:50 TIHan Note Edited: 0003119 View Revisions
2012-04-04 23:49 TIHan Note Added: 0003134
2012-04-04 23:49 TIHan Note Edited: 0003134 View Revisions
2012-04-05 00:38 Edward-san Note Added: 0003135
2012-04-05 02:49 TIHan Note Added: 0003136
2012-04-05 04:48 TIHan Note Edited: 0003136 View Revisions
2012-04-05 04:59 TIHan Note Edited: 0003136 View Revisions
2012-04-05 05:03 TIHan Note Edited: 0003136 View Revisions
2012-04-06 10:26 Edward-san Note Added: 0003156
2012-04-07 00:29 Torr Samaho Note Added: 0003160
2012-04-07 00:31 Torr Samaho Note Edited: 0003160 View Revisions
2012-04-07 00:32 Torr Samaho Note Edited: 0003160 View Revisions
2012-04-07 00:32 Torr Samaho Note Edited: 0003160 View Revisions
2012-04-12 03:09 unknownna Relationship added related to 0000764
2012-04-14 17:35 TIHan Status feedback => resolved
2012-04-14 17:35 TIHan Resolution open => fixed
2012-04-14 17:35 TIHan Assigned To TIHan => Torr Samaho
2012-06-09 13:22 Torr Samaho Category General => Bug
2018-09-30 22:47 Blzut3 Status resolved => closed






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker