Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000714Zandronum[All Projects] Bugpublic2012-03-25 17:582018-09-30 23:15
ReporterEdward-san 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version2.0 
Summary0000714: [UDMF] per-sidedef brightness settings don't work in GL
DescriptionQuote from old thread:


Pretty much what it says on the tin. In UDMF you can set brightness levels per-sidedef, and the GL renderer is ignoring those settings and instead drawing the sidedefs at sector brightness.

This one has a long history:
'http://mancubus.net/svn/gzdoom/?op=revision&rev=790 [^]' first hacky workaround
'http://mancubus.net/svn/gzdoom/?op=revision&rev=793 [^]' rewrite of concerned code, part 1: ZDoom
'http://mancubus.net/svn/gzdoom/?op=revision&rev=795 [^]' rewrite of concerned code, part 2: OpenGL
'http://mancubus.net/svn/gzdoom/?op=revision&rev=796 [^]' cleanup
Attached Files

- Relationships
child of 0001490closedTorr Samaho Backport ZDoom 2.5.0 

-  Notes
User avatar (0003205)
MP2E (reporter)
2012-04-11 12:12

 'https://bitbucket.org/MP2E/skulltag/changeset/fa1764340581 [^]'

Successfully backported from GZDoom revisions specified.

r_fakecontrast seems to work, however I wasn't able to find a UDMF wad that I know has per-sidedef lighting. I also am in Linux so I am unable to create a test wad myself.

Unfortunately I haven't set up my cross-compiler dependencies for Skulltag either, so I can't upload a Win32 build(this will change in the next few days).
User avatar (0003207)
Edward-san (developer)
2012-04-11 13:50
edited on: 2012-04-11 13:52

 I suggest to not remove gl_fakecontrast in 98e. For now we can make it equal to r_fakecontrast and declare it obsolete, so there would be no problems with compatibility.
User avatar (0003232)
MP2E (reporter)
2012-04-13 03:17

 'https://bitbucket.org/MP2E/skulltag/changeset/1bd01d7bc92e [^]'

This second commit readds gl_fakecontrast as an equivalent to r_fakecontrast and marked it as deprecated.
User avatar (0003235)
Edward-san (developer)
2012-04-13 11:30

 After re-analyzing the involved changes, I think it's a better idea to backport only r790. That workaround seems to work well for the time being, without changing the cvars. The other changes can be backported when the codebase will be updated, i.e. after the 98e release. Torr?
User avatar (0003278)
MP2E (reporter)
2012-04-15 08:39

 'https://bitbucket.org/MP2E/skulltag/changeset/e32c4908c18f [^]'

Should be the final version, just implements r790.
User avatar (0003292)
Torr Samaho (administrator)
2012-04-15 18:23

 I'm not quite sure if this fix should be backported in an out of sequence manner at all. All the GL renderer files were moved and reordered since revision GZDoom 323 and backporting changes that were made after the reordering makes updating the code base more cumbersome.
User avatar (0003297)
MP2E (reporter)
2012-04-15 19:54

 Torr : I wasn't sure at first either but the out of order revision seems to "just work"
User avatar (0003299)
Torr Samaho (administrator)
2012-04-15 20:02

 FYI, I'm not worried about the backport not working, I'm worried about the added conflicts I will get when upgrading Skulltag's ZDoom base.
User avatar (0009104)
Watermelon (developer)
2014-06-11 21:26

 Is this backported now?
User avatar (0009135)
Edward-san (developer)
2014-06-11 22:59

 Yes:

Ported changes from ZDoom revision 2307-2309 and from GZDoom revision 787-792
Ported changes from ZDoom revision 2310-2320 and from GZDoom revision 793-795
Ported changes from ZDoom revision 2321-2331 and from GZDoom revision 796-798

I tested it with the map from the old gzdoom thread and works as expected. I'll wait for a confirmation from another tester.
User avatar (0009145)
Frits (reporter)
2014-06-12 16:50
edited on: 2014-06-12 16:50

 works as it should in 2.0
User avatar (0009151)
Edward-san (developer)
2014-06-12 20:00

 Thank you, Frits! Closing it.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2012-03-25 17:58 Edward-san New Issue
2012-04-11 12:12 MP2E Note Added: 0003205
2012-04-11 13:50 Edward-san Note Added: 0003207
2012-04-11 13:51 Edward-san Note Edited: 0003207 View Revisions
2012-04-11 13:52 Edward-san Note Edited: 0003207 View Revisions
2012-04-13 03:17 MP2E Note Added: 0003232
2012-04-13 11:30 Edward-san Note Added: 0003235
2012-04-15 08:32 MP2E Note Added: 0003277
2012-04-15 08:33 MP2E Note Deleted: 0003277
2012-04-15 08:39 MP2E Note Added: 0003278
2012-04-15 18:23 Torr Samaho Note Added: 0003292
2012-04-15 19:54 MP2E Note Added: 0003297
2012-04-15 20:02 Torr Samaho Note Added: 0003299
2012-06-09 13:22 Torr Samaho Category General => Bug
2014-06-11 21:26 Watermelon Note Added: 0009104
2014-06-11 21:26 Watermelon Status new => feedback
2014-06-11 22:59 Edward-san Note Added: 0009135
2014-06-11 22:59 Edward-san Status feedback => new
2014-06-11 23:02 Edward-san Status new => needs testing
2014-06-11 23:03 Edward-san Relationship added child of 0001490
2014-06-12 16:50 Frits Note Added: 0009145
2014-06-12 16:50 Frits Note Edited: 0009145 View Revisions
2014-06-12 19:58 Dusk Status needs testing => resolved
2014-06-12 19:58 Dusk Fixed in Version => 2.0
2014-06-12 19:58 Dusk Resolution open => fixed
2014-06-12 19:58 Dusk Assigned To => Torr Samaho
2014-06-12 20:00 Edward-san Note Added: 0009151
2018-09-30 23:15 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker