MantisBT - Zandronum
View Issue Details
0000714Zandronum[All Projects] Bugpublic2012-03-25 17:582018-09-30 23:15
Edward-san 
Torr Samaho 
normalminorhave not tried
closedfixed 
 
2.0 
0000714: [UDMF] per-sidedef brightness settings don't work in GL
Quote from old thread:


Pretty much what it says on the tin. In UDMF you can set brightness levels per-sidedef, and the GL renderer is ignoring those settings and instead drawing the sidedefs at sector brightness.

This one has a long history:
'http://mancubus.net/svn/gzdoom/?op=revision&rev=790 [^]' first hacky workaround
'http://mancubus.net/svn/gzdoom/?op=revision&rev=793 [^]' rewrite of concerned code, part 1: ZDoom
'http://mancubus.net/svn/gzdoom/?op=revision&rev=795 [^]' rewrite of concerned code, part 2: OpenGL
'http://mancubus.net/svn/gzdoom/?op=revision&rev=796 [^]' cleanup
No tags attached.
child of 0001490closed Torr Samaho Backport ZDoom 2.5.0 
Issue History
2012-03-25 17:58Edward-sanNew Issue
2012-04-11 12:12MP2ENote Added: 0003205
2012-04-11 13:50Edward-sanNote Added: 0003207
2012-04-11 13:51Edward-sanNote Edited: 0003207bug_revision_view_page.php?bugnote_id=3207#r1701
2012-04-11 13:52Edward-sanNote Edited: 0003207bug_revision_view_page.php?bugnote_id=3207#r1702
2012-04-13 03:17MP2ENote Added: 0003232
2012-04-13 11:30Edward-sanNote Added: 0003235
2012-04-15 08:32MP2ENote Added: 0003277
2012-04-15 08:33MP2ENote Deleted: 0003277
2012-04-15 08:39MP2ENote Added: 0003278
2012-04-15 18:23Torr SamahoNote Added: 0003292
2012-04-15 19:54MP2ENote Added: 0003297
2012-04-15 20:02Torr SamahoNote Added: 0003299
2012-06-09 13:22Torr SamahoCategoryGeneral => Bug
2014-06-11 21:26WatermelonNote Added: 0009104
2014-06-11 21:26WatermelonStatusnew => feedback
2014-06-11 22:59Edward-sanNote Added: 0009135
2014-06-11 22:59Edward-sanStatusfeedback => new
2014-06-11 23:02Edward-sanStatusnew => needs testing
2014-06-11 23:03Edward-sanRelationship addedchild of 0001490
2014-06-12 16:50FritsNote Added: 0009145
2014-06-12 16:50FritsNote Edited: 0009145bug_revision_view_page.php?bugnote_id=9145#r4915
2014-06-12 19:58DuskStatusneeds testing => resolved
2014-06-12 19:58DuskFixed in Version => 2.0
2014-06-12 19:58DuskResolutionopen => fixed
2014-06-12 19:58DuskAssigned To => Torr Samaho
2014-06-12 20:00Edward-sanNote Added: 0009151
2018-09-30 23:15Blzut3Statusresolved => closed

Notes
(0003205)
MP2E   
2012-04-11 12:12   
'https://bitbucket.org/MP2E/skulltag/changeset/fa1764340581 [^]'

Successfully backported from GZDoom revisions specified.

r_fakecontrast seems to work, however I wasn't able to find a UDMF wad that I know has per-sidedef lighting. I also am in Linux so I am unable to create a test wad myself.

Unfortunately I haven't set up my cross-compiler dependencies for Skulltag either, so I can't upload a Win32 build(this will change in the next few days).
(0003207)
Edward-san   
2012-04-11 13:50   
(edited on: 2012-04-11 13:52)
I suggest to not remove gl_fakecontrast in 98e. For now we can make it equal to r_fakecontrast and declare it obsolete, so there would be no problems with compatibility.

(0003232)
MP2E   
2012-04-13 03:17   
'https://bitbucket.org/MP2E/skulltag/changeset/1bd01d7bc92e [^]'

This second commit readds gl_fakecontrast as an equivalent to r_fakecontrast and marked it as deprecated.
(0003235)
Edward-san   
2012-04-13 11:30   
After re-analyzing the involved changes, I think it's a better idea to backport only r790. That workaround seems to work well for the time being, without changing the cvars. The other changes can be backported when the codebase will be updated, i.e. after the 98e release. Torr?
(0003278)
MP2E   
2012-04-15 08:39   
'https://bitbucket.org/MP2E/skulltag/changeset/e32c4908c18f [^]'

Should be the final version, just implements r790.
(0003292)
Torr Samaho   
2012-04-15 18:23   
I'm not quite sure if this fix should be backported in an out of sequence manner at all. All the GL renderer files were moved and reordered since revision GZDoom 323 and backporting changes that were made after the reordering makes updating the code base more cumbersome.
(0003297)
MP2E   
2012-04-15 19:54   
Torr : I wasn't sure at first either but the out of order revision seems to "just work"
(0003299)
Torr Samaho   
2012-04-15 20:02   
FYI, I'm not worried about the backport not working, I'm worried about the added conflicts I will get when upgrading Skulltag's ZDoom base.
(0009104)
Watermelon   
2014-06-11 21:26   
Is this backported now?
(0009135)
Edward-san   
2014-06-11 22:59   
Yes:

Ported changes from ZDoom revision 2307-2309 and from GZDoom revision 787-792
Ported changes from ZDoom revision 2310-2320 and from GZDoom revision 793-795
Ported changes from ZDoom revision 2321-2331 and from GZDoom revision 796-798

I tested it with the map from the old gzdoom thread and works as expected. I'll wait for a confirmation from another tester.
(0009145)
Frits   
2014-06-12 16:50   
works as it should in 2.0

(0009151)
Edward-san   
2014-06-12 20:00   
Thank you, Frits! Closing it.