Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000589Zandronum[All Projects] Suggestionpublic2011-09-20 23:282018-09-30 19:53
ReporterM0rbid Desire 
Assigned ToTorr Samaho 
PrioritylowSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindows 7OS Version64-bits
Product Version 
Target VersionFixed in Version1.0 
Summary0000589: Set THRUSPECIES as dmflag
DescriptionWould be useful to set this feature as dmflag, so you'll dont need to edit the "doomplayer" DECORATE to add a simple line.
Additional InformationNOTE: This feature aint important yet, cause we haven't tested 100%, there's still some issues that we aren't sure.
Attached Files? file icon test_telefragvoodoo.wad [^] (4,590 bytes) 2012-06-16 22:56

- Relationships

-  Notes
User avatar (0002203)
Devon (reporter)
2011-09-21 21:05

 Simpler and easier. Good idea.
User avatar (0003389)
Torr Samaho (administrator)
2012-04-22 22:14

 Before I implement this, how should the flag be named?
User avatar (0003392)
Edward-san (developer)
2012-04-22 23:55

 I'm not sure why isn't it labeled as [Ask ZDoom], but yeah, it seems a good idea.

Quote

NOTE: This feature aint important yet, cause we haven't tested 100%, there's still some issues that we aren't sure.

Please check out them accurately. If there are still some issues, create a new ticket about them.
User avatar (0003393)
Torr Samaho (administrator)
2012-04-23 00:17

 Here is a testing binary, the flag is called sv_unblockplayers.
User avatar (0003394)
Edward-san (developer)
2012-04-23 00:33

 Does this flag ignore the '+THRUSPECIES' property in the decorate definition?
User avatar (0003395)
Torr Samaho (administrator)
2012-04-23 00:35

 Activating this flag will make player bodies act as if they have THRUSPECIES, no matter if the body actually has it or not.
User avatar (0003398)
unknownna (updater)
2012-04-23 06:02

 > Here is a testing binary, the flag is called sv_unblockplayers.

It seems to work, but players are still able to telefrag each other.
User avatar (0003400)
Torr Samaho (administrator)
2012-04-23 11:22

 > but players are still able to telefrag each other.

Does THRUSPECIES prevent telefragging in ZDoom?
User avatar (0003401)
unknownna (updater)
2012-04-23 11:38

 Not in 2.5.0 and SVN build 3587.
User avatar (0003402)
Dusk (developer)
2012-04-23 13:41
edited on: 2012-04-23 13:41

 When the +THRUSPECIES flag was added, testing showed telefrags can be avoided by nullifying out the SpawnTelefrag damage. I'd believe that this dmflag should imply immunity to that.
User avatar (0003410)
Hypnotoad (reporter)
2012-04-24 00:43

 Agree with Dusk, if you don't remove spawnfrag and telefragging it will defeat the purpose of having it as a server flag, as you will still have to apply a patchwad to remove them.
User avatar (0003412)
Torr Samaho (administrator)
2012-04-24 00:50

 The original request was to apply THRUSPECIES to player bodies and this is exactly what I did. If you want to refine the original request, that's fine, but you will need to specify exactly what you want. And technically all supporters would have to reassure their support since the request itself is changed.

So, was there a small mod that did exactly what you had in mind with this request? If so, please post it here.
User avatar (0003495)
Hypnotoad (reporter)
2012-04-29 20:49

 This is exactly what is wanted, applying the following to player body decorate:

+THRUSPECIES
DamageFactor "Telefrag", 0
DamageFactor "SpawnTelefrag", 0

I am certain all supporters agree with this, I haven't encountered a single person who would disagree.

Thanks
User avatar (0003496)
Hypnotoad (reporter)
2012-04-29 20:50

 Oh and optionally you could apply +MTHRUSPECIES to the rocket decorate (and grenade I guess?) to make rockets go through people.
User avatar (0003527)
Hisymak (reporter)
2012-05-01 10:31

 +THRUSPECIES
DamageFactor "Telefrag", 0
DamageFactor "SpawnTelefrag", 0
- I agree.

But why make rockets go through people?
User avatar (0003528)
unknownna (updater)
2012-05-01 10:53

 > When the +THRUSPECIES flag was added, testing showed telefrags can be avoided by nullifying out the SpawnTelefrag damage. I'd believe that this dmflag should imply immunity to that.

This work-around doesn't seem to take care of the regular telefrags that occur after using teleporters.

> DamageFactor "Telefrag", 0

The problem with this is that players will not be telefragged by non-player things, e.g., the spawn cubes in MAP30.
User avatar (0003531)
Dusk (developer)
2012-05-01 11:43

 Maybe we could add an exception to player-player telefrags in damage factoring code to implement the dmflag function properly?
User avatar (0003533)
Torr Samaho (administrator)
2012-05-01 11:49

 > Maybe we could add an exception to player-player telefrags in damage factoring code to implement the dmflag function properly?

Yes, I think this is the way to go, i.e. reduce damage dealt to a player to zero if it is of type Telefrag or SpawnTelefrag, the source is another player and sv_unblockplayers is true. Do you want to give this a shot or shall I take care of it?
User avatar (0003561)
Dusk (developer)
2012-05-03 00:47
edited on: 2012-05-03 01:16

 Sure, I'll deal away this one.

[EDIT] Done:
'https://bitbucket.org/CrimsonDusk/notebola/changeset/ba08c293ec9d [^]'
User avatar (0003591)
Torr Samaho (administrator)
2012-05-08 01:55

 Patch added with an additional ( source != NULL ) check.
User avatar (0003745)
Qent (updater)
2012-06-12 22:36

 This DMFlag also prevents telefragging voodoo dolls even when sv_coopunassignedvoodoodolls is false. How should this be treated? On one hand, it could break levels that use voodoo doll telefrags as deathtraps; but on the other hand, voodoo dolls are rare, and I had thought that support for them online was already hacky and unreliable.
User avatar (0003784)
Torr Samaho (administrator)
2012-06-16 16:48
Quote from Qent

This DMFlag also prevents telefragging voodoo dolls even when sv_coopunassignedvoodoodolls is false. How should this be treated?

Can you make a minimal example wad? I think this should be easy to fix.
User avatar (0003789)
Qent (updater)
2012-06-16 22:57

 test_telefragvoodoo.wad

Aside from that, sv_unblockplayers worked perfectly in SNS today.
User avatar (0003807)
Torr Samaho (administrator)
2012-06-18 19:34

 This should restore telefragging for voodoo dolls.
User avatar (0003811)
Qent (updater)
2012-06-19 01:38

 Yes, thanks; it works on- and offline.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: Torr Samaho Qent Devon
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2011-09-20 23:28 M0rbid Desire New Issue
2011-09-21 21:05 Devon Note Added: 0002203
2012-04-22 19:31 Torr Samaho Assigned To => Torr Samaho
2012-04-22 19:31 Torr Samaho Status new => confirmed
2012-04-22 22:14 Torr Samaho Note Added: 0003389
2012-04-22 23:55 Edward-san Note Added: 0003392
2012-04-23 00:17 Torr Samaho Note Added: 0003393
2012-04-23 00:19 Torr Samaho Status confirmed => feedback
2012-04-23 00:33 Edward-san Note Added: 0003394
2012-04-23 00:35 Torr Samaho Note Added: 0003395
2012-04-23 06:02 unknownna Note Added: 0003398
2012-04-23 11:22 Torr Samaho Note Added: 0003400
2012-04-23 11:38 unknownna Note Added: 0003401
2012-04-23 13:41 Dusk Note Added: 0003402
2012-04-23 13:41 Dusk Note Edited: 0003402 View Revisions
2012-04-24 00:43 Hypnotoad Note Added: 0003410
2012-04-24 00:50 Torr Samaho Note Added: 0003412
2012-04-29 20:49 Hypnotoad Note Added: 0003495
2012-04-29 20:50 Hypnotoad Note Added: 0003496
2012-05-01 10:31 Hisymak Note Added: 0003527
2012-05-01 10:53 unknownna Note Added: 0003528
2012-05-01 11:43 Dusk Note Added: 0003531
2012-05-01 11:49 Torr Samaho Note Added: 0003533
2012-05-03 00:47 Dusk Note Added: 0003561
2012-05-03 00:48 Dusk Status feedback => assigned
2012-05-03 01:01 Dusk Note Edited: 0003561 View Revisions
2012-05-03 01:09 Dusk Note Edited: 0003561 View Revisions
2012-05-03 01:16 Dusk Note Edited: 0003561 View Revisions
2012-05-03 01:16 Dusk Note Edited: 0003561 View Revisions
2012-05-03 01:16 Dusk Status assigned => needs review
2012-05-08 01:55 Torr Samaho Note Added: 0003591
2012-05-08 01:56 Torr Samaho Status needs review => feedback
2012-05-27 09:51 Torr Samaho Status feedback => needs testing
2012-06-12 22:36 Qent Note Added: 0003745
2012-06-15 12:29 Dusk Summary [Further versions] Set THRUSPECIES as dmflag => Set THRUSPECIES as dmflag
2012-06-16 16:48 Torr Samaho Note Added: 0003784
2012-06-16 22:56 Qent File Added: test_telefragvoodoo.wad
2012-06-16 22:57 Qent Note Added: 0003789
2012-06-18 19:34 Torr Samaho Note Added: 0003807
2012-06-19 01:38 Qent Note Added: 0003811
2012-06-19 05:14 Torr Samaho Status needs testing => resolved
2012-06-19 05:14 Torr Samaho Fixed in Version => 1.0
2012-06-19 05:14 Torr Samaho Resolution open => fixed
2018-09-30 19:53 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker