MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000589Zandronum[All Projects] Suggestionpublic2011-09-20 23:282018-09-30 19:53
ReporterM0rbid Desire 
Assigned ToTorr Samaho 
PrioritylowSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindows 7OS Version64-bits
Product Version 
Target VersionFixed in Version1.0 
Summary0000589: Set THRUSPECIES as dmflag
DescriptionWould be useful to set this feature as dmflag, so you'll dont need to edit the "doomplayer" DECORATE to add a simple line.
Steps To Reproduce
Additional InformationNOTE: This feature aint important yet, cause we haven't tested 100%, there's still some issues that we aren't sure.
TagsNo tags attached.
Relationships
Attached Files? test_telefragvoodoo.wad (4,590) 2012-06-16 22:56
/tracker/file_download.php?file_id=629&type=bug
Issue History
Date ModifiedUsernameFieldChange
2011-09-20 23:28M0rbid DesireNew Issue
2011-09-21 21:05DevonNote Added: 0002203
2012-04-22 19:31Torr SamahoAssigned To => Torr Samaho
2012-04-22 19:31Torr SamahoStatusnew => confirmed
2012-04-22 22:14Torr SamahoNote Added: 0003389
2012-04-22 23:55Edward-sanNote Added: 0003392
2012-04-23 00:17Torr SamahoNote Added: 0003393
2012-04-23 00:19Torr SamahoStatusconfirmed => feedback
2012-04-23 00:33Edward-sanNote Added: 0003394
2012-04-23 00:35Torr SamahoNote Added: 0003395
2012-04-23 06:02unknownnaNote Added: 0003398
2012-04-23 11:22Torr SamahoNote Added: 0003400
2012-04-23 11:38unknownnaNote Added: 0003401
2012-04-23 13:41DuskNote Added: 0003402
2012-04-23 13:41DuskNote Edited: 0003402bug_revision_view_page.php?bugnote_id=3402#r1812
2012-04-24 00:43HypnotoadNote Added: 0003410
2012-04-24 00:50Torr SamahoNote Added: 0003412
2012-04-29 20:49HypnotoadNote Added: 0003495
2012-04-29 20:50HypnotoadNote Added: 0003496
2012-05-01 10:31HisymakNote Added: 0003527
2012-05-01 10:53unknownnaNote Added: 0003528
2012-05-01 11:43DuskNote Added: 0003531
2012-05-01 11:49Torr SamahoNote Added: 0003533
2012-05-03 00:47DuskNote Added: 0003561
2012-05-03 00:48DuskStatusfeedback => assigned
2012-05-03 01:01DuskNote Edited: 0003561bug_revision_view_page.php?bugnote_id=3561#r1926
2012-05-03 01:09DuskNote Edited: 0003561bug_revision_view_page.php?bugnote_id=3561#r1927
2012-05-03 01:16DuskNote Edited: 0003561bug_revision_view_page.php?bugnote_id=3561#r1928
2012-05-03 01:16DuskNote Edited: 0003561bug_revision_view_page.php?bugnote_id=3561#r1929
2012-05-03 01:16DuskStatusassigned => needs review
2012-05-08 01:55Torr SamahoNote Added: 0003591
2012-05-08 01:56Torr SamahoStatusneeds review => feedback
2012-05-27 09:51Torr SamahoStatusfeedback => needs testing
2012-06-12 22:36QentNote Added: 0003745
2012-06-15 12:29DuskSummary[Further versions] Set THRUSPECIES as dmflag => Set THRUSPECIES as dmflag
2012-06-16 16:48Torr SamahoNote Added: 0003784
2012-06-16 22:56QentFile Added: test_telefragvoodoo.wad
2012-06-16 22:57QentNote Added: 0003789
2012-06-18 19:34Torr SamahoNote Added: 0003807
2012-06-19 01:38QentNote Added: 0003811
2012-06-19 05:14Torr SamahoStatusneeds testing => resolved
2012-06-19 05:14Torr SamahoFixed in Version => 1.0
2012-06-19 05:14Torr SamahoResolutionopen => fixed
2018-09-30 19:53Blzut3Statusresolved => closed

Notes
(0002203)
Devon   
2011-09-21 21:05   
Simpler and easier. Good idea.
(0003389)
Torr Samaho   
2012-04-22 22:14   
Before I implement this, how should the flag be named?
(0003392)
Edward-san   
2012-04-22 23:55   
I'm not sure why isn't it labeled as [Ask ZDoom], but yeah, it seems a good idea.

Quote

NOTE: This feature aint important yet, cause we haven't tested 100%, there's still some issues that we aren't sure.

Please check out them accurately. If there are still some issues, create a new ticket about them.
(0003393)
Torr Samaho   
2012-04-23 00:17   
Here is a testing binary, the flag is called sv_unblockplayers.
(0003394)
Edward-san   
2012-04-23 00:33   
Does this flag ignore the '+THRUSPECIES' property in the decorate definition?
(0003395)
Torr Samaho   
2012-04-23 00:35   
Activating this flag will make player bodies act as if they have THRUSPECIES, no matter if the body actually has it or not.
(0003398)
unknownna   
2012-04-23 06:02   
> Here is a testing binary, the flag is called sv_unblockplayers.

It seems to work, but players are still able to telefrag each other.
(0003400)
Torr Samaho   
2012-04-23 11:22   
> but players are still able to telefrag each other.

Does THRUSPECIES prevent telefragging in ZDoom?
(0003401)
unknownna   
2012-04-23 11:38   
Not in 2.5.0 and SVN build 3587.
(0003402)
Dusk   
2012-04-23 13:41   
When the +THRUSPECIES flag was added, testing showed telefrags can be avoided by nullifying out the SpawnTelefrag damage. I'd believe that this dmflag should imply immunity to that.
(0003410)
Hypnotoad   
2012-04-24 00:43   
Agree with Dusk, if you don't remove spawnfrag and telefragging it will defeat the purpose of having it as a server flag, as you will still have to apply a patchwad to remove them.
(0003412)
Torr Samaho   
2012-04-24 00:50   
The original request was to apply THRUSPECIES to player bodies and this is exactly what I did. If you want to refine the original request, that's fine, but you will need to specify exactly what you want. And technically all supporters would have to reassure their support since the request itself is changed.

So, was there a small mod that did exactly what you had in mind with this request? If so, please post it here.
(0003495)
Hypnotoad   
2012-04-29 20:49   
This is exactly what is wanted, applying the following to player body decorate:

+THRUSPECIES
DamageFactor "Telefrag", 0
DamageFactor "SpawnTelefrag", 0

I am certain all supporters agree with this, I haven't encountered a single person who would disagree.

Thanks
(0003496)
Hypnotoad   
2012-04-29 20:50   
Oh and optionally you could apply +MTHRUSPECIES to the rocket decorate (and grenade I guess?) to make rockets go through people.
(0003527)
Hisymak   
2012-05-01 10:31   
+THRUSPECIES
DamageFactor "Telefrag", 0
DamageFactor "SpawnTelefrag", 0
- I agree.

But why make rockets go through people?
(0003528)
unknownna   
2012-05-01 10:53   
> When the +THRUSPECIES flag was added, testing showed telefrags can be avoided by nullifying out the SpawnTelefrag damage. I'd believe that this dmflag should imply immunity to that.

This work-around doesn't seem to take care of the regular telefrags that occur after using teleporters.

> DamageFactor "Telefrag", 0

The problem with this is that players will not be telefragged by non-player things, e.g., the spawn cubes in MAP30.
(0003531)
Dusk   
2012-05-01 11:43   
Maybe we could add an exception to player-player telefrags in damage factoring code to implement the dmflag function properly?
(0003533)
Torr Samaho   
2012-05-01 11:49   
> Maybe we could add an exception to player-player telefrags in damage factoring code to implement the dmflag function properly?

Yes, I think this is the way to go, i.e. reduce damage dealt to a player to zero if it is of type Telefrag or SpawnTelefrag, the source is another player and sv_unblockplayers is true. Do you want to give this a shot or shall I take care of it?
(0003561)
Dusk   
2012-05-03 00:47   
(edited on: 2012-05-03 01:16)
Sure, I'll deal away this one.

[EDIT] Done:
'https://bitbucket.org/CrimsonDusk/notebola/changeset/ba08c293ec9d [^]'
(0003591)
Torr Samaho   
2012-05-08 01:55   
Patch added with an additional ( source != NULL ) check.
(0003745)
Qent   
2012-06-12 22:36   
This DMFlag also prevents telefragging voodoo dolls even when sv_coopunassignedvoodoodolls is false. How should this be treated? On one hand, it could break levels that use voodoo doll telefrags as deathtraps; but on the other hand, voodoo dolls are rare, and I had thought that support for them online was already hacky and unreliable.
(0003784)
Torr Samaho   
2012-06-16 16:48   
Quote from Qent

This DMFlag also prevents telefragging voodoo dolls even when sv_coopunassignedvoodoodolls is false. How should this be treated?

Can you make a minimal example wad? I think this should be easy to fix.
(0003789)
Qent   
2012-06-16 22:57   
test_telefragvoodoo.wad

Aside from that, sv_unblockplayers worked perfectly in SNS today.
(0003807)
Torr Samaho   
2012-06-18 19:34   
This should restore telefragging for voodoo dolls.
(0003811)
Qent   
2012-06-19 01:38   
Yes, thanks; it works on- and offline.